Bug 44961 - i915_min_freq reduction throws off frequency management
Summary: i915_min_freq reduction throws off frequency management
Status: RESOLVED INSUFFICIENT_DATA
Alias: None
Product: Drivers
Classification: Unclassified
Component: Video(DRI - Intel) (show other bugs)
Hardware: All Linux
: P3 low
Assignee: intel-gfx-bugs@lists.freedesktop.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-20 19:05 UTC by Eric Anholt
Modified: 2014-09-26 11:40 UTC (History)
4 users (show)

See Also:
Kernel Version: 3.5.0-rc4+
Subsystem:
Regression: No
Bisected commit-id:


Attachments
use hsw rps thresholds (948 bytes, patch)
2012-08-08 09:26 UTC, Daniel Vetter
Details | Diff

Description Eric Anholt 2012-07-20 19:05:27 UTC
I was trying to get some benchmarking numbers for a performance issue I thought I was seeing in l4d2 (CAGF would drop down to 350 during the benchmark run, despite intel_gpu_top reporting 98% render ring busy, and the only stalls being swapbuffers throttling), so I wanted to compare against just always having the GPU at maximum.

However, when I tried doing back to back test runs on some other apps, switching between i915_min_freq of 350 (default) and 1250 (max), after a transition from 1250 to 350, it would take about 2 seconds for the frequency to climb up to maximum during a benchmark.  On repeated runs of the benchmark after that, it would make a quick jump from CAGF of 350 to 1250.  This means that my usual method of comparing performance between the two modes sees a spurious performance delta, up to 40% for citybench.
Comment 1 Alan 2012-08-08 09:21:01 UTC
(dinq 2b749b2ea1356a34449bb83c03eb7e43513b3f20 )
Comment 2 Daniel Vetter 2012-08-08 09:26:23 UTC
Created attachment 77121 [details]
use hsw rps thresholds

vpg has given us totally new rps thresholds for hsw, and I guess we can try whether they make more sense on ivb/snb, too. Does this help (both for the slow ramp and the spurious downclock)?
Comment 3 Jani Nikula 2013-01-08 14:25:26 UTC
Eric, is this still an issue? The attached patch has been available upstream since v3.6 as commit:

commit 1ee9ae3244c4789f3184c5123f3b2d7e405b3f4c
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Wed Aug 15 10:41:45 2012 +0200

    drm/i915: use hsw rps tuning values everywhere on gen6+
Comment 4 Ben Widawsky 2013-02-16 23:54:52 UTC
I presume they're using the sysfs interfaces for most of the benchmarking. Eric, can we close this?
Comment 5 Eric Anholt 2013-02-17 00:46:47 UTC
Well, I'm now frequently seeing it take a minute of activity to get the GPU to kick into high frequency, so I wouldn't describe things as "working", and I wouldn't be able to distinguish a mere 2 seconds any more.
Comment 6 Ben Widawsky 2013-02-17 00:55:48 UTC
Speaking as me: I'm not interested in how long it takes to kick into high frequency. I'm interested in the how long it takes until it kicks into a high enough frequency to hit the target framerate. (Inversely, if it takes far too long to throttle back down, I also am interested in solving such issues).

I've heard of tests where even that is an issue though. Do we have a record of any of those type of failures? Is your original bug an example of that? Do we have a target for what's an acceptable delay?
Comment 7 Eric Anholt 2013-02-17 05:39:23 UTC
Well, the one yesterday was the app running at 3fps instead of 8.
Comment 8 Jani Nikula 2014-09-26 11:40:43 UTC
I presume Eric is no longer very interested in this bug, and judging by the activity here in the last two years, nobody else has really shown interest either. I admit a bug may exist, but having this one hang around clearly isn't helping. Anyway, please reopen or file new bugs at fdo if the problem persists and you can provide further details. Thanks.

Note You need to log in before you can comment on or make changes to this bug.