42812 – kvm module has bogus kernel version check

Bug 42812 - kvm module has bogus kernel version check

Summary: kvm module has bogus kernel version check

Status:	CLOSED CODE_FIX

Alias:	None

Product:	Virtualization
Classification:	Unclassified
Component:	kvm (show other bugs)
Hardware:	All Linux

Importance:	P1 normal
Assignee:	virtualization_kvm

URL:
Keywords:

Depends on:
Blocks:

Reported:	2012-02-22 22:53 UTC by MCB
Modified:	2012-05-12 02:13 UTC (History)
CC List:	2 users (show)

See Also:
Kernel Version:
Subsystem:
Regression:	No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MCB 2012-02-22 22:53:32 UTC

In kvm-kmod-3.2, x86/external-module-compat.h, line 1102 the following check is present:

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) || \
    (LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) && KERNEL_EXTRAVERSION < 40)

The second half is bogus, since if kernel version is 2.6.32, it would have matched the < 2.6.37 anyway.
Maybe the 2,6,32 should read 2,6,37 instead? (that would make more sense, but may not be right!)

This check appears to be present since kvm-kmod release 3.0b, which makes it unlikely many people tried it with 2.6.27.40+ kernels and found it to be a problem...

--
Maarten

Comment 1 Jan Kiszka 2012-02-28 17:29:13 UTC

Thanks for reporting, addressed in latest kvm-kmod.git.

Jan

Note You need to log in before you can comment on or make changes to this bug.