Created attachment 66952 [details] output of acpidump I cannot insert the toshiba_acpi on my laptop: $ sudo modprobe toshiba_acpi FATAL: Error inserting toshiba_acpi (/lib/modules/3.0.0-1-amd64/kernel/drivers/platform/x86/toshiba_acpi.ko): No such device as such computer is runnning with fan all time long. Sometimes, it suddenly reboots for no reason when doing compilation (make -j4).
Created attachment 66962 [details] output of dmidecode
Please attach output of the dmesg after inserting toshiba_acpi.ko.
There is absolutely nothing added in the output of dmesg. $ sudo insmod /lib/modules/3.0.0-1-amd64/kernel/drivers/platform/x86/toshiba_acpi.ko insmod: error inserting '/lib/modules/3.0.0-1-amd64/kernel/drivers/platform/x86/toshiba_acpi.ko': -1 No such device
Created attachment 67862 [details] debug.patch Please apply the patch. load and attach the output of dmesg.
Here is the new output of dmesg: [53933.532862] toshiba_acpi: no simple device $ sudo modinfo toshiba_acpi.ko filename: toshiba_acpi.ko license: GPL description: Toshiba Laptop ACPI Extras Driver author: John Belmonte alias: acpi*:TOS1900:* alias: acpi*:TOS6208:* alias: acpi*:TOS6200:* depends: rfkill,sparse-keymap vermagic: 3.0.0-1-amd64 SMP mod_unload modversions
In the DSDT, there is not "GHCI" method under device "VALZ". So the toshiba_acpi driver can't be loaded. The driver first check whether there is a valid path for hci method in the DSDT. static int __init toshiba_acpi_init(void) { ... /* simple device detection: look for HCI method */ if (is_valid_acpi_path(TOSH_INTERFACE_1 GHCI_METHOD)) { method_hci = TOSH_INTERFACE_1 GHCI_METHOD; if (toshiba_acpi_setup_keyboard(TOSH_INTERFACE_1)) pr_info("Unable to activate hotkeys\n"); } else if (is_valid_acpi_path(TOSH_INTERFACE_2 GHCI_METHOD)) { method_hci = TOSH_INTERFACE_2 GHCI_METHOD; if (toshiba_acpi_setup_keyboard(TOSH_INTERFACE_2)) pr_info("Unable to activate hotkeys\n"); } else return -ENODEV; ... } if not, return back.
I did follow instructions from: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/735756 which pointed me to: http://people.canonical.com/~sforshee/lp735756/ When loading this new toshiba_acpi module one gets in dmesg: [150040.763112] toshiba_acpi: Toshiba Laptop ACPI Extras version 0.20 [150040.763141] toshiba_acpi: HCI type 2 (SPFC) [150040.763972] input: Toshiba input device as /devices/virtual/input/input15 [150040.776320] toshiba_acpi: Illumination not supported Let me know if you need anything else.
Created attachment 70882 [details] proposed patch
http://marc.info/?l=linux-kernel&m=131465192113854&w=2 Seth has sent related patchs to lkml. Just waitting.
Tianyu, please update the status of this bug.
Seth's patch has been merged into upstream kernel. commit 6e02cc7eb61aeafadb91f7b591a768cdb7a57740 Author: Seth Forshee <seth.forshee@canonical.com> Date: Tue Sep 20 16:55:51 2011 -0500 toshiba_acpi: Use handle for HCI calls Now that we're using an acpi driver we already have a handle to the namespace of the HCI call, so there's no need to test various paths to the HCI call or even be aware of the path at all. So the bug should be resolved in the upstream kernel. Please check the bug in the lastest upstream kernel.
Looks good to me: $ sudo modinfo toshiba_acpi filename: /lib/modules/3.2.0-1-amd64/kernel/drivers/platform/x86/toshiba_acpi.ko license: GPL description: Toshiba Laptop ACPI Extras Driver author: John Belmonte alias: acpi*:TOS1900:* alias: acpi*:TOS6208:* alias: acpi*:TOS6200:* depends: rfkill,sparse-keymap intree: Y vermagic: 3.2.0-1-amd64 SMP mod_unload modversions Thanks for working on this
6e02cc7eb61aeafadb91f7b591a768cdb7a57740 toshiba_acpi: Use handle for HCI calls shipped in linux 3.2 closed