37412 – sysfs: cannot create duplicate filename '/devices/platform/GHES.9'

Bug 37412 - sysfs: cannot create duplicate filename '/devices/platform/GHES.9'

Summary: sysfs: cannot create duplicate filename '/devices/platform/GHES.9'

Status:	CLOSED CODE_FIX

Alias:	None

Product:	ACPI
Classification:	Unclassified
Component:	BIOS (show other bugs)
Hardware:	All Linux

Importance:	P1 high
Assignee:	acpi_bios

URL:	https://bugs.launchpad.net/ubuntu/+so...
Keywords:

Depends on:
Blocks:

Reported:	2011-06-13 12:10 UTC by njin
Modified:	2011-07-31 18:01 UTC (History)
CC List:	6 users (show)

See Also:
Kernel Version:	2.6.38 to 3.0-rc2
Subsystem:
Regression:	Yes
Bisected commit-id:

Attachments
Detect duplicated hardware error source ID in HEST (1.24 KB, text/plain) 2011-06-17 01:05 UTC, Huang Ying	Details
That should be the dmesg output from unpached kernel (66.98 KB, text/plain) 2011-06-22 08:51 UTC, Mathias	Details
This should be the patched output. (63.50 KB, text/plain) 2011-06-22 13:15 UTC, Mathias	Details
Add an attachment (proposed patch, testcase, etc.)

Description njin 2011-06-13 12:10:30 UTC

Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381050] WARNING: at /home/kernel-ppa/COD/linux/fs/sysfs/dir.c:455 sysfs_add_one+0xbb/0xe0()
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381054] Hardware name: 2545A12
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381057] sysfs: cannot create duplicate filename '/devices/platform/GHES.9'
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381061] Modules linked in:
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381066] Pid: 1, comm: swapper Not tainted 3.0.0-0300rc2-generic #201106081532
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381071] Call Trace:
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381079]  [<ffffffff811d93bb>] ? sysfs_add_one+0xbb/0xe0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381086]  [<ffffffff810611d0>] warn_slowpath_common+0x90/0xc0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381092]  [<ffffffff810612fe>] warn_slowpath_fmt+0x6e/0x70
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381098]  [<ffffffff811d8e95>] ? sysfs_pathname+0x45/0x60
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381104]  [<ffffffff811d8e95>] ? sysfs_pathname+0x45/0x60
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381109]  [<ffffffff811d8e95>] ? sysfs_pathname+0x45/0x60
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381115]  [<ffffffff811d93bb>] sysfs_add_one+0xbb/0xe0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381121]  [<ffffffff811d96ba>] create_dir+0x7a/0xd0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381128]  [<ffffffff81b0b470>] ? setup_hest_disable+0x20/0x20
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381133]  [<ffffffff811d9768>] sysfs_create_dir+0x58/0x90
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381140]  [<ffffffff812e3852>] create_dir+0x22/0x60
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381146]  [<ffffffff812e3d91>] kobject_add_internal+0x91/0x110
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381153]  [<ffffffff812e3f8d>] kobject_add_varg+0x5d/0x70
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381159]  [<ffffffff812e4099>] kobject_add+0x69/0x90
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381166]  [<ffffffff813c7f89>] ? dev_set_name+0x69/0x70
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381172]  [<ffffffff812e3baa>] ? kobject_get+0x1a/0x30
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381178]  [<ffffffff811552ad>] ? kmem_cache_alloc_trace+0x8d/0x110
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381184]  [<ffffffff813c9576>] ? setup_parent+0x16/0x30
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381189]  [<ffffffff813c9641>] device_add+0xb1/0x370
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381195]  [<ffffffff813cddc2>] platform_device_add+0x182/0x1d0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381201]  [<ffffffff81b0b470>] ? setup_hest_disable+0x20/0x20
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381206]  [<ffffffff81b0b4e5>] hest_parse_ghes+0x75/0xa0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381213]  [<ffffffff813769c5>] apei_hest_parse+0x65/0xd0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381218]  [<ffffffff81b0b553>] hest_ghes_dev_register+0x43/0x90
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381224]  [<ffffffff81b0a96d>] ? find_dock+0x23/0x23
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381229]  [<ffffffff81b0b63c>] acpi_hest_init+0x9c/0xd0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381234]  [<ffffffff81b0a976>] acpi_pci_root_init+0x9/0x32
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381241]  [<ffffffff81002168>] do_one_initcall+0xe8/0x130
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381247]  [<ffffffff81ace6cc>] do_initcalls+0x2c/0x40
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381253]  [<ffffffff81ace84a>] do_basic_setup+0x2a/0x30
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381259]  [<ffffffff81acec1a>] kernel_init+0x8a/0x110
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381265]  [<ffffffff815e90a4>] kernel_thread_helper+0x4/0x10
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381271]  [<ffffffff81aceb90>] ? do_early_param+0xd0/0xd0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381277]  [<ffffffff815e90a0>] ? gs_change+0x13/0x13
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381287] ---[ end trace 5a5d197966b56a2e ]---
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381293] kobject_add_internal failed for GHES.9 with -EEXIST, don't try to register things with the same name in the same directory.
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381307] Pid: 1, comm: swapper Tainted: G        W   3.0.0-0300rc2-generic #201106081532
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381311] Call Trace:
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381317]  [<ffffffff812e3ddc>] kobject_add_internal+0xdc/0x110
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381323]  [<ffffffff812e3f8d>] kobject_add_varg+0x5d/0x70
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381329]  [<ffffffff812e4099>] kobject_add+0x69/0x90
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381335]  [<ffffffff813c7f89>] ? dev_set_name+0x69/0x70
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381341]  [<ffffffff812e3baa>] ? kobject_get+0x1a/0x30
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381346]  [<ffffffff811552ad>] ? kmem_cache_alloc_trace+0x8d/0x110
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381352]  [<ffffffff813c9576>] ? setup_parent+0x16/0x30
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381357]  [<ffffffff813c9641>] device_add+0xb1/0x370
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381362]  [<ffffffff813cddc2>] platform_device_add+0x182/0x1d0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381368]  [<ffffffff81b0b470>] ? setup_hest_disable+0x20/0x20
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381373]  [<ffffffff81b0b4e5>] hest_parse_ghes+0x75/0xa0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381378]  [<ffffffff813769c5>] apei_hest_parse+0x65/0xd0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381384]  [<ffffffff81b0b553>] hest_ghes_dev_register+0x43/0x90
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381389]  [<ffffffff81b0a96d>] ? find_dock+0x23/0x23
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381394]  [<ffffffff81b0b63c>] acpi_hest_init+0x9c/0xd0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381399]  [<ffffffff81b0a976>] acpi_pci_root_init+0x9/0x32
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381405]  [<ffffffff81002168>] do_one_initcall+0xe8/0x130
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381411]  [<ffffffff81ace6cc>] do_initcalls+0x2c/0x40
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381417]  [<ffffffff81ace84a>] do_basic_setup+0x2a/0x30
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381422]  [<ffffffff81acec1a>] kernel_init+0x8a/0x110
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381428]  [<ffffffff815e90a4>] kernel_thread_helper+0x4/0x10
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381434]  [<ffffffff81aceb90>] ? do_early_param+0xd0/0xd0
Jun 12 22:06:33 ThinkPad-Edge kernel: [    0.381440]  [<ffffffff815e90a0>] ? gs_change+0x13/0x13

Comment 1 njin 2011-06-13 12:14:44 UTC

system randomly freeze

Comment 2 Greg Kroah-Hartman 2011-06-13 19:01:51 UTC

This is a driver bug, not a sysfs one, sysfs is warning that the driver is doing
something wrong.

Comment 3 Rafael J. Wysocki 2011-06-13 19:35:26 UTC

That's not even a driver bug, it's an ACPI APEI problem.

Comment 4 Huang Ying 2011-06-15 02:24:57 UTC

It appears that your system has duplicated HEST error source ID, which may be a firmware bug.  But we need to fix APEI driver to provide better error information. I will do that.

But that should not cause your system randomly freezing.  Please try to use "hest_disable=1" in your kernel command line to test.

Comment 5 Huang Ying 2011-06-17 01:05:15 UTC

Created attachment 62402 [details]
Detect duplicated hardware error source ID in HEST

njin, Can you help us to test the patch attached?

Comment 6 Mathias 2011-06-18 13:38:33 UTC

Hi. I am the owner of that Thinkpad device. Maybe I could help, but can you tell me how?
Thanks.

Comment 7 Len Brown 2011-06-21 01:56:19 UTC

Mathias,
can you test the patch in comment #5?

Comment 8 Mathias 2011-06-21 09:22:27 UTC

I will do that as soon as possible. 
I need a little time to find out how to compile a kernel. I did not do that until now. So please be patient.
Thanks.

Comment 9 Mathias 2011-06-22 08:51:31 UTC

Created attachment 63142 [details]
That should be the dmesg output from unpached kernel

Comment 10 Mathias 2011-06-22 13:15:30 UTC

Created attachment 63172 [details]
This should be the patched output.

Comment 11 Huang Ying 2011-06-23 00:26:17 UTC

Thanks Mathias!  It seems that the patch works.

Len,  Can you take the patch?

Comment 12 Len Brown 2011-07-14 03:41:48 UTC

patch in comment #5 applied to acpi tree

Comment 13 Len Brown 2011-07-31 18:01:32 UTC

shipped in v3.0, closed:


commit 4d2b2956ef1113f1cc43e98e947c20d9c7d2712c
Author: Huang Ying <ying.huang@intel.com>
Date:   Wed Jul 13 13:14:12 2011 +0800

    ACPI, APEI, HEST, Detect duplicated hardware error source ID
    
    The firmware on some machine will report duplicated hardware error
    source ID in HEST.  This is considered a firmware bug.  To provide
    better warning message, this patch adds duplicated hardware error
    source ID detecting and corresponding printk.
    
    This patch fixes #37412 on kernel bugzilla:
    https://bugzilla.kernel.org/show_bug.cgi?id=37412
    
    Reported-by: marconifabio@ubuntu-it.org
    Signed-off-by: Huang Ying <ying.huang@intel.com>
    Tested-by: Mathias <janedo.spam@gmail.com>
    Signed-off-by: Len Brown <len.brown@intel.com>

Note You need to log in before you can comment on or make changes to this bug.