Bug 37332 - Regression d72bce0e67e8afc6eb959f656013cbb577426f1e
Regression d72bce0e67e8afc6eb959f656013cbb577426f1e
Status: CLOSED CODE_FIX
Product: Process Management
Classification: Unclassified
Component: Other
All Linux
: P1 normal
Assigned To: process_other
:
Depends on:
Blocks: 36912
  Show dependency treegraph
 
Reported: 2011-06-12 17:26 UTC by Helber Maciel Guerra
Modified: 2011-06-21 12:12 UTC (History)
4 users (show)

See Also:
Kernel Version: 3.0-rc2
Tree: Mainline
Regression: Yes


Attachments
Bisect (1.83 KB, application/octet-stream)
2011-06-12 17:26 UTC, Helber Maciel Guerra
Details
Startup kernel panic. (50 bytes, text/plain)
2011-06-14 02:54 UTC, Helber Maciel Guerra
Details
Startup kernel panic. (50 bytes, text/plain)
2011-06-14 03:19 UTC, Helber Maciel Guerra
Details

Description Helber Maciel Guerra 2011-06-12 17:26:23 UTC
Created attachment 61692 [details]
Bisect 

I got a kernel panic - not syncing: hung_task: blocked tasks
Comment 1 Andrew Morton 2011-06-13 22:55:08 UTC
On Mon, 13 Jun 2011 15:34:43 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:

> On Mon, Jun 13, 2011 at 03:08:33PM -0700, Andrew Morton wrote:
> > On Sun, 12 Jun 2011 17:26:26 GMT
> > bugzilla-daemon@bugzilla.kernel.org wrote:
> > 
> > > https://bugzilla.kernel.org/show_bug.cgi?id=37332
> > 
> > A post-2.6.39 crash bisected to d72bce0e67e8a ("rcu: Cure load woes").
> 
> Does the following patch help?

We'd better ask Helber, the reporter ;)

And cc the bugzilla report too, if we're doing it this way.
 


rcu: Simplify curing of load woes

Make the functions creating the kthreads wake them up.  Leverage the
fact that the per-node and boost kthreads can run anywhere, thus
dispensing with the need to wake them up once the incoming CPU has
gone fully online.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index 89419ff..0a8ec5b 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -1635,6 +1635,20 @@ static int rcu_cpu_kthread(void *arg)
  * to manipulate rcu_cpu_kthread_task.  There might be another CPU
  * attempting to access it during boot, but the locking in kthread_bind()
  * will enforce sufficient ordering.
+ *
+ * Please note that we cannot simply refuse to wake up the per-CPU
+ * kthread because kthreads are created in TASK_UNINTERRUPTIBLE state,
+ * which can result in softlockup complaints if the task ends up being
+ * idle for more than a couple of minutes.
+ *
+ * However, please note also that we cannot bind the per-CPU kthread to its
+ * CPU until that CPU is fully online.  We also cannot wait until the
+ * CPU is fully online before we create its per-CPU kthread, as this would
+ * deadlock the system when CPU notifiers tried waiting for grace
+ * periods.  So we bind the per-CPU kthread to its CPU only if the CPU
+ * is online.  If its CPU is not yet fully online, then the code in
+ * rcu_cpu_kthread() will wait until it is fully online, and then do
+ * the binding.
  */
 static int __cpuinit rcu_spawn_one_cpu_kthread(int cpu)
 {
@@ -1647,12 +1661,14 @@ static int __cpuinit rcu_spawn_one_cpu_kthread(int cpu)
 	t = kthread_create(rcu_cpu_kthread, (void *)(long)cpu, "rcuc%d", cpu);
 	if (IS_ERR(t))
 		return PTR_ERR(t);
-	kthread_bind(t, cpu);
+	if (cpu_online(cpu))
+		kthread_bind(t, cpu);
 	per_cpu(rcu_cpu_kthread_cpu, cpu) = cpu;
 	WARN_ON_ONCE(per_cpu(rcu_cpu_kthread_task, cpu) != NULL);
-	per_cpu(rcu_cpu_kthread_task, cpu) = t;
 	sp.sched_priority = RCU_KTHREAD_PRIO;
 	sched_setscheduler_nocheck(t, SCHED_FIFO, &sp);
+	per_cpu(rcu_cpu_kthread_task, cpu) = t;
+	wake_up_process(t); /* Get to TASK_INTERRUPTIBLE quickly. */
 	return 0;
 }
 
@@ -1759,12 +1775,11 @@ static int __cpuinit rcu_spawn_one_node_kthread(struct rcu_state *rsp,
 		raw_spin_unlock_irqrestore(&rnp->lock, flags);
 		sp.sched_priority = 99;
 		sched_setscheduler_nocheck(t, SCHED_FIFO, &sp);
+		wake_up_process(t); /* get to TASK_INTERRUPTIBLE quickly. */
 	}
 	return rcu_spawn_one_boost_kthread(rsp, rnp, rnp_index);
 }
 
-static void rcu_wake_one_boost_kthread(struct rcu_node *rnp);
-
 /*
  * Spawn all kthreads -- called as soon as the scheduler is running.
  */
@@ -1772,30 +1787,18 @@ static int __init rcu_spawn_kthreads(void)
 {
 	int cpu;
 	struct rcu_node *rnp;
-	struct task_struct *t;
 
 	rcu_kthreads_spawnable = 1;
 	for_each_possible_cpu(cpu) {
 		per_cpu(rcu_cpu_has_work, cpu) = 0;
-		if (cpu_online(cpu)) {
+		if (cpu_online(cpu))
 			(void)rcu_spawn_one_cpu_kthread(cpu);
-			t = per_cpu(rcu_cpu_kthread_task, cpu);
-			if (t)
-				wake_up_process(t);
-		}
 	}
 	rnp = rcu_get_root(rcu_state);
 	(void)rcu_spawn_one_node_kthread(rcu_state, rnp);
-	if (rnp->node_kthread_task)
-		wake_up_process(rnp->node_kthread_task);
 	if (NUM_RCU_NODES > 1) {
-		rcu_for_each_leaf_node(rcu_state, rnp) {
+		rcu_for_each_leaf_node(rcu_state, rnp)
 			(void)rcu_spawn_one_node_kthread(rcu_state, rnp);
-			t = rnp->node_kthread_task;
-			if (t)
-				wake_up_process(t);
-			rcu_wake_one_boost_kthread(rnp);
-		}
 	}
 	return 0;
 }
@@ -2221,31 +2224,6 @@ static void __cpuinit rcu_prepare_kthreads(int cpu)
 }
 
 /*
- * kthread_create() creates threads in TASK_UNINTERRUPTIBLE state,
- * but the RCU threads are woken on demand, and if demand is low this
- * could be a while triggering the hung task watchdog.
- *
- * In order to avoid this, poke all tasks once the CPU is fully
- * up and running.
- */
-static void __cpuinit rcu_online_kthreads(int cpu)
-{
-	struct rcu_data *rdp = per_cpu_ptr(rcu_state->rda, cpu);
-	struct rcu_node *rnp = rdp->mynode;
-	struct task_struct *t;
-
-	t = per_cpu(rcu_cpu_kthread_task, cpu);
-	if (t)
-		wake_up_process(t);
-
-	t = rnp->node_kthread_task;
-	if (t)
-		wake_up_process(t);
-
-	rcu_wake_one_boost_kthread(rnp);
-}
-
-/*
  * Handle CPU online/offline notification events.
  */
 static int __cpuinit rcu_cpu_notify(struct notifier_block *self,
@@ -2262,7 +2240,6 @@ static int __cpuinit rcu_cpu_notify(struct notifier_block *self,
 		rcu_prepare_kthreads(cpu);
 		break;
 	case CPU_ONLINE:
-		rcu_online_kthreads(cpu);
 	case CPU_DOWN_FAILED:
 		rcu_node_kthread_setaffinity(rnp, -1);
 		rcu_cpu_kthread_setrt(cpu, 1);
diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
index c8bff30..ea2e2fb 100644
--- a/kernel/rcutree_plugin.h
+++ b/kernel/rcutree_plugin.h
@@ -1299,15 +1299,10 @@ static int __cpuinit rcu_spawn_one_boost_kthread(struct rcu_state *rsp,
 	raw_spin_unlock_irqrestore(&rnp->lock, flags);
 	sp.sched_priority = RCU_KTHREAD_PRIO;
 	sched_setscheduler_nocheck(t, SCHED_FIFO, &sp);
+	wake_up_process(t); /* get to TASK_INTERRUPTIBLE quickly. */
 	return 0;
 }
 
-static void __cpuinit rcu_wake_one_boost_kthread(struct rcu_node *rnp)
-{
-	if (rnp->boost_kthread_task)
-		wake_up_process(rnp->boost_kthread_task);
-}
-
 #else /* #ifdef CONFIG_RCU_BOOST */
 
 static void rcu_initiate_boost(struct rcu_node *rnp, unsigned long flags)
@@ -1331,10 +1326,6 @@ static int __cpuinit rcu_spawn_one_boost_kthread(struct rcu_state *rsp,
 	return 0;
 }
 
-static void __cpuinit rcu_wake_one_boost_kthread(struct rcu_node *rnp)
-{
-}
-
 #endif /* #else #ifdef CONFIG_RCU_BOOST */
 
 #ifndef CONFIG_SMP
Comment 2 Helber Maciel Guerra 2011-06-14 02:51:41 UTC
Without change, the system works for some time 120 seconds.
With this patch kernel panic is on startup.

Can i do more tests or test some more patch?

Thank for your help, Helber Maciel Guerra.
Comment 3 Helber Maciel Guerra 2011-06-14 02:54:48 UTC
Created attachment 61892 [details]
Startup kernel panic.

This is a 3.0.0-rc2-helber.x86_64 screen 120 seconds.
Comment 4 Helber Maciel Guerra 2011-06-14 03:19:10 UTC
Created attachment 61902 [details]
Startup kernel panic.

Startup kernel panic with patch.
Comment 5 Peter Zijlstra 2011-06-14 12:00:25 UTC
On Mon, 2011-06-13 at 15:54 -0700, Andrew Morton wrote:
> And cc the bugzilla report too, if we're doing it this way.
>  

Steven fixed that select_task_rq_rt() thing here:

lkml.kernel.org/r/1308014683.9218.107.camel@gandalf.stny.rr.com
Comment 6 Helber Maciel Guerra 2011-06-14 13:17:22 UTC
I try this patch but don't solve the problem.
Comment 7 Rafael J. Wysocki 2011-06-14 19:20:51 UTC
First-Bad-Commit : d72bce0e67e8afc6eb959f656013cbb577426f1e
Comment 8 Helber Maciel Guerra 2011-06-21 00:14:17 UTC
This bug was fixed on commit: f8b7fc6b514f34a51875dd48dff70d4d17a54f38
Merge: 357ed6b1a110048ff8106f99092d6c4a7aadb45a
Comment 9 Florian Mickler 2011-06-21 12:12:40 UTC
Thx for following up on this.

(If you post a sha1, it's nicer for humans if you also include the subject line.) 


Fixed by the following commit merged into v3.0-rc4:

commit f8b7fc6b514f34a51875dd48dff70d4d17a54f38
Author: Paul E. McKenney <paul.mckenney@linaro.org>
Date:   Thu Jun 16 08:26:32 2011 -0700

    rcu: Move RCU_BOOST #ifdefs to header file

Note You need to log in before you can comment on or make changes to this bug.