Bug 36902 - Kernel compilation fails at module apm.ko
Summary: Kernel compilation fails at module apm.ko
Status: CLOSED CODE_FIX
Alias: None
Product: Power Management
Classification: Unclassified
Component: APM (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Stephen Rothwell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-07 15:34 UTC by David Hill
Modified: 2011-06-14 21:23 UTC (History)
3 users (show)

See Also:
Kernel Version: 3.0.0-rc1,rc2
Subsystem:
Regression: Yes
Bisected commit-id:


Attachments
Kernel .config file (137.25 KB, text/plain)
2011-06-07 15:36 UTC, David Hill
Details
Dynamic select of APM_CPU_IDLE feature for enabling APM. (398 bytes, patch)
2011-06-13 13:05 UTC, Vitaliy Ivanov
Details | Diff

Description David Hill 2011-06-07 15:34:38 UTC
Kernel compilation fails at module apm.ko with the following message:

ERROR: "pm_idle" [arch/x86/kernel/apm.ko] undefined!
ERROR: "default_idle" [arch/x86/kernel/apm.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Comment 1 David Hill 2011-06-07 15:36:33 UTC
Created attachment 61092 [details]
Kernel .config file
Comment 2 Vitaliy Ivanov 2011-06-10 16:10:14 UTC
David,

With the config that you attached it should not be reproducible.

When APM is build then we need "pm_idle" and "default_idle" to be available.
They are currently under APM_CPU_IDLE option. So, making is available in your config automatically solves the problem.

I'm sending patch to dynamic select APM_CPU_IDLE on APM selection.

Can you please double check it?
Comment 3 Vitaliy Ivanov 2011-06-13 13:05:54 UTC
Created attachment 61822 [details]
Dynamic select of APM_CPU_IDLE feature for enabling APM.

I saw email about removing APM completely but as of now we can add the following to close build issue.
---
Dynamic select of APM_CPU_IDLE feature for enabling APM.

Signed-off-by: Vitaliy Ivanov <vitalivanov@gmail.com>

>From f00634bec035f1526266340bf75aa4e2620c8284 Mon Sep 17 00:00:00 2001
From: Vitaliy Ivanov <vitalivanov@gmail.com>
Date: Fri, 10 Jun 2011 19:06:37 +0300
Subject: [PATCH] Dynamic select of APM_CPU_IDLE on APM enabling.
Comment 4 Randy Dunlap 2011-06-14 21:22:49 UTC
Fixed by git commit 60b8b1de0dd2bf246f0e074d287bb3f0bc42a755.

Note You need to log in before you can comment on or make changes to this bug.