Bug 25302 - Battery removal crashes Sony Vaio
Summary: Battery removal crashes Sony Vaio
Status: CLOSED CODE_FIX
Alias: None
Product: ACPI
Classification: Unclassified
Component: Power-Battery (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: acpi_power-battery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-20 15:29 UTC by Michael Doube
Modified: 2011-01-20 05:52 UTC (History)
4 users (show)

See Also:
Kernel Version: 2.6.37-rc6
Tree: Mainline
Regression: Yes


Attachments
Photograph of black screen of death (446.60 KB, image/jpeg)
2010-12-20 15:29 UTC, Michael Doube
Details

Description Michael Doube 2010-12-20 15:29:24 UTC
Created attachment 41002 [details]
Photograph of black screen of death

Removal of battery while plugged into AC reliably crashes this laptop (Sony Vaio SZ650).  This bug was not present in the last RC (-rc5).
Comment 1 Michael Doube 2010-12-22 10:01:38 UTC
3138b32d5e0998ba3cbd1c74bdc1887d74c5279b is the first bad commit
commit 3138b32d5e0998ba3cbd1c74bdc1887d74c5279b
Author: Zhang Rui <rui.zhang@intel.com>
Date:   Wed Dec 8 10:40:49 2010 +0800

    ACPI battery: update status upon sysfs query
    
    Sometimes the Battery driver doesn't get notifications when it's
    plugged/unplugged. And this results in the incorrect Battery
    status reported by the power supply sysfs I/F.
    
    Update Battery status first when querying from sysfs.
    http://marc.info/?l=linux-acpi&m=128855015826728&w=2
    
    Tested_by: Seblu <seblu@seblu.net>
    Signed-off-by: Zhang Rui <rui.zhang@intel.com>
    Signed-off-by: Len Brown <len.brown@intel.com>

:040000 040000 2b1ce2e308091d46569b806457607f6a0f2de120 3f49caed5e8dbaec51cad9fb2bfb87b33d3e1333 M	drivers
Comment 2 Len Brown 2010-12-25 01:32:09 UTC
I see this crash too, and can confirm reverting this commit
makes it go away.

revert added to acpi-test tree.
Comment 4 Seb Lu 2010-12-29 07:33:19 UTC
Hello,

why just revert the commit and not apply the patch proposed by Borislav Petkov on LKML?

The original patch was to fix an issue with sysfs reporting of a value. You can see details on "Bad AC adaptateur value trought sysfs" in linux-acpi mailing list.
Comment 5 Len Brown 2011-01-20 05:52:42 UTC
re: comment #4

In the release cycle, -rc7 is not a time to try new fixes,
it is a time to revert patches that caused regressions.

The new attempt at a correct fix can be applied in the
merge window of the subsequent release.

Note You need to log in before you can comment on or make changes to this bug.