Created attachment 307125 [details] Dump file As per instructions here: https://bugzilla.kernel.org/show_bug.cgi?id=219447#c23 ... I am opening a new bug report with the dump file attached. Also, here's the dmesg log if you need it: https://pastebin.com/ZeQYQJFQ I hope it's useful. Kind regards
Created attachment 307126 [details] prints Please reproduce with the patch attached. This will add more prints. Thanks!
Sorry, I've never done this, so could please you provide a guide how to go about it?
NP git clone https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git then you apply my patch patch -p1 < prints.patch Then you compile and install the out of tree driver: make -j8 && sudo make install Then you reboot and reproduce the scenario. Note that this driver will be slightly newer than the one you have in 6.11. Thanks for your cooperation!
CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/nl80211.o CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/ethtool.o CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/mesh.o CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/ap.o CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/trace.o CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/ocb.o CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/pmsr.o CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/debugfs.o GEN /home/stars/Git/backport-iwlwifi/net/wireless/shipped-certs.c GEN /home/stars/Git/backport-iwlwifi/net/wireless/extra-certs.c CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/shipped-certs.o CC [M] /home/stars/Git/backport-iwlwifi/net/wireless/extra-certs.o /home/stars/Git/backport-iwlwifi/net/wireless/nl80211.c: In function ‘nl80211_common_reg_change_event’: /home/stars/Git/backport-iwlwifi/net/wireless/nl80211.c:18053:9: error: too many arguments to function ‘genlmsg_multicast_allns’ 18053 | genlmsg_multicast_allns(&nl80211_fam, msg, 0, | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from /home/stars/Git/backport-iwlwifi/backport-include/net/genetlink.h:3, from /home/stars/Git/backport-iwlwifi/net/wireless/nl80211.c:25: ./include/net/genetlink.h:537:5: note: declared here 537 | int genlmsg_multicast_allns(const struct genl_family *family, | ^~~~~~~~~~~~~~~~~~~~~~~ /home/stars/Git/backport-iwlwifi/net/wireless/nl80211.c: In function ‘nl80211_send_beacon_hint_event’: /home/stars/Git/backport-iwlwifi/net/wireless/nl80211.c:18789:9: error: too many arguments to function ‘genlmsg_multicast_allns’ 18789 | genlmsg_multicast_allns(&nl80211_fam, msg, 0, | ^~~~~~~~~~~~~~~~~~~~~~~ ./include/net/genetlink.h:537:5: note: declared here 537 | int genlmsg_multicast_allns(const struct genl_family *family, | ^~~~~~~~~~~~~~~~~~~~~~~ make[6]: *** [scripts/Makefile.build:244: /home/stars/Git/backport-iwlwifi/net/wireless/nl80211.o] Error 1 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [scripts/Makefile.build:485: /home/stars/Git/backport-iwlwifi/net/wireless] Error 2 make[4]: *** [Makefile:1926: /home/stars/Git/backport-iwlwifi] Error 2 make[3]: *** [Makefile.build:13: modules] Error 2 make[2]: *** [Makefile.real:101: modules] Error 2 make[1]: *** [Makefile:43: modules] Error 2 make: *** [Makefile:30: default] Error 2 This is the result upon compiling the module, is this an error on my part?
What is the version of your kernel?
Created attachment 307134 [details] backported module dmesg
(In reply to Emmanuel Grumbach from comment #5) > What is the version of your kernel? Thanks for pointing that out... Anyway I attached the dmesg out for iwlwifi, although now when I wake from suspend wireless reconnects and there is no "Not associated and the session protection is over already" messages anymore.
Created attachment 307135 [details] fix for ASSER 87 upon resume Can you please apply this patch on top of the backport tree and let me know how it works?
(In reply to Emmanuel Grumbach from comment #8) > Created attachment 307135 [details] > fix for ASSER 87 upon resume > > Can you please apply this patch on top of the backport tree and let me know > how it works? patch -p1 < 0001-BUGFIX-wifi-iwlwifi-mvm-don-t-dump-the-firmware-stat.patch patching file drivers/net/wireless/intel/iwlwifi/mvm/d3.c Hunk #1 FAILED at 3044. Hunk #2 succeeded at 3141 with fuzz 1 (offset 69 lines). Hunk #3 succeeded at 3512 (offset 75 lines). Hunk #4 FAILED at 3460. Hunk #5 succeeded at 3699 (offset 74 lines). Hunk #6 FAILED at 3635. 3 out of 6 hunks FAILED -- saving rejects to file drivers/net/wireless/intel/iwlwifi/mvm/d3.c.rej Patch failed to apply, unless I'm doing something wrong.
Created attachment 307138 [details] dmesg with patch applied
Created attachment 307139 [details] Manually entered patch As the patch failed to apply I ended up patching it manually, this is the patch that I was able to come up with. Not sure what happened but as far as I know it worked. Please review the dmesg and let me know if this is satisfactory.
I am a bit confused... I can compile the master branch of the backport tree on kernel v6.11.5. Then I sent to you a patch based on that backport tree. Please clarify what code base you're working with. I can't see the stack traces in your log from comment#10 because you filtered only the iwlwifi lines.
(In reply to Emmanuel Grumbach from comment #12) > I am a bit confused... > > I can compile the master branch of the backport tree on kernel v6.11.5. > Then I sent to you a patch based on that backport tree. > Please clarify what code base you're working with. > > I can't see the stack traces in your log from comment#10 because you > filtered only the iwlwifi lines. I compiled and applied the patch based on instructions from comment#3 My kernel is 6.11.5. Anyway regardless I will attach the full dmesg.
Created attachment 307143 [details] full dmesg out
Ok, logs look sane. Bug fixed it seems?
(In reply to Emmanuel Grumbach from comment #15) > Ok, logs look sane. > Bug fixed it seems? Yes the bug looks fixed! Not too sure how this stuff works. Will you commit the patches and they will be applied in the next kernel release? Thank you by the way!
The fix is under review, once it'll be merged, it'll make its way to the kernel. Thank you for your cooperation!
I apologize that I was unable to work with you on this in the recent days. I was swamped with urgent work tasks and could not afford the time needed for this. In the mean time, Fedora upgraded the kernel to 6.11.6, but the issue persists. Also I see you managed to sort it out with Stars' assistance. I presume the fix will make it to the next bugfix release. Should you need anything from me, please let me know and I'll do my best.
@Omer, we should be good. I can't tell exactly when the fix will be released.
Ok, until then the UEFI setting can hold :)
@Emmanuel, I upgraded to kernel 6.11.7 and the problem is fixed. Thank you!
That's strange... No fix was merged between 6.11.6 and 6.11.7
I just rechecked everything. Power setting in UEFI is set to Linux S3, kernel is 6.11.7, WiFi is connected after waking up the system from sleep 🤷
(In reply to Emmanuel Grumbach from comment #22) > That's strange... > No fix was merged between 6.11.6 and 6.11.7 I upgraded to the latest kernel and wifi will reconnect now like Omer described although I am getting the same dmesg logs as before. So for whatever reason the network will come back up but will still dump the firmware. Now it's saying something about dumping registers as well. This is kernel 6.11.8