Bug 218521 - Suspend abort due to uevent broadcast during cooling device KOBJECT_REMOVE
Summary: Suspend abort due to uevent broadcast during cooling device KOBJECT_REMOVE
Status: ASSIGNED
Alias: None
Product: Power Management
Classification: Unclassified
Component: Hibernation/Suspend (show other bugs)
Hardware: All Linux
: P3 high
Assignee: Daniel Lezcano
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-22 11:43 UTC by Daniel Lezcano
Modified: 2024-02-29 08:58 UTC (History)
1 user (show)

See Also:
Kernel Version:
Subsystem:
Regression: Yes
Bisected commit-id: 5c238a8b599f1ae25eaeb08ad0e9e13e2b9eb023


Attachments
Callstack (820 bytes, text/plain)
2024-02-22 11:45 UTC, Daniel Lezcano
Details
wakeup source fix for the thermal cooling device (562 bytes, patch)
2024-02-22 11:58 UTC, Daniel Lezcano
Details | Diff

Description Daniel Lezcano 2024-02-22 11:43:29 UTC
During S2R,  secondary cores are hotplugged and as part of this, cpufreq offline callback is unregistering cpufreq cooling device which in turn removing kobject using device_del() and notifying userspace via uevent broadcast. This causes suspend abort for S2R use cases.

Callstack is provided in attachment. Issue is there quite some time after this cpufreq patch [1] and it can happen to any chipset.

I see someone already posted RFC patch to address this issue in [2] sometimes back.

[1]. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5c238a8b599f1ae25eaeb08ad0e9e13e2b9eb023

[2]. https://patchwork.kernel.org/project/linux-pm/patch/20220710164026.541466-1-r.stratiienko@gmail.com/
Comment 1 Daniel Lezcano 2024-02-22 11:45:39 UTC
Created attachment 305904 [details]
Callstack
Comment 2 Daniel Lezcano 2024-02-22 11:48:36 UTC
Seems like this issues is reported in other mailing lists:

https://issuetracker.google.com/issues/194314791
Comment 3 Daniel Lezcano 2024-02-22 11:58:15 UTC
Created attachment 305905 [details]
wakeup source fix for the thermal cooling device

A proposal to fix the issue. Not tested because I was not able to reproduce the issue on my platform yet.
Comment 4 Daniel Lezcano 2024-02-29 08:58:46 UTC
(In reply to Daniel Lezcano from comment #3)
> Created attachment 305905 [details]
> wakeup source fix for the thermal cooling device
> 
> A proposal to fix the issue. Not tested because I was not able to reproduce
> the issue on my platform yet.

Apparently this fix does not work.

Note You need to log in before you can comment on or make changes to this bug.