Bug 218169 - [Framework Laptop] High power consumption when i2c hid touchpad is in use
Summary: [Framework Laptop] High power consumption when i2c hid touchpad is in use
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: I2C (show other bugs)
Hardware: Intel Linux
: P3 normal
Assignee: Jarkko Nikula
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-20 21:26 UTC by Kieran Levin
Modified: 2024-02-19 09:44 UTC (History)
5 users (show)

See Also:
Kernel Version:
Subsystem:
Regression: No
Bisected commit-id:


Attachments
Script for testing core pinning. Values reflect i7-13800h on thinkpad p1 gen 6. (1.65 KB, application/x-shellscript)
2024-02-10 22:11 UTC, José Relvas
Details
Test results for trackpad-test.sh. (1.88 KB, application/x-xz)
2024-02-10 22:13 UTC, José Relvas
Details
Test results for trackpad-test.sh. EPB set to balanced (via power-profiles-daemon) (2.14 KB, application/x-xz)
2024-02-19 09:35 UTC, José Relvas
Details
Test results for trackpad-test.sh. EPB set to powersave (via power-profiles-daemon) (1.96 KB, application/x-xz)
2024-02-19 09:36 UTC, José Relvas
Details

Description Kieran Levin 2023-11-20 21:26:57 UTC
On our 11th to 13th gen Framework Laptops, we see high power usage when the i2c-hid connected touchpad is in use. We suspect this bug also will impact other Intel systems using these type of touchpads.

We would like to see if the kernel could group interrupts that service touchpads so that both the ACPI GPIO interrupt and designware i2c interrupt are bound to the same core to avoid waking two separate cores whenever the touchpad is in use to reduce power consumption. Or kernel maintainers may have a better idea to improve this.

Background: 
We have found that when the touchpad is in use, the touchpad interaction with the CPU will follow the following sequence: 1. the touchpad will generate a GPIO interrupt to the CPU. The CPU will then perform a series of i2c reads using the i2c controller in master mode to retrieve an in report from the touchpad.

The touchpad will generate GPIO interrupts at a rate of around 140 interrupts/second.
The intel designware-i2c driver will generate interrupts at a rate of around 1000 interrupts / second.

Intel premier support agents asked us to open a bug here to track this issue.

Reproduction steps: 
1. Boot to a gui environment and let the system idle, such as fedora desktop with no applications running.
2. Run a program like s-tui as root to measure the CPU / Psys power consumption. 
Observe the power consumption of the system for several seconds without touching the touchpad.
3. Touch the touchpad and move your finger around, note the system package power consumption will increase by about 2W. We measured the touchpad, and the touchpad will not cause a measurable increase in system power consumption. Additionally the s-tui results show the additional power consumption is coming from the CPU.

I looked at this using Fedora, and it seems the gpio interrupt is pinned to one core, and the i2c interrupts are pinned to a separate core. This means every time the touchpad fires an interrupt, both a high performance and efficiency core cluster have to wake up to service the touchpad. And these are probably not even in the same cluster, so lots of cache evictions etc might be happening as both core clusters power on and off and caches are cleared and filled.

What core type are TP interrupts handled by?

The second thing was to find out what cores the interrupts were handled by:

cat /proc/interrupts

watch -n 1 "cat /proc/interrupts | grep designware"  
watch -n 1 "cat /proc/interrupts | grep PIXA"

            CPU0       CPU1       CPU2       CPU3       CPU4       CPU5       CPU6       CPU7       CPU8       CPU9       CPU10      CPU11      CPU12      CPU13      CPU14      CPU15      CPU16      CPU17      CPU18      CPU19      
  43:          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0   43694516          0          0          0          0  IR-IO-APIC   43-fasteoi   i2c_designware.2, idma64.2
 135:          0          0    1711105          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0          0  intel-gpio    3  PIXA3854:00

And move the touchpad, you will see which core the touchpad interrupts are increasing on both.
However the PIXA ACPI GPIO interrupt is pinned to a high performance core, but the i2c-designware interrupt is pinned to an efficiency core.

Lets pin them both to the same core CPU2:

# echo 00004 > /proc/irq/43/smp_affinity
# echo 00004 > /proc/irq/135/smp_affinity # DOESNT WORK, IO error?

Power consumption when using the touchpad seems to drop from about 7W to 5W! (Baseline is 4W)


Background is here: https://community.frame.work/t/tracking-touchpad-interrupts-battery-usage-issues-idma64-2/13630/35
Comment 1 Andy Shevchenko 2023-11-22 10:53:50 UTC
As a first step your suggestion sounds good to me, but I think the common denominator here is I2C-HID module that might have the information about both: the actual I2C controller and GPIO interrupt. Hence I'm wondering if this cand be somehow managed there. Benjamin?
Comment 2 Andy Shevchenko 2023-11-22 11:02:44 UTC
+ Hans for harvesting the ideas.

Hans, I believe you have a lot of experience with user space managing tools / UIs and may bring a good point into this bug report. I'm now wondering if actually userspace can do what reporter suggested? Because in the kernel it might be not so easy to solve, while user space can do it with ease.
Comment 3 Hans de Goede 2023-11-22 11:22:59 UTC
First of all thank you Kieran for filing this interesting bug-report, there indeed seems to be a significant opportunity here to safe a nice amount of power when the touchpad is in use.

I agree with Andy's take on this that this sounds like something which is best fixed inside the kernel, specifically inside i2c-hid core.

I think this will need at-least a few kernel patches / some extra kernel infra.

1. A patch adding:
1.1 an irq field to struct i2c_adapter, with 0 meaning IRQ unknown!
1.2 an "int i2c_get_adapter_irq(struct i2c_client);" helper (can probably
    be a static line, the client here just being a convenient way to
    get the adapter)

2. A patch setting adapter->irq for i2c_designware controllers

3. A patch for i2c-hid-core to see if there is a non-0 adapter-irq configured and if yes then set IRQ affinity for both the i2c-hid IRQ and the adapter IRQ to the same core. It is unclear to me how to pick a core for this though. Maybe just read the GPIO IRQ affinity and then apply the same affinity to the i2c-adapter IRQ ?

Note I do not have any time / bandwidth to work on this myself, so hopefully the above raw sketch is helpful for someone else to implement something like this.
Comment 4 José Relvas 2024-01-08 17:22:08 UTC
Hey folks. 

I'm on a Thinkpad P1 gen 6, which also uses the i2c_designware controller, and I can confirm that this issue impacts it.

My baseline is 1w (idling DE)

For comparison... 
- ...moving the trackpoint around only increases it by around 2 watts. (3w)
- ...playing back a FLAC audio via the pulseaudio api only increases it by around a single watt. (2w)
Comment 5 José Relvas 2024-01-08 17:23:44 UTC
^ Forgot to say that trackpad usage increases power consumption by around 4 watts. (5w)

This means that trackpad usage makes the CPU draw twice as much power compared to trackpoint usage.
Comment 6 Mika Westerberg 2024-01-23 11:52:08 UTC
I wonder if this is still better to do in userspace? I mean the kernel can guess  the CPU but it might be sub-optimal for the user. Say it is put to the "little" core instead of the "big" core or so.

I think one place where this could belong is in systemd hwdb in the same way there are those autosuspend things. If there is a known "optimal" configuration for a given combination it could have its own rule there. Or something like that.
Comment 7 José Relvas 2024-02-10 22:11:46 UTC
Created attachment 305853 [details]
Script for testing core pinning. Values reflect i7-13800h on thinkpad p1 gen 6.

Values depend on the trackpad vendor, platform/machine and CPU topology. Make sure to change them if you're running this.

Also included: trackpad-pinning-report.tar.xz, with sample results.
Comment 8 José Relvas 2024-02-10 22:13:23 UTC
Created attachment 305854 [details]
Test results for trackpad-test.sh.

CPU: Intel Core i7-13800h
Trackpad vendor: ELAN
Machine: Thinkpad P1 Gen 6
Comment 9 José Relvas 2024-02-10 22:35:17 UTC
I made a quick and dirty script to test some different pinning configurations.

I ran it under the following conditions:
• All radios (wifi, bluetooth, etc.) disabled.
• Logged in TTY, no graphical session.
• Display manager turned off. (systemctl stop gdm)
• Platform profile set to powersave.
• TTY blinking cursor disabled.  (/sys/class/graphics/fbcon/cursor_blink set to 0)
• Running on battery.
• powertop tunings applied.

This doesn't remove every independent factor, but should make the measurements somewhat more accurate.

Here's what I observed:
• Every single combination tested managed to consume less power vs the default one (where an e-core and a p-core were both in use).
  • Doing literally anything other than the current default provides better results.
  • Over 0.3W can be saved, even without userspace moving a cursor around.
• Measurements where only e-cores were used show slightly lower power draw compared to measurements with only p-cores (50 mW).
  • No noticeable differences with input latency, at least from my subjective observation.
• Couldn't determine what's the best way of pinning to e-cores. I measured slightly better results with pinning to two e-cores in different clusters, but this might be caused by the difference in number of interrupts. More testing needed.
Comment 10 José Relvas 2024-02-19 09:35:20 UTC
Created attachment 305897 [details]
Test results for trackpad-test.sh. EPB set to balanced (via power-profiles-daemon)

CPU: Intel Core i7-13800h
Trackpad vendor: ELAN
Machine: Thinkpad P1 Gen 6
Comment 11 José Relvas 2024-02-19 09:36:31 UTC
Created attachment 305898 [details]
Test results for trackpad-test.sh. EPB set to powersave (via power-profiles-daemon)

CPU: Intel Core i7-13800h
Trackpad vendor: ELAN
Machine: Thinkpad P1 Gen 6
Comment 12 José Relvas 2024-02-19 09:44:26 UTC
I made a major breakthrough!

There was a limitation with [power-profiles-daemon](https://gitlab.freedesktop.org/upower/power-profiles-daemon) which prevented it from setting the energy-performance bias if there were platform profiles available. This was fixed with [MR #127](https://gitlab.freedesktop.org/upower/power-profiles-daemon/-/merge_requests/127).

I was unaware of this until now. I've retested with the new 0.20 release which applies this fix, and the results are *very* apparent.

The energy consumption decreases by over two watts with p-cores, going under 2W when the two IRQs are assigned to different P threads. On the other hand, the e-cores only experience a slight power reduction, still being comfortably within the 4W range.

This shows that it's actually preferable to pin to P cores instead of E cores. I suspect this is the case because the P cores manage to finish processing the interrupts sooner, which lets them idle deeper, resulting in the whole package idling for longer and therefore reducing power consumption.

Note You need to log in before you can comment on or make changes to this bug.