dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr). Currently the man page says: These program headers are structures of the following form: typedef { ... } Elf32_Phdr; which is obviously wrong for 64-bit binaries.
(In reply to Paul Pluzhnikov from comment #0) > dl_iterate_phdr should mention Elf64_Phdr (in addition to Elf32_Phdr). > Currently the man page says: > > These program headers are structures of the following form: > typedef { ... } Elf32_Phdr; > > which is obviously wrong for 64-bit binaries. Hello Paul, Do you think the following would be helpful. Replacing "These program headers are structures of the following form:" with the following The ELF program header is described by the type Elf32_Phdr or Elf64_Phdr depending on the architecture. Following is an example of 32 bit architecture. Refer to elf (man elf) for more information on 64 bit architecture.
(In reply to Rajesh from comment #1) > Do you think the following would be helpful. Sure. > Replacing "These program headers are structures of the following form:" with > the following > > The ELF program header is described by the type Elf32_Phdr or Elf64_Phdr > depending on the architecture. Following is an example of 32 bit > architecture. Refer to elf (man elf) for more information on 64 bit > architecture. I suggest deleting the last 4 words, i.e. Refer to elf (man elf) for more information. since "man elf" describes both Elf{32,64}_Phdr in a bit more detail.
Great.I have submitted the patch. If they approve it will be merged. Cheers Paul.
On Wed, Dec 27, 2023 at 04:47:48PM +0000, bugzilla-daemon@kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=218018 > > --- Comment #2 from Paul Pluzhnikov (ppluzhnikov@google.com) --- > (In reply to Rajesh from comment #1) > > > Do you think the following would be helpful. > > Sure. > > > Replacing "These program headers are structures of the following form:" > with > > the following > > > > The ELF program header is described by the type Elf32_Phdr or Elf64_Phdr > > depending on the architecture. Following is an example of 32 bit > > architecture. Refer to elf (man elf) for more information on 64 bit > > architecture. > > I suggest deleting the last 4 words, i.e. > > Refer to elf (man elf) for more information. > > since "man elf" describes both Elf{32,64}_Phdr in a bit more detail. I suggest creating link pages Elf32_Phdr(3type) and Elf64_Phdr(3type) both of which link to elf(5). > > -- > You may reply to this email to add a comment. > > You are receiving this mail because: > You are watching the assignee of the bug.