(In reply to sardonimous from comment #0)
> After upgrading to linux 6.3.8-arch1-1 from 6.3.6-arch1-1, b43 broadcom
> wireless driver fails.  downgrading back to 6.3.6-arch1-1 resolves.
> 
> Jun 16 20:56:37 askasleikir kernel: Hardware name: Apple Inc.
> MacBookPro7,1/Mac-F222BEC8, BIOS MBP71.88Z.0039.B15.1702241313 02/24/17
> Jun 16 20:56:37 askasleikir kernel: Workqueue: phy0 b43_tx_work [b43]
> Jun 16 20:56:37 askasleikir kernel: RIP:
> 0010:__ieee80211_stop_queue+0xcc/0xe0 [mac80211]
> Jun 16 20:56:37 askasleikir kernel: Code: 74 11 48 8b 78 08 0f b7 d6 89 e9
> 4c 89 e6 e8 5b eb 00 00 65 ff 0d 0c dd b5 3e 0f 85 55 ff ff ff e8 b9 f4 12
> de e9 4b ff>
> Jun 16 20:56:37 askasleikir kernel: RSP: 0000:ffffc36b0013bdb8 EFLAGS:
> 00010097
> Jun 16 20:56:37 askasleikir kernel: RAX: 0000000000000001 RBX:
> 0000000000000002 RCX: 0000000000000000
> Jun 16 20:56:37 askasleikir kernel: RDX: 0000000000000000 RSI:
> 0000000000000002 RDI: ffff9f85d1c108e0
> Jun 16 20:56:37 askasleikir kernel: RBP: 0000000000000000 R08:
> 0000000000000000 R09: ffff9f85c0819674
> Jun 16 20:56:37 askasleikir kernel: R10: 0000000000000005 R11:
> 0000000000000181 R12: ffff9f85d1c108e0
> Jun 16 20:56:37 askasleikir kernel: R13: 0000000000000000 R14:
> ffff9f85d1c12238 R15: ffff9f85d1c12090
> Jun 16 20:56:37 askasleikir kernel: FS: 0000000000000000(0000)
> GS:ffff9f85fbe00000(0000) knlGS:0000000000000000
> Jun 16 20:56:37 askasleikir kernel: CS: 0010 DS: 0000 ES: 0000 CR0:
> 0000000080050033
> Jun 16 20:56:37 askasleikir kernel: CR2: 000055b33bbd5d70 CR3:
> 0000000022620000 CR4: 00000000000406f0
> Jun 16 20:56:37 askasleikir kernel: Call Trace:
> Jun 16 20:56:37 askasleikir kernel: <TASK>
> Jun 16 20:56:37 askasleikir kernel: ? __ieee80211_stop_queue+0xcc/0xe0
> [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
> Jun 16 20:56:37 askasleikir kernel: ? __warn+0x81/0x130
> Jun 16 20:56:37 askasleikir kernel: ? __ieee80211_stop_queue+0xcc/0xe0
> [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
> Jun 16 20:56:37 askasleikir kernel: ? report_bug+0x171/0x1a0
> Jun 16 20:56:37 askasleikir kernel: ? handle_bug+0x3c/0x80
> Jun 16 20:56:37 askasleikir kernel: ? exc_invalid_op+0x17/0x70
> Jun 16 20:56:37 askasleikir kernel: ? asm_exc_invalid_op+0x1a/0x20
> Jun 16 20:56:37 askasleikir kernel: ? __ieee80211_stop_queue+0xcc/0xe0
> [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
> Jun 16 20:56:37 askasleikir kernel: ieee80211_stop_queue+0x36/0x50 [mac80211
> 136d1d948548ad6cca697df0da0a13c0a2333310]
> Jun 16 20:56:37 askasleikir kernel: b43_pio_tx+0x373/0x390 [b43
> 0f6039cbd530df6f28ebbb52898f2f67b84598dd]
> Jun 16 20:56:37 askasleikir kernel: ? __schedule+0x44b/0x1400
> Jun 16 20:56:37 askasleikir kernel: b43_tx_work+0x57/0x130 [b43
> 0f6039cbd530df6f28ebbb52898f2f67b84598dd]
> Jun 16 20:56:37 askasleikir kernel: process_one_work+0x1c7/0x3d0
> Jun 16 20:56:37 askasleikir kernel: worker_thread+0x51/0x390
> Jun 16 20:56:37 askasleikir kernel: ? __pfx_worker_thread+0x10/0x10
> Jun 16 20:56:37 askasleikir kernel: kthread+0xde/0x110
> Jun 16 20:56:37 askasleikir kernel: ? __pfx_kthread+0x10/0x10
> Jun 16 20:56:37 askasleikir kernel: ret_from_fork+0x2c/0x50
> Jun 16 20:56:37 askasleikir kernel: </TASK>
> Jun 16 20:56:37 askasleikir kernel: ---[ end trace 0000000000000000 ]---
> 
> I suspect change introduced when addressing a compiler warning cased the
> error.
> 
> https://patchwork.kernel.org/project/linux-wireless/patch/20230516183442.
> 536589-1-arnd%40kernel.org/
> 
> The is arch linux and they referred me here.

Can you perform bisection to confirm that the change you mentioned above introduces your regression?

Apologies.  I found that the errors had been happening for a long while.  At some point the wlan device stopped coming active which is when I noticed.  I ended up downgrading to 6.1.12 to avoid the errors which were also causing significant performance problems.  I believe 6.1.12 is the highest 6.1 release from archlinux.

I don't have the skills to do bisection.

Note that on the MacBookPro7,1, the BCM4322 only operates in PIO mode, not DMA mode, as far as I can determine.

(In reply to sardonimous from comment #2)
> Apologies.  I found that the errors had been happening for a long while.  At
> some point the wlan device stopped coming active which is when I noticed.  I
> ended up downgrading to 6.1.12 to avoid the errors which were also causing
> significant performance problems.  I believe 6.1.12 is the highest 6.1
> release from archlinux.
> 
> I don't have the skills to do bisection.
> 

Then see Documentation/admin-guide/bug-bisect.rst for how to bisect. And
because you need to compile your own kernel during bisection, see also
Documentation/admin-guide/quickly-build-trimmed-linux.rst for building instructions.

Hi sardonimous,

From mailing list [1]:

On Sat, 24 Jun 2023 08:44:15 +0700
Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> > I suspect change introduced when addressing a compiler warning
> > cased the error.
> > 
> >
> https://patchwork.kernel.org/project/linux-wireless/patch/20230516183442.536589-1-arnd%40kernel.org/


I doubt it.
This patch affects the device initialization code. But the crash is in
the transmit path.
Can you please double check by manually reverting the patch?

[1]: https://lore.kernel.org/regressions/20230624105023.146d99e0@barney/

I agree.  My hypothesis was premature. As it turned out, the error had been happening since before 6.3.7.  I downgraded to 6.1.12-arch1-1 to avoid the error. It seems the error was introduced sometime after 6.1.12 and I saw it in 6.2.8.arch1-1.

On 6/24/23 19:25, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=217582
> 
> --- Comment #5 from sardonimous@hotmail.com ---
> I agree.  My hypothesis was premature. As it turned out, the error had been
> happening since before 6.3.7.  I downgraded to 6.1.12-arch1-1 to avoid the
> error. It seems the error was introduced sometime after 6.1.12 and I saw it
> in
> 6.2.8.arch1-1.
> 

Can you then perform bisection between v6.1 and v6.2 instead?

Because I left off a few lines at the top, here is another one (while I work on the bisect.)

Jun 20 18:20:11 askasleikir kernel: ------------[ cut here ]------------
Jun 20 18:20:11 askasleikir kernel: WARNING: CPU: 1 PID: 33 at net/mac80211/util.c:514 __ieee80211_stop_queue+0xcc/0xe0 [mac80211]
Jun 20 18:20:11 askasleikir kernel: Modules linked in: ccm tun qrtr rpcrdma rdma_cm iw_cm ib_cm ib_core nls_utf8 cifs cifs_arc4 cifs_md4 dns_resolver fscache net>
Jun 20 18:20:11 askasleikir kernel:  lockd grace crypto_user sunrpc fuse dm_mod loop bpf_preload ip_tables x_tables ext4 crc32c_generic crc16 mbcache jbd2 sr_mod>
Jun 20 18:20:11 askasleikir kernel: CPU: 1 PID: 33 Comm: kworker/u4:2 Tainted: G        W          6.3.6-arch1-1 #1 a07497485287c74e7a472f42ded4b2ddcf7a6fd7
Jun 20 18:20:11 askasleikir kernel: Hardware name: Apple Inc. MacBookPro7,1/Mac-F222BEC8, BIOS    MBP71.88Z.0039.B15.1702241313 02/24/17
Jun 20 18:20:11 askasleikir kernel: Workqueue: phy0 b43_tx_work [b43]
Jun 20 18:20:11 askasleikir kernel: RIP: 0010:__ieee80211_stop_queue+0xcc/0xe0 [mac80211]
Jun 20 18:20:11 askasleikir kernel: Code: 74 11 48 8b 78 08 0f b7 d6 89 e9 4c 89 e6 e8 fb ea 00 00 65 ff 0d 2c 2d ac 3e 0f 85 55 ff ff ff e8 d9 44 69 c3 e9 4b ff>
Jun 20 18:20:11 askasleikir kernel: RSP: 0018:ffffb3538013bdb8 EFLAGS: 00010097
Jun 20 18:20:11 askasleikir kernel: RAX: 0000000000000001 RBX: 0000000000000002 RCX: 0000000000000000
Jun 20 18:20:11 askasleikir kernel: RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffff9e55cfa248e0
Jun 20 18:20:11 askasleikir kernel: RBP: 0000000000000000 R08: 0000000000000000 R09: 000000008010000f
Jun 20 18:20:11 askasleikir kernel: R10: 0000000000000005 R11: 0000000000000181 R12: ffff9e55cfa248e0
Jun 20 18:20:11 askasleikir kernel: R13: 0000000000000000 R14: ffff9e55cfa26238 R15: ffff9e55cfa26090
Jun 20 18:20:11 askasleikir kernel: FS:  0000000000000000(0000) GS:ffff9e55fbf00000(0000) knlGS:0000000000000000
Jun 20 18:20:11 askasleikir kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
Jun 20 18:20:11 askasleikir kernel: CR2: 00007f37cce5d180 CR3: 0000000057620000 CR4: 00000000000406e0
Jun 20 18:20:11 askasleikir kernel: Call Trace:
Jun 20 18:20:11 askasleikir kernel:  <TASK>
Jun 20 18:20:11 askasleikir kernel:  ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211 01be121fb223b347160617528f5dda900e828bc2]
Jun 20 18:20:11 askasleikir kernel:  ? __warn+0x81/0x130
Jun 20 18:20:11 askasleikir kernel:  ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211 01be121fb223b347160617528f5dda900e828bc2]
Jun 20 18:20:11 askasleikir kernel:  ? report_bug+0x171/0x1a0
Jun 20 18:20:11 askasleikir kernel:  ? handle_bug+0x3c/0x80
Jun 20 18:20:11 askasleikir kernel:  ? exc_invalid_op+0x17/0x70
Jun 20 18:20:11 askasleikir kernel:  ? asm_exc_invalid_op+0x1a/0x20
Jun 20 18:20:11 askasleikir kernel:  ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211 01be121fb223b347160617528f5dda900e828bc2]
Jun 20 18:20:11 askasleikir kernel:  ? __slab_free+0xe0/0x310
Jun 20 18:20:11 askasleikir kernel:  ieee80211_stop_queue+0x36/0x50 [mac80211 01be121fb223b347160617528f5dda900e828bc2]
Jun 20 18:20:11 askasleikir kernel:  b43_pio_tx+0x373/0x390 [b43 3dc9b3f0fd98e2a659c64e057bd3b22d977e5228]
Jun 20 18:20:11 askasleikir kernel:  b43_tx_work+0x57/0x130 [b43 3dc9b3f0fd98e2a659c64e057bd3b22d977e5228]
Jun 20 18:20:11 askasleikir kernel:  process_one_work+0x1c7/0x3d0
Jun 20 18:20:11 askasleikir kernel:  worker_thread+0x51/0x390
Jun 20 18:20:11 askasleikir kernel:  ? __pfx_worker_thread+0x10/0x10
Jun 20 18:20:11 askasleikir kernel:  kthread+0xde/0x110
Jun 20 18:20:11 askasleikir kernel:  ? __pfx_kthread+0x10/0x10
Jun 20 18:20:11 askasleikir kernel:  ret_from_fork+0x2c/0x50
Jun 20 18:20:11 askasleikir kernel:  </TASK>
Jun 20 18:20:11 askasleikir kernel: ---[ end trace 0000000000000000 ]---
Jun 20 18:20:11 askasleikir kernel: ------------[ cut here ]------------