Bug 217384 - Need NVME QUIRK BOGUS for Hiksemi SSD - HS-SSD-FUTURE 2048G
Summary: Need NVME QUIRK BOGUS for Hiksemi SSD - HS-SSD-FUTURE 2048G
Status: NEW
Alias: None
Product: IO/Storage
Classification: Unclassified
Component: NVMe (show other bugs)
Hardware: All Linux
: P3 blocking
Assignee: IO/NVME Virtual Default Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-29 18:51 UTC by Andrey God
Modified: 2023-06-06 17:34 UTC (History)
3 users (show)

See Also:
Kernel Version: 6.1.15-1
Subsystem:
Regression: No
Bisected commit-id:

Attachments
please add it in pci.c (97 bytes, patch)
2023-04-29 18:58 UTC, Andrey God 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description Andrey God 2023-04-29 18:51:37 UTC 
Need NVME QUIRK BOGUS for Hiksemi SSD - HS-SSD-FUTURE 2048G

Here is log from dmesg | grep nvme:


nvme nvme1: pci function 0000:c2:00.0
nvme nvme4: pci function 0000:81:00.0
nvme nvme1: missing or invalid SUBNQN field.
nvme nvme4: missing or invalid SUBNQN field.
nvme nvme4: allocated 32 MiB host memory buffer.
nvme nvme1: allocated 32 MiB host memory buffer.
nvme nvme4: 8/0/0 default/read/poll queues
nvme nvme1: 8/0/0 default/read/poll queues
nvme nvme1: globally duplicate IDs for nsid 1
nvme nvme1: VID:DID 1e4b:1602 model:HS-SSD-FUTURE 2048G firmware:SN11273

To fix it, please add two strings in pci.c

{ PCI_DEVICE(0x1e4b, 0x1602), /* HS-SSD-FUTURE 2048G  */
.driver_data = NVME_QUIRK_BOGUS_NID, },
Comment 1 Andrey God 2023-04-29 18:58:23 UTC 
Created attachment 304197 [details]
please add it in pci.c

NVME QUIRK BOGUS for Hiksemi SSD - HS-SSD-FUTURE 2048G
Comment 2 Sagi Grimberg 2023-05-01 14:05:27 UTC 
Is the request to send a patch for this?
Comment 3 Andrey God 2023-05-01 16:20:57 UTC 
Yes.
Comment 4 Andrey God 2023-05-03 10:04:20 UTC 
Sagi,

Is there any chance to monitor progress or to know on which version of kernel the patch will be implemented?
Comment 5 Sagi Grimberg 2023-05-03 15:59:01 UTC 
Sent a patch upstream. You are CC'd Andrey.
Comment 6 Sagi Grimberg 2023-05-03 15:59:41 UTC 
(In reply to Sagi Grimberg from comment #5)
> Sent a patch upstream. You are CC'd Andrey.

Please confirm that the patch solves your issue.
Comment 7 Andrey God 2023-06-06 16:43:38 UTC 
(In reply to Sagi Grimberg from comment #6)
> (In reply to Sagi Grimberg from comment #5)
> > Sent a patch upstream. You are CC'd Andrey.
> 
> Please confirm that the patch solves your issue.

Is this patch in kernel 6.4 only? Any chance to get it in 6.1 or 6.3 for tests? I use Debian Testing.
Comment 8 Keith Busch 2023-06-06 17:34:41 UTC 
(In reply to Andrey God from comment #7)
> > Please confirm that the patch solves your issue.
> 
> Is this patch in kernel 6.4 only? Any chance to get it in 6.1 or 6.3 for
> tests? I use Debian Testing.

It's in stable queue right now in both 6.1 and 6.3, so should be in their next release whenever that happens. Here's the 6.1:

https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-6.1/nvme-pci-add-nvme_quirk_bogus_nid-for-hs-ssd-future-.patch
Note You need to log in before you can comment on or make changes to this bug.