Bug 215983 - Whitelist Dell G5 5590 (or more broadly the entire G Series family) on dell_smm_hwmon
Summary: Whitelist Dell G5 5590 (or more broadly the entire G Series family) on dell_s...
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Hardware Monitoring (show other bugs)
Hardware: Intel Linux
: P1 enhancement
Assignee: Jean Delvare
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-05-16 11:01 UTC by Mateus Rodrigues Costa
Modified: 2022-06-14 00:59 UTC (History)
1 user (show)

See Also:
Kernel Version: 5.17.6-300.fc36.x86_64
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Mateus Rodrigues Costa 2022-05-16 11:01:37 UTC
So, apparently my current laptop is not white listed on dell_smm_hwmon's `i8k_dmi_table`, but it is needed to at least have info about current fan speeds (my main use case), so I usually make it load on boot with added option `ignore_dmi=1`.

After ignoring dmi, the driver functions perfectly, here are the functionalities I tested:

- checking fan speed (my main use)
- controlling fan speed via i8kmon (the laptop uses bios fan control, so that needs to be disabled first), I don't personally use this feature
- bios version mismatch between /proc/i8k and dmidecode
- service tag (serial number) appears correctly when reading /proc/i8k as root

OS is Fedora Silverblue 36 version 36.20220515.0.

Kernel is:

kernel-5.17.6-300.fc36.x86_64
kernel-core-5.17.6-300.fc36.x86_64
kernel-modules-5.17.6-300.fc36.x86_64
kernel-modules-extra-5.17.6-300.fc36.x86_64

Here are the messages I get on logs due to the driver:

```
mai 15 21:50:18 centauro kernel: dell_smm_hwmon: not running on a supported Dell system.
mai 15 21:50:18 centauro kernel: dell_smm_hwmon: vendor=Dell Inc., model=G5 5590, version=1.19.0
```

Relevant DMI decode strings:

```
[mateusrc@centauro ~]$ sudo dmidecode -s system-manufacturer
Dell Inc.
[mateusrc@centauro ~]$ sudo dmidecode -s system-family
GSeries
[mateusrc@centauro ~]$ sudo dmidecode -s system-product-name
G5 5590
[mateusrc@centauro ~]$ sudo dmidecode -s bios-version
1.19.0
```

Please, add my specific model (or the entire G Series family) to the supported systems.
Comment 1 Armin Wolf 2022-06-12 03:42:14 UTC
Just two questions:
- does the dell_smm_hwmon kernel module load without force=1?
- does loading the dell_smm_hwmon kernel module cause any issues
(suspend, fn keys, audio stutter, lags, etc)?

If you can confidently answer both questions with no, when i will be
happy to write a patch which whitelists your notebook model.

However the entire G-Series will likely only be whitelisted if
more working models are found.

Besides that, if you can disable automatic fan control (i assume
with dell-bios-fan-control) without causing any problems (see the
second question), then i could additionally add your model on the
fan mode control whitelist.
Comment 2 Mateus Rodrigues Costa 2022-06-12 10:12:42 UTC
(In reply to Armin Wolf from comment #1)

> - does the dell_smm_hwmon kernel module load without force=1?

I believe that yes.

I personally only load the dell-smm-hwmon module and use the ignore dmi option and it works fine. Like this:

```
[mateusrc@centauro ~]$ cat /etc/modules-load.d/dell-smm-hwmon.conf 
dell-smm-hwmon
```

```
[mateusrc@centauro ~]$ cat /etc/modprobe.d/dell-smm-hwmon.conf 
options dell-smm-hwmon ignore_dmi=1
```

> - does loading the dell_smm_hwmon kernel module cause any issues
> (suspend, fn keys, audio stutter, lags, etc)?

As far as I noticed, no.
At least nothing that I could pinpoint as exactly the fault of the dell_smm_hwmon modules instead of any other component of my system.
All of those listed seem to work fine.

As a reminder I only care about this module to be able to see the current fan speed, as there is no other way to do it.

> If you can confidently answer both questions with no, when i will be
> happy to write a patch which whitelists your notebook model.

Makes sense, IMHO it could be whitelisted with no problems.

> However the entire G-Series will likely only be whitelisted if
> more working models are found.

Also makes a lot of sense, although I believe there are several places that users post that their Dell (and also Alienware, I think) laptops should be compatible with dell_smm_hwmon (but tutorials for that usually tell to use "force" instead of "ignore_dmi"), just nothing "unified". But I believe nobody tries to report to kernel bugzilla to actually fix it.

> Besides that, if you can disable automatic fan control (i assume
> with dell-bios-fan-control) without causing any problems (see the
> second question), then i could additionally add your model on the
> fan mode control whitelist.

IIRC, dell-bios-fan-control works fine here, I have used it a few times before, but since I never really figured out how to manually control fans, and didn't want to risk misconfiguration damaging the laptop, then I never stuck with that and still use bios automatic fan control.

I can check it at some future point in time though, but at the moment I can't guarantee much.
Comment 3 Armin Wolf 2022-06-12 23:01:39 UTC
(In reply to Mateus Rodrigues Costa from comment #2)
> (In reply to Armin Wolf from comment #1)
> 
> > - does the dell_smm_hwmon kernel module load without force=1?
> 
> I believe that yes.
> 
> I personally only load the dell-smm-hwmon module and use the ignore dmi
> option and it works fine. Like this:
> 
> ```
> [mateusrc@centauro ~]$ cat /etc/modules-load.d/dell-smm-hwmon.conf 
> dell-smm-hwmon
> ```
> 
> ```
> [mateusrc@centauro ~]$ cat /etc/modprobe.d/dell-smm-hwmon.conf 
> options dell-smm-hwmon ignore_dmi=1
> ```
> 
> > - does loading the dell_smm_hwmon kernel module cause any issues
> > (suspend, fn keys, audio stutter, lags, etc)?
> 
> As far as I noticed, no.
> At least nothing that I could pinpoint as exactly the fault of the
> dell_smm_hwmon modules instead of any other component of my system.
> All of those listed seem to work fine.
> 
> As a reminder I only care about this module to be able to see the current
> fan speed, as there is no other way to do it.
> 
> > If you can confidently answer both questions with no, when i will be
> > happy to write a patch which whitelists your notebook model.
> 
> Makes sense, IMHO it could be whitelisted with no problems.
> 

Ok, i will write the patch soon.

> > However the entire G-Series will likely only be whitelisted if
> > more working models are found.
> 
> Also makes a lot of sense, although I believe there are several places that
> users post that their Dell (and also Alienware, I think) laptops should be
> compatible with dell_smm_hwmon (but tutorials for that usually tell to use
> "force" instead of "ignore_dmi"), just nothing "unified". But I believe
> nobody tries to report to kernel bugzilla to actually fix it.
> 
> > Besides that, if you can disable automatic fan control (i assume
> > with dell-bios-fan-control) without causing any problems (see the
> > second question), then i could additionally add your model on the
> > fan mode control whitelist.
> 
> IIRC, dell-bios-fan-control works fine here, I have used it a few times
> before, but since I never really figured out how to manually control fans,
> and didn't want to risk misconfiguration damaging the laptop, then I never
> stuck with that and still use bios automatic fan control.
> 
> I can check it at some future point in time though, but at the moment I
> can't guarantee much.

No problem.
Comment 4 Armin Wolf 2022-06-14 00:59:23 UTC
Your model is now whitelisted, the patch is currently in hwmon-next
and will likely arrive with kernel 5.20.

Note You need to log in before you can comment on or make changes to this bug.