Bug 215801 - Rmmod'ing amd-pstate doesn't restore acpi-cpufreq
Summary: Rmmod'ing amd-pstate doesn't restore acpi-cpufreq
Status: RESOLVED WILL_NOT_FIX
Alias: None
Product: Power Management
Classification: Unclassified
Component: cpufreq (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: linux-pm@vger.kernel.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-05 01:43 UTC by Artem S. Tashkinov
Modified: 2023-09-28 02:31 UTC (History)
2 users (show)

See Also:
Kernel Version: 5.17.1
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Artem S. Tashkinov 2022-04-05 01:43:08 UTC
It's nice that you can now replace acpi-cpufreq with amd-pstate using replace=1 but what about the opposite?

Can it be done without rebooting if acpi-cpufreq is built-in?

Would be really nice to have.

Meanwhile some sort of power managerment still works after `rmmod amd-pstate` because I see that reported frequencies in /proc/cpuinfo change: one or two random cores are oscillating between 1700 and 2000MHz, all the others are stuck at 3800MHz.
Comment 1 Artem S. Tashkinov 2022-04-11 16:22:44 UTC
Huang Rui,

Is this doable or I'm asking too much?
Comment 2 Artem S. Tashkinov 2023-09-20 10:54:23 UTC
This is still relevant as of Linux 6.6.

Would be great if removing amd-pstate enabled acpi-cpufreq.
Comment 3 Perry Yuan(AMD) 2023-09-21 05:40:20 UTC
(In reply to Artem S. Tashkinov from comment #2)
> This is still relevant as of Linux 6.6.
> 
> Would be great if removing amd-pstate enabled acpi-cpufreq.

Normally the system hardware needs to reinitialize CPPC and low-level power management firmware when CPPC driver loading, so it better to change grub parameters and reboot again.
dynamically removing amd-pstate and load acpi_cpufreq probably cause some potential issues. 

Perry.
Comment 4 Artem S. Tashkinov 2023-09-21 08:18:05 UTC
(In reply to Perry Yuan(AMD) from comment #3)
> (In reply to Artem S. Tashkinov from comment #2)
> > This is still relevant as of Linux 6.6.
> > 
> > Would be great if removing amd-pstate enabled acpi-cpufreq.
> 
> Normally the system hardware needs to reinitialize CPPC and low-level power
> management firmware when CPPC driver loading, so it better to change grub
> parameters and reboot again.
> dynamically removing amd-pstate and load acpi_cpufreq probably cause some
> potential issues. 
> 
> Perry.

Could you add this as a note to the amd pstate driver documentation?

Documentation/admin-guide/pm/amd-pstate.rst

Thank you!
Comment 5 Perry Yuan(AMD) 2023-09-28 02:31:13 UTC
(In reply to Artem S. Tashkinov from comment #4)
> (In reply to Perry Yuan(AMD) from comment #3)
> > (In reply to Artem S. Tashkinov from comment #2)
> > > This is still relevant as of Linux 6.6.
> > > 
> > > Would be great if removing amd-pstate enabled acpi-cpufreq.
> > 
> > Normally the system hardware needs to reinitialize CPPC and low-level power
> > management firmware when CPPC driver loading, so it better to change grub
> > parameters and reboot again.
> > dynamically removing amd-pstate and load acpi_cpufreq probably cause some
> > potential issues. 
> > 
> > Perry.
> 
> Could you add this as a note to the amd pstate driver documentation?
> 
> Documentation/admin-guide/pm/amd-pstate.rst
> 
> Thank you!


Sure, we can add this to amd-pstate.rst with a new update. 

Perry.

Note You need to log in before you can comment on or make changes to this bug.