Bug 215771 - Touch pad RIGHT button not operational after commit 37ef4c19b4c6 on ICL Si1516 laptop
Summary: Touch pad RIGHT button not operational after commit 37ef4c19b4c6 on ICL Si15...
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Input Devices (show other bugs)
Hardware: x86-64 Linux
: P1 high
Assignee: drivers_input-devices
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-29 15:03 UTC by Nikolai
Modified: 2022-04-05 09:11 UTC (History)
2 users (show)

See Also:
Kernel Version: 5.16.14
Tree: Mainline
Regression: No


Attachments
ACPI DSDT (1.75 MB, text/x-csrc)
2022-03-29 15:23 UTC, Nikolai
Details
dmesg |grep input (2.34 KB, text/plain)
2022-03-29 15:24 UTC, Nikolai
Details

Description Nikolai 2022-03-29 15:03:42 UTC
Following commit renders touch pad rigth button non operational on ICL Si1516 laptop.
It's revertion solves the problem.

commit 37ef4c19b4c659926ce65a7ac709ceaefb211c40
Author: José Expósito <jose.exposito89@gmail.com>
Date:   Tue Feb 8 09:59:16 2022 -0800

    Input: clear BTN_RIGHT/MIDDLE on buttonpads
    
    Buttonpads are expected to map the INPUT_PROP_BUTTONPAD property bit
    and the BTN_LEFT key bit.
    
    As explained in the specification, where a device has a button type
    value of 0 (click-pad) or 1 (pressure-pad) there should not be
    discrete buttons:
    https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/touchpad-windows-precision-touchpad-collection#device-capabilities-feature-report
    
    However, some drivers map the BTN_RIGHT and/or BTN_MIDDLE key bits even
    though the device is a buttonpad and therefore does not have those
    buttons.
    
    This behavior has forced userspace applications like libinput to
    implement different workarounds and quirks to detect buttonpads and
    offer to the user the right set of features and configuration options.
    For more information:
    https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/726
    
    In order to avoid this issue clear the BTN_RIGHT and BTN_MIDDLE key
    bits when the input device is register if the INPUT_PROP_BUTTONPAD
    property bit is set.
    
    Notice that this change will not affect udev because it does not check
    for buttons. See systemd/src/udev/udev-builtin-input_id.c.
    
    List of known affected hardware:
    
     - Chuwi AeroBook Plus
     - Chuwi Gemibook
     - Framework Laptop
     - GPD Win Max
     - Huawei MateBook 2020
     - Prestigio Smartbook 141 C2
     - Purism Librem 14v1
     - StarLite Mk II   - AMI firmware
     - StarLite Mk II   - Coreboot firmware
     - StarLite Mk III  - AMI firmware
     - StarLite Mk III  - Coreboot firmware
     - StarLabTop Mk IV - AMI firmware
     - StarLabTop Mk IV - Coreboot firmware
     - StarBook Mk V
    
    Acked-by: Peter Hutterer <peter.hutterer@who-t.net>
    Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    Acked-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: José Expósito <jose.exposito89@gmail.com>
    Link: https://lore.kernel.org/r/20220208174806.17183-1-jose.exposito89@gmail.com
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Comment 1 Nikolai 2022-03-29 15:23:57 UTC
Created attachment 300640 [details]
ACPI DSDT
Comment 2 Nikolai 2022-03-29 15:24:58 UTC
Created attachment 300641 [details]
dmesg |grep input
Comment 3 The Linux kernel's regression tracker (Thorsten Leemhuis) 2022-04-05 09:11:42 UTC
FYI, the culprit was already reverted in mainline: https://git.kernel.org/torvalds/c/8b188fba75195745026e11d408e4a7e94e01d701

Will likely soon get backported.

Note You need to log in before you can comment on or make changes to this bug.