Bug 215529 - REGRESSION kernel NULL pointer crash in typec_link_ports
Summary: REGRESSION kernel NULL pointer crash in typec_link_ports
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: USB (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Heikki Krogerus
URL:
Keywords:
: 215530 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-01-24 22:37 UTC by Len Brown
Modified: 2022-01-26 11:41 UTC (History)
1 user (show)

See Also:
Kernel Version: 5.17.0-rc1-00032-gdd81e1c7d5fb
Subsystem:
Regression: No
Bisected commit-id:


Attachments
typec patch from lkml that does NOT help (1.08 KB, message/rfc822)
2022-01-24 22:37 UTC, Len Brown
Details
Dell XPS 13 9300 dmesg before patch (81.39 KB, text/plain)
2022-01-24 22:39 UTC, Len Brown
Details
Dell XPS 13 9300 dmesg after patch (81.77 KB, text/plain)
2022-01-24 22:40 UTC, Len Brown
Details
typec patch that WORKS (1.10 KB, application/mbox)
2022-01-24 22:58 UTC, Len Brown
Details

Description Len Brown 2022-01-24 22:37:42 UTC
Created attachment 300311 [details]
typec patch from lkml that does NOT help

Booting 5.17-rc1 (plus a couple of commits) fails on two of my systems,

Dell XPS 13 9360 (FWIW, Linux Torvalds has one of these)
Dell XPS 13 9310 (Intel's latest Tiger Lake system)

[    2.965017] ath11k_pci 0000:72:00.0 wlp114s0: renamed from wlan0
[    3.046448] systemd-journald[302]: File /var/log/journal/5ce4de201d294a6db31ace17ae52adb8/user-1000.journal corrupted or uncleanly shut down, renaming and replacing.
[    3.111468] BUG: kernel NULL pointer dereference, address: 0000000000000008
[    3.111472] #PF: supervisor read access in kernel mode
[    3.111474] #PF: error_code(0x0000) - not-present page
[    3.111475] PGD 0 P4D 0
[    3.111477] Oops: 0000 [#1] PREEMPT SMP NOPTI
[    3.111479] CPU: 4 PID: 314 Comm: kworker/4:2 Not tainted 5.17.0-rc1-00032-gdd81e1c7d5fb-dirty #10
[    3.111481] Hardware name: Dell Inc. XPS 13 9310/0202R4, BIOS 3.2.0 09/30/2021
[    3.111483] Workqueue: events_long ucsi_init_work [typec_ucsi]
[    3.111489] RIP: 0010:component_master_add_with_match+0x19/0x100
[    3.111494] Code: 5b 41 5c 5d c3 66 66 2e 0f 1f 84 00 00 00 00 00 90 0f 1f 44 00 00 55 48 89 e5 41 56 49 89 fe 41 55 49 89 d5 41 54 53 48 89 f3 <48> 8b 72 08 48 3b 32 74 10 48 89 d7 e8 06 fd ff ff 85 c0 0f 85 a0
[    3.111496] RSP: 0018:ffffb26080a57d88 EFLAGS: 00010296
[    3.111498] RAX: 0000000000000000 RBX: ffffffffc03dea30 RCX: 0000000000000000
[    3.111499] RDX: 0000000000000000 RSI: ffffffffc03dea30 RDI: ffff932988db7808
[    3.111500] RBP: ffffb26080a57da8 R08: ffff9329802aaaa0 R09: ffff932981f8f030
[    3.111502] R10: ffff93299e85b000 R11: 0000000000000000 R12: ffff932988db7800
[    3.111503] R13: 0000000000000000 R14: ffff932988db7808 R15: ffff932988db7808
[    3.111504] FS:  0000000000000000(0000) GS:ffff9330ef700000(0000) knlGS:0000000000000000
[    3.111505] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    3.111507] CR2: 0000000000000008 CR3: 0000000256e10002 CR4: 0000000000770ee0
[    3.111508] PKRU: 55555554
[    3.111509] Call Trace:
[    3.111511]  <TASK>
[    3.111514]  typec_link_ports+0x6f/0x90 [typec]
[    3.111520]  typec_register_port+0x1d4/0x2d0 [typec]
[    3.111525]  ucsi_init_work+0x401/0x720 [typec_ucsi]
[    3.111529]  process_one_work+0x21a/0x3f0
[    3.111533]  worker_thread+0x50/0x3d0
[    3.111535]  ? rescuer_thread+0x360/0x360
[    3.111537]  kthread+0xfa/0x120
[    3.111539]  ? kthread_complete_and_exit+0x20/0x20
[    3.111541]  ret_from_fork+0x1f/0x30
[    3.111545]  </TASK>
Comment 1 Len Brown 2022-01-24 22:39:20 UTC
Created attachment 300312 [details]
Dell XPS 13 9300 dmesg before patch

Usually the system hangs before I can log in.
but sometimes it comes up and I can grab the dmesg before it hangs -- attached.
Comment 2 Len Brown 2022-01-24 22:40:12 UTC
Created attachment 300313 [details]
Dell XPS 13 9300 dmesg after patch

The patch above didn't help.
I was able to grab another dmesg after boot and before system hang.
Comment 3 Len Brown 2022-01-24 22:58:25 UTC
Created attachment 300314 [details]
typec patch that WORKS

Both the 9360 and the 9310 again boot without complaint
when this patch is applied.
Comment 4 neoe 2022-01-26 01:36:52 UTC
maybe similar, the the patch not work for me (https://bugzilla.kernel.org/show_bug.cgi?id=215530)
Comment 5 neoe 2022-01-26 11:41:22 UTC
*** Bug 215530 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.