Bug 214339 - sendmsg return value may be positive while send errors
Summary: sendmsg return value may be positive while send errors
Status: NEW
Alias: None
Product: Networking
Classification: Unclassified
Component: IPV4 (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: Stephen Hemminger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-07 09:23 UTC by liuxf
Modified: 2021-09-29 01:21 UTC (History)
1 user (show)

See Also:
Kernel Version: 5.14.7
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description liuxf 2021-09-07 09:23:54 UTC
in file udp.c, a function named udp_sendmsg has a code like this:

	/* Lockless fast path for the non-corking case. */
	if (!corkreq) {
		skb = ip_make_skb(sk, fl4, getfrag, msg, ulen,
				  sizeof(struct udphdr), &ipc, &rt,
				  msg->msg_flags);
		err = PTR_ERR(skb);
		if (!IS_ERR_OR_NULL(skb))
			err = udp_send_skb(skb, fl4);
		goto out;
	}

but function ip_make_skb may return a null, then err will be set to 0;and out like this:

out:
	ip_rt_put(rt);
	if (free)
		kfree(ipc.opt);
	if (!err)
		return len;  // return a positive value

actually, because lock of kernel memory or socket_buffer,the ip_make_skb failed means the send operation failed. but a positive value is returnd here. finnally, users regard the operation was success, but actually it failed in kernel.
Comment 1 liuxf 2021-09-10 01:42:59 UTC
what's more, when packet processed by tc module, pfifo_fast_enqueue is likely failed, then NET_XMIT_DROP(0x01) was returned, which is also result to a failed send operation was regard as a success one by sendmsg
Comment 2 liuxf 2021-09-29 01:21:28 UTC
do_append_data:
	up->len += ulen;
	err = ip_append_data(sk, fl4, getfrag, msg, ulen,
			     sizeof(struct udphdr), &ipc, &rt,
			     corkreq ? msg->msg_flags|MSG_MORE : msg->msg_flags);
	if (err)
		udp_flush_pending_frames(sk);
	else if (!corkreq)
		err = udp_push_pending_frames(sk);   //err may be zero here too
	else if (unlikely(skb_queue_empty(&sk->sk_write_queue)))
		up->pending = 0;
	release_sock(sk);

out:
	ip_rt_put(rt);
out_free:
	if (free)
		kfree(ipc.opt);
	if (!err)
		return len;

Note You need to log in before you can comment on or make changes to this bug.