Bug 212705 - ACPI table upgrade uses "install" instead of "override"
Summary: ACPI table upgrade uses "install" instead of "override"
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: ACPI
Classification: Unclassified
Component: Config-Tables (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Zhang Rui
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-17 01:10 UTC by Major Hayden
Modified: 2022-06-21 07:47 UTC (History)
1 user (show)

See Also:
Kernel Version: 5.11.12
Subsystem:
Regression: Yes
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Major Hayden 2021-04-17 01:10:59 UTC 
Hello there,

I have an ACPI table override on my Lenovo T490 laptop to disable the nvidia graphics card and it stopped working when I upgraded from 5.11.11 to 5.11.12. The original bootup looked like this:

ACPI: SSDT 0x0000000087741000 000D11 (v01 LENOVO NvOptTbl 00001000 INTL 20160527)
ACPI: Table Upgrade: override [SSDT-LENOVO-SgRpSsdt]
ACPI: SSDT 0x0000000087740000 Physical table override, new table: 0x0000000086684000
ACPI: SSDT 0x0000000086684000 000DB7 (v02 LENOVO SgRpSsdt 00001001 INTL 20200717)

The SSDT is in an initrd file that is loaded at boot time and the override was working great. After upgrading to 5.11.12, I now see:

ACPI: SSDT 0x0000000087740000 000DC9 (v02 LENOVO SgRpSsdt 00001000 INTL 20160527)
ACPI: DMAR 0x0000000087742000 0000A8 (v01 LENOVO TP-N2R   00001014 PTEC 00000002)
ACPI: BGRT 0x000000008773E000 000038 (v01 LENOVO TP-N2R   00001014 PTEC 00000002)
ACPI: UEFI 0x000000008C009000 00013E (v01 LENOVO TP-N2R   00001014 PTEC 00000002)
ACPI: FPDT 0x000000008773D000 000044 (v01 LENOVO TP-N2R   00001014 PTEC 00001014)
ACPI: SSDT ACPI table found in initrd [kernel/firmware/acpi/ssdt11.aml][0xdb7]
ACPI: Table Upgrade: install [SSDT-LENOVO-SgRpSsdt]
ACPI: SSDT 0x000000008655F000 000DB7 (v02 LENOVO SgRpSsdt 00001000 INTL 20210105)

The "Table Upgrade" line now shows "install" instead of "override". This causes a bunch of errors when the same SSDT table is "installed" a second time:

ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20201113/psobject-220)
ACPI BIOS Error (bug): Failure creating named object [\_SB.PCI0.ELCT], AE_ALREADY_EXISTS (20201113/dswload2-326)
ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20201113/psobject-220)
ACPI BIOS Error (bug): Failure creating named object [\_SB.PCI0.HVID], AE_ALREADY_EXISTS (20201113/dswload2-326)
ACPI Error: AE_ALREADY_EXISTS, During name lookup/catalog (20201113/psobject-220)
ACPI BIOS Error (bug): Failure creating named object [\_SB.PCI0.HDID], AE_ALREADY_EXISTS (20201113/dswload2-326)

After a quick bisect, it looks like 1a1c130ab7575498eed5bcf7220037ae09cd1f8a (from https://lkml.org/lkml/2021/4/5/365 ) could be what's causing it. However, my skills in this part of the kernel aren't good enough to dig deeper.

Thanks for any help you can provide!
Major
Comment 1 Zhang Rui 2021-12-16 15:05:35 UTC 
Does the problem still exist with latest vanilla kernel?
Comment 2 Zhang Rui 2022-06-21 07:47:23 UTC 
Bug closed as there is no response from the bug reporter.
Please feel free to reopen it if the problem still exists with latest upstream kernel.
Note You need to log in before you can comment on or make changes to this bug.