Bug 212593 - Support for VOX ToneLab EX
Summary: Support for VOX ToneLab EX
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Sound(ALSA) (show other bugs)
Hardware: All Linux
: P1 enhancement
Assignee: Jaroslav Kysela
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-07 09:38 UTC by alberto.griggio
Modified: 2021-04-07 14:45 UTC (History)
1 user (show)

See Also:
Kernel Version: 5.4
Tree: Mainline
Regression: No


Attachments

Description alberto.griggio 2021-04-07 09:38:26 UTC
Hello,
I have a Vox ToneLab EX guitar pedal, which can be used also as a sound card. This is already almost supported, it's enough to add the following to sound/usb/quirks-table.h, immediately after the analogous entry for the ToneLab ST which is already there:

{
	USB_DEVICE_VENDOR_SPEC(0x0944, 0x0204),
	.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
		.vendor_name = "KORG, Inc.",
		/* .product_name = "ToneLab EX", */
		.ifnum = 3,
		.type = QUIRK_MIDI_STANDARD_INTERFACE,
	}
},


So far I have been manually patching my kernel, but I think this could go upsream...

Thanks!
Comment 1 Takashi Iwai 2021-04-07 13:56:55 UTC
Sure, that can be merged to the upstream.

Care to submit a proper patch with the description and your signed-off-by line?
Or shall I write and apply in my side?
Comment 2 alberto.griggio 2021-04-07 14:04:03 UTC
Great, thanks!
I can certainly try to submit a proper patch, but it will probably take me some time to learn the whole process. If you can do it on your side (the patch is really trivial), that is totally fine by me. But if you prefer me to do it for whatever reason, I'll do my best. Just let me know.
Comment 3 Takashi Iwai 2021-04-07 14:45:21 UTC
OK, then I'll submit the patch to the upstream.

Note You need to log in before you can comment on or make changes to this bug.