Bug 212407 - Leds on Zbook Studio x360
Summary: Leds on Zbook Studio x360
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Sound(ALSA) (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: Jaroslav Kysela
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-23 14:59 UTC by marietta
Modified: 2021-04-02 18:04 UTC (History)
2 users (show)

See Also:
Kernel Version: 5.11.8
Subsystem:
Regression: No
Bisected commit-id:

Attachments
alsa-info.txt (56.30 KB, text/plain)
2021-03-26 14:59 UTC, marietta 		Details
Fix patch (1.41 KB, patch)
2021-04-01 17:12 UTC, Takashi Iwai 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description marietta 2021-03-23 14:59:04 UTC 
Hello,

https://bugzilla.kernel.org/show_bug.cgi?id=211893

can you make a similar patch for HP ZBook Studio x360 G5 too?
The leds work the same way.


Playback mute led:

hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK 0x10
hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIR 0x10
hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x10
-> led turns on
hda-verb dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0
-> led turns off


Mic mute led:

-> led is on
hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_MASK 0x20
hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DIR 0x20
hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0
-> the led turns off
hda-verb /dev/snd/hwC0D0 0x01 SET_GPIO_DATA 0x20
-> the led turns on


Thank you
Comment 1 Takashi Iwai 2021-03-26 13:57:19 UTC 
Could you give alsa-info.sh output?  Run with --no-upload and attach to Bugzilla.
Comment 2 marietta 2021-03-26 14:59:19 UTC 
Created attachment 296075 [details]
alsa-info.txt
Comment 3 Takashi Iwai 2021-04-01 17:09:11 UTC 
OK, that's compatible with the already existing quirk.
You can pass model=hp-zbook-mute-led option to snd-hda-intel driver for applying the same quirk.

Meanwhile I'll cook up the patch to apply the quirk for your model statically in the quirk table.
Comment 4 Takashi Iwai 2021-04-01 17:12:57 UTC 
Created attachment 296179 [details]
Fix patch
Comment 5 marietta 2021-04-02 18:04:57 UTC 
The patch is working perfectly, thank you!
Note You need to log in before you can comment on or make changes to this bug.