Bug 205707 - LINUX KERNEL 5.3.10 - ext4_xattr_set_entry use-after-free
Summary: LINUX KERNEL 5.3.10 - ext4_xattr_set_entry use-after-free
Status: RESOLVED PATCH_ALREADY_AVAILABLE
Alias: None
Product: File System
Classification: Unclassified
Component: ext4 (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: fs_ext4@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-29 17:05 UTC by Tristan Madani
Modified: 2019-12-01 23:51 UTC (History)
1 user (show)

See Also:
Kernel Version: 5.3.10
Tree: Mainline
Regression: No


Attachments

Description Tristan Madani 2019-11-29 17:05:34 UTC
LINUX KERNEL 5.3.10 - ext4_xattr_set_entry use-after-free

0x01 - Introduction
===

# Product: Linux Kernel 
# Version: 5.3.10 (and probably other versions)
# Bug: UAF (Read)
# Tested on: GNU/Linux Debian 9 x86_64


0x02 - Crash report
===

EXT4-fs (sda): Unrecognized mount option "fsuuid=Pcc366a�-1035-3ea9-7c93-j1a9eda2" or missing value
==================================================================
BUG: KASAN: use-after-free in ext4_xattr_set_entry+0x2a6b/0x3440 fs/ext4/xattr.c:1600
Read of size 4 at addr ffff88800aaf0002 by task syz-executor.3/354

CPU: 0 PID: 354 Comm: syz-executor.3 Not tainted 5.3.10 #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xca/0x13e lib/dump_stack.c:113
 print_address_description+0x67/0x360 mm/kasan/report.c:351
 __kasan_report.cold.7+0x1a/0x3b mm/kasan/report.c:482
 kasan_report+0xe/0x12 mm/kasan/common.c:618
 ext4_xattr_set_entry+0x2a6b/0x3440 fs/ext4/xattr.c:1600
 ext4_xattr_ibody_set+0x78/0x2b0 fs/ext4/xattr.c:2236
 ext4_xattr_set_handle+0x70e/0xff0 fs/ext4/xattr.c:2392
 ext4_initxattrs+0xb8/0x120 fs/ext4/xattr_security.c:43
 security_inode_init_security security/security.c:956 [inline]
 security_inode_init_security+0x186/0x310 security/security.c:929
 __ext4_new_inode+0x4000/0x49c0 fs/ext4/ialloc.c:1160
EXT4-fs error (device sda): ext4_xattr_set_entry:1603: inode #15574: comm syz-executor.0: corrupted xattr entries
 ext4_mkdir+0x266/0xd10 fs/ext4/namei.c:2763
 vfs_mkdir+0x3ae/0x5c0 fs/namei.c:3815
 do_mkdirat+0x144/0x250 fs/namei.c:3838
 do_syscall_64+0xbc/0x560 arch/x86/entry/common.c:296
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x464cd7
Code: 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 53 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc3097ec68 EFLAGS: 00000202 ORIG_RAX: 0000000000000053
RAX: ffffffffffffffda RBX: 00007ffc3097ecb0 RCX: 0000000000464cd7
RDX: 00000000004a5f12 RSI: 00000000000001ff RDI: 00007ffc3097ecb0
RBP: 00007ffc3097ecac R08: 0000000000000000 R09: 0000000000000006
R10: 0000000000000000 R11: 0000000000000202 R12: 00000000000e9973
R13: 0000000000000004 R14: 00000000000e9937 R15: 00000000ffffffff

The buggy address belongs to the page:
page:ffffea00002abc00 refcount:0 mapcount:-128 mapping:0000000000000000 index:0x1
flags: 0x100000000000000()
raw: 0100000000000000 ffffea00002aee08 ffffea00002a9c08 0000000000000000
raw: 0000000000000001 0000000000000003 00000000ffffff7f 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88800aaeff00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
 ffff88800aaeff80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff88800aaf0000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
                   ^
 ffff88800aaf0080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
 ffff88800aaf0100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
==================================================================
Comment 1 Theodore Tso 2019-12-01 23:51:49 UTC
I'm pretty sure this was fixed by 4ea99936a16 ("ext4: add more paranoia checking in ext4_expand_extra_isize handling").

Note You need to log in before you can comment on or make changes to this bug.