Bug 205235 - Improve error messages for kunit_tool when kunitconfig is invalid
Summary: Improve error messages for kunit_tool when kunitconfig is invalid
Status: RESOLVED CODE_FIX
Alias: None
Product: Tools
Classification: Unclassified
Component: KUnit (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Tools/KUnit virtual default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-17 21:07 UTC by David Gow
Modified: 2020-03-31 20:58 UTC (History)
1 user (show)

See Also:
Kernel Version: linux-kselftest/test
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description David Gow 2019-10-17 21:07:51 UTC
kunit_tool prints an error message when there are missing or wrong entries in the kunitconfig file.

Currently, this message is 'Error:root:Kconfig is not contained in validated .config!' which doesn't describe the issue particularly well.

We should consider improving the message, and possibly adding a list of the invalid entries.

Some of this was done in the old kunit/alpha/master branch in:
https://kunit.googlesource.com/linux/+/1996e6ba3efce20a6a64c527024acbd484db2f9d
and
https://kunit.googlesource.com/linux/+/f192c1881e0d58be78e30cb0fbc6c29968bc0c79%5E%21/#F0
Comment 1 Brendan Higgins 2020-03-31 18:33:39 UTC
This fix was accepted a while ago: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit&id=dde54b9492a8ba46bcd7e7e26172adf2bfcea817

David, can you close this?

Note You need to log in before you can comment on or make changes to this bug.