mt76x0e does not currently support suspend/resume. I will work on it soon

Good to know.

Thank you!

Created attachment 281179 [details]
0001-mt76x0e-add-pm-support.patch

Could you please try attached patch? Please note it is just compiled and not tested since I have no mt7630e adapter

Hi,

I got the following error when trying to compile : 

ERROR: "mt76_tx_free" [drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0e.ko] undefined! 

I tried different things:
- Compiling the 5.0.0-rc7 kernel without the patch, it does work
- Compiling then the same kernel with the patch, I got this error
- Launching `make drivers/net/wireless/mediatek/mt76/mt76x0/mt76x0e.ko` (but it should do the same thing if I understood corerctly), and got the same error.

I tried investigate in the pci.c file myself:
it does compile when I copy the missing methods from "../tx.c"`, but when I try to load the modules with "rmmod mt76x0e; insmod path/to/mt76x0e.ko", I got the following error: "Invalid module format".

Created attachment 281199 [details]
0002-mt76x0e-add-pm-support.patch

I added missing EXPORT_SYMBOL_GPL for mt76_tx_free in 0002-mt76x0e-add-pm-support.patch

Hi,

I recompiled the kernel with this patch.
The wifi does work on startup, but does not work after a sleep mode.

The result of `journaltcl -xe` is : 
févr. 19 20:20:00 jdeniau-fedora NetworkManager[1058]: <warn>  [1550604000.4062] device (wlo1): Activation: (wifi) association took too long, failing activation
févr. 19 20:20:00 jdeniau-fedora NetworkManager[1058]: <info>  [1550604000.4063] device (wlo1): state change: config -> failed (reason 'ssid-not-found', sys-iface-state: 'managed')
févr. 19 20:20:00 jdeniau-fedora NetworkManager[1058]: <info>  [1550604000.4068] manager: NetworkManager state is now CONNECTED_GLOBAL
févr. 19 20:20:00 jdeniau-fedora NetworkManager[1058]: <warn>  [1550604000.4077] device (wlo1): Activation: failed for connection 'rogden 1'
févr. 19 20:20:00 jdeniau-fedora NetworkManager[1058]: <info>  [1550604000.4081] device (wlo1): state change: failed -> disconnected (reason 'none', sys-iface-state: 'managed')
févr. 19 20:20:00 jdeniau-fedora gnome-shell[1744]: An active wireless connection, in infrastructure mode, involves no access point?
févr. 19 20:20:00 jdeniau-fedora gnome-shell[1744]: An active wireless connection, in infrastructure mode, involves no access point?
févr. 19 20:20:00 jdeniau-fedora gnome-shell[1744]: An active wireless connection, in infrastructure mode, involves no access point?
févr. 19 20:20:01 jdeniau-fedora kernel:  0000:04:00.0: TX DMA did not stop
févr. 19 20:20:01 jdeniau-fedora kernel: mt76x0e 0000:04:00.0: Warning: MAC RX did not stop!
févr. 19 20:20:01 jdeniau-fedora kernel: mt76x0e 0000:04:00.0: TX DMA did not stop
févr. 19 20:20:01 jdeniau-fedora NetworkManager[1058]: <info>  [1550604001.8232] device (wlo1): set-hw-addr: set MAC address to 1A:76:18:BF:8A:D1 (scanning)
févr. 19 20:20:02 jdeniau-fedora NetworkManager[1058]: <info>  [1550604002.0326] device (wlo1): supplicant interface state: scanning -> disconnected
févr. 19 20:20:02 jdeniau-fedora NetworkManager[1058]: <info>  [1550604002.0345] device (wlo1): supplicant interface state: disconnected -> disabled
févr. 19 20:20:02 jdeniau-fedora NetworkManager[1058]: <info>  [1550604002.0507] device (wlo1): supplicant interface state: disabled -> disconnected


And `ifconfig`: 
wlo1: flags=4099<UP,BROADCAST,MULTICAST>  mtu 1500
        ether 1a:76:18:bf:8a:d1  txqueuelen 1000  (Ethernet)
        RX packets 3262  bytes 3113328 (2.9 MiB)
        RX errors 0  dropped 0  overruns 0  frame 0
        TX packets 2723  bytes 1125153 (1.0 MiB)
        TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0


Apparently, the message is slighty different this time, but is there a way to be sure that the patch is applied ? (I never compiled a kernel before, especially with a patch applied ! (but I use git on a daily basis so no problem about that))

you can do:
- git am <patch>
- make
- make modules_install
- make install

OK, that's what I did.

Last month, I started using this driver instead of the 3rd party mt7630e driver, because I upgraded from Ubuntu 18.04 to 20.04 (18.04 doesn't have mt76x0e), but then I hit the problem described in this bug report. My uname -rvmpio is "5.8.0-40-generic #45~20.04.1-Ubuntu SMP Fri Jan 15 11:35:04 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux" and even though the fix is two years old, it does not seem to have been applied (from a user's perspective).

My laptop is an Asus x455wa, lspci says "03:00.0 Network controller: MEDIATEK Corp. MT7630e 802.11bgn Wireless Network Adapter". After suspend+resume, driver stays loaded but no network is selected and the list of available networks is empty and any attempt to refresh it fails.

But if I rmmod mt76x0e and modprobe mt76x0e again, nothing happens. But at that moment, if I modprobe the 3rd-party mt7630e driver instead, wifi works again without having to restart the computer, even without redoing rmmod mt76x0e. That other driver is the one at https://github.com/neurobin/MT7630E

Created attachment 294833 [details]
0001-mt76-mt76x0u-fix-resume.patch

Hi Mathieu,

can you please try the attached patch? I added some missing bits from sdk but I have just compiled it since I do not have the adapter.

Although I know C language and how to compile things and how to operate the `patch` command, I haven't compiled a kernel since 1998 (back when I had 8 megs of RAM) and won't do it again. But I could be compiling just this driver if I get told how to do it. E.g. a certain `git clone` or `tar xf` of some download (or an apt command in ubuntu that really downloads Linux 5.8 and not 5.4), then cd into a certain folder and run a list of commands such as `make` and `modprobe`... the only kernel driver I've compiled in recent years is https://github.com/neurobin/MT7630E , but that's outside of the kernel tree so that tells me nothing about how to compile a single driver from the kernel tree.

(In reply to Mathieu Bouchard from comment #12)
> Although I know C language and how to compile things and how to operate the
> `patch` command, I haven't compiled a kernel since 1998 (back when I had 8
> megs of RAM) and won't do it again. But I could be compiling just this
> driver if I get told how to do it. E.g. a certain `git clone` or `tar xf` of
> some download (or an apt command in ubuntu that really downloads Linux 5.8
> and not 5.4), then cd into a certain folder and run a list of commands such
> as `make` and `modprobe`... the only kernel driver I've compiled in recent
> years is https://github.com/neurobin/MT7630E , but that's outside of the
> kernel tree so that tells me nothing about how to compile a single driver
> from the kernel tree.

Can you please try this repo [0]? I modified the Makefile to compile mt76 as external kernel module. (just compiled, not tested)

[0] https://github.com/LorenzoBianconi/mt76/tree/openwrt-19.07-makefile

Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where uname -r currently gives 5.8.0-41-generic ; I get this error message :

  CC [M]  /home/matju/src/mt76/agg-rx.o
/home/matju/src/mt76/agg-rx.c: In function `mt76_rx_aggr_stop':
/home/matju/src/mt76/agg-rx.c:293:2: error: implicit declaration of function `rcu_swap_protected' [-Werror=implicit-function-declaration]
  293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
      |  ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [scripts/Makefile.build:290 : /home/matju/src/mt76/agg-rx.o] Erreur 1
make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
make : on quitte le répertoire « /usr/src/linux-headers-5.8.0-41-generic »

I tried removing -Werror from your Makefile, but the default still treats this warning as an error, so I added -Wno-error instead, which made no difference, I had to write explicitly -Wno-error=implicit-function-declaration , but then it seems that this is not just a header problem after all, because then I got this :

  MODPOST /home/matju/src/mt76/Module.symvers
ERROR: modpost: "rcu_swap_protected" [/home/matju/src/mt76/mt76.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:111 : /home/matju/src/mt76/Module.symvers] Erreur 1
make[1]: *** Suppression du fichier « /home/matju/src/mt76/Module.symvers »
make: *** [Makefile:1693 : modules] Erreur 2
make : on quitte le répertoire « /usr/src/linux-headers-5.8.0-41-generic »

(In reply to Mathieu Bouchard from comment #14)
> Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where uname -r
> currently gives 5.8.0-41-generic ; I get this error message :
> 
>   CC [M]  /home/matju/src/mt76/agg-rx.o
> /home/matju/src/mt76/agg-rx.c: In function `mt76_rx_aggr_stop':
> /home/matju/src/mt76/agg-rx.c:293:2: error: implicit declaration of function
> `rcu_swap_protected' [-Werror=implicit-function-declaration]
>   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
>       |  ^~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[1]: *** [scripts/Makefile.build:290 : /home/matju/src/mt76/agg-rx.o]
> Erreur 1
> make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> make : on quitte le répertoire « /usr/src/linux-headers-5.8.0-41-generic »
> 
> I tried removing -Werror from your Makefile, but the default still treats
> this warning as an error, so I added -Wno-error instead, which made no
> difference, I had to write explicitly
> -Wno-error=implicit-function-declaration , but then it seems that this is
> not just a header problem after all, because then I got this :
> 
>   MODPOST /home/matju/src/mt76/Module.symvers
> ERROR: modpost: "rcu_swap_protected" [/home/matju/src/mt76/mt76.ko]
> undefined!
> make[1]: *** [scripts/Makefile.modpost:111 :
> /home/matju/src/mt76/Module.symvers] Erreur 1
> make[1]: *** Suppression du fichier « /home/matju/src/mt76/Module.symvers »
> make: *** [Makefile:1693 : modules] Erreur 2
> make : on quitte le répertoire « /usr/src/linux-headers-5.8.0-41-generic »

I updated the branch to compile against 5.8. Anyway rcu_swap_protected() should be defined in mt76.h

(In reply to Lorenzo Bianconi from comment #15)
> (In reply to Mathieu Bouchard from comment #14)
> > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where uname -r
> > currently gives 5.8.0-41-generic ; I get this error message :
> > 
> >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > /home/matju/src/mt76/agg-rx.c: In function `mt76_rx_aggr_stop':
> > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit declaration of
> function
> > `rcu_swap_protected' [-Werror=implicit-function-declaration]
> >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> >       |  ^~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > make[1]: *** [scripts/Makefile.build:290 : /home/matju/src/mt76/agg-rx.o]
> > Erreur 1
> > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > make : on quitte le répertoire « /usr/src/linux-headers-5.8.0-41-generic »
> > 
> > I tried removing -Werror from your Makefile, but the default still treats
> > this warning as an error, so I added -Wno-error instead, which made no
> > difference, I had to write explicitly
> > -Wno-error=implicit-function-declaration , but then it seems that this is
> > not just a header problem after all, because then I got this :
> > 
> >   MODPOST /home/matju/src/mt76/Module.symvers
> > ERROR: modpost: "rcu_swap_protected" [/home/matju/src/mt76/mt76.ko]
> > undefined!
> > make[1]: *** [scripts/Makefile.modpost:111 :
> > /home/matju/src/mt76/Module.symvers] Erreur 1
> > make[1]: *** Suppression du fichier « /home/matju/src/mt76/Module.symvers »
> > make: *** [Makefile:1693 : modules] Erreur 2
> > make : on quitte le répertoire « /usr/src/linux-headers-5.8.0-41-generic »
> 
> I updated the branch to compile against 5.8. Anyway rcu_swap_protected()
> should be defined in mt76.h

Hello Lorenzo, 

is your patch already released in the kernel 5.12.1?

I have also another problem with the MT7630e (besides the one with the sleep command): sometimes on my laptop the wifi disappears and only the wire connectivity is present. In order to make it working again I need to hibernate my laptop and power-on it again so that it loads again the driver.
Do you know what can be the issue and eventually the solution?

Thanks in advance,

Luca T.

(In reply to Luca T. from comment #16)
> (In reply to Lorenzo Bianconi from comment #15)
> > (In reply to Mathieu Bouchard from comment #14)
> > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where uname -r
> > > currently gives 5.8.0-41-generic ; I get this error message :
> > > 
> > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > /home/matju/src/mt76/agg-rx.c: In function `mt76_rx_aggr_stop':
> > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit declaration of
> > function
> > > `rcu_swap_protected' [-Werror=implicit-function-declaration]
> > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > >       |  ^~~~~~~~~~~~~~~~~~
> > > cc1: all warnings being treated as errors
> > > make[1]: *** [scripts/Makefile.build:290 : /home/matju/src/mt76/agg-rx.o]
> > > Erreur 1
> > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > make : on quitte le répertoire « /usr/src/linux-headers-5.8.0-41-generic
> »
> > > 
> > > I tried removing -Werror from your Makefile, but the default still treats
> > > this warning as an error, so I added -Wno-error instead, which made no
> > > difference, I had to write explicitly
> > > -Wno-error=implicit-function-declaration , but then it seems that this is
> > > not just a header problem after all, because then I got this :
> > > 
> > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > ERROR: modpost: "rcu_swap_protected" [/home/matju/src/mt76/mt76.ko]
> > > undefined!
> > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > make[1]: *** Suppression du fichier « /home/matju/src/mt76/Module.symvers
> »
> > > make: *** [Makefile:1693 : modules] Erreur 2
> > > make : on quitte le répertoire « /usr/src/linux-headers-5.8.0-41-generic
> »
> > 
> > I updated the branch to compile against 5.8. Anyway rcu_swap_protected()
> > should be defined in mt76.h
> 
> Hello Lorenzo, 

Hi Luca,

> 
> is your patch already released in the kernel 5.12.1?

nope since I have not received any feedback. Are you able to test it? (I do not have the mt7630e adapter) 

> 
> I have also another problem with the MT7630e (besides the one with the sleep
> command): sometimes on my laptop the wifi disappears and only the wire
> connectivity is present. In order to make it working again I need to
> hibernate my laptop and power-on it again so that it loads again the driver.
> Do you know what can be the issue and eventually the solution?

can you please describe when the issue occurs? do you have any info in the syslog?

Regards,
Lorenzo

> 
> Thanks in advance,
> 
> Luca T.

(In reply to Lorenzo Bianconi from comment #17)
> (In reply to Luca T. from comment #16)
> > (In reply to Lorenzo Bianconi from comment #15)
> > > (In reply to Mathieu Bouchard from comment #14)
> > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where uname -r
> > > > currently gives 5.8.0-41-generic ; I get this error message :
> > > > 
> > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > /home/matju/src/mt76/agg-rx.c: In function `mt76_rx_aggr_stop':
> > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit declaration of
> > > function
> > > > `rcu_swap_protected' [-Werror=implicit-function-declaration]
> > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > cc1: all warnings being treated as errors
> > > > make[1]: *** [scripts/Makefile.build:290 :
> /home/matju/src/mt76/agg-rx.o]
> > > > Erreur 1
> > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > make : on quitte le répertoire «
> /usr/src/linux-headers-5.8.0-41-generic
> > »
> > > > 
> > > > I tried removing -Werror from your Makefile, but the default still
> treats
> > > > this warning as an error, so I added -Wno-error instead, which made no
> > > > difference, I had to write explicitly
> > > > -Wno-error=implicit-function-declaration , but then it seems that this
> is
> > > > not just a header problem after all, because then I got this :
> > > > 
> > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > ERROR: modpost: "rcu_swap_protected" [/home/matju/src/mt76/mt76.ko]
> > > > undefined!
> > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > make[1]: *** Suppression du fichier «
> /home/matju/src/mt76/Module.symvers
> > »
> > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > make : on quitte le répertoire «
> /usr/src/linux-headers-5.8.0-41-generic
> > »
> > > 
> > > I updated the branch to compile against 5.8. Anyway rcu_swap_protected()
> > > should be defined in mt76.h
> > 
> > Hello Lorenzo, 
> 
> Hi Luca,
> 
> > 
> > is your patch already released in the kernel 5.12.1?
> 
> nope since I have not received any feedback. Are you able to test it? (I do
> not have the mt7630e adapter) 
> 
> > 
> > I have also another problem with the MT7630e (besides the one with the
> sleep
> > command): sometimes on my laptop the wifi disappears and only the wire
> > connectivity is present. In order to make it working again I need to
> > hibernate my laptop and power-on it again so that it loads again the
> driver.
> > Do you know what can be the issue and eventually the solution?
> 
> can you please describe when the issue occurs? do you have any info in the
> syslog?
> 
> Regards,
> Lorenzo
> 
> > 
> > Thanks in advance,
> > 
> > Luca T.

Hi Lorenzo,

yes, I have the hardware to test this patch.

I just installed the vanilla version of kernel 5.12.1, can you please provide me the link to the patch?

For the other issue I'll check the journal and provide you additional details soon (unfornately it happens once a day :) so I'll come back quickly).

Thanks in advance,

Luca

(In reply to Luca T. from comment #18)
> (In reply to Lorenzo Bianconi from comment #17)
> > (In reply to Luca T. from comment #16)
> > > (In reply to Lorenzo Bianconi from comment #15)
> > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where uname
> -r
> > > > > currently gives 5.8.0-41-generic ; I get this error message :
> > > > > 
> > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > /home/matju/src/mt76/agg-rx.c: In function `mt76_rx_aggr_stop':
> > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit declaration of
> > > > function
> > > > > `rcu_swap_protected' [-Werror=implicit-function-declaration]
> > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > cc1: all warnings being treated as errors
> > > > > make[1]: *** [scripts/Makefile.build:290 :
> > /home/matju/src/mt76/agg-rx.o]
> > > > > Erreur 1
> > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > > make : on quitte le répertoire «
> > /usr/src/linux-headers-5.8.0-41-generic
> > > »
> > > > > 
> > > > > I tried removing -Werror from your Makefile, but the default still
> > treats
> > > > > this warning as an error, so I added -Wno-error instead, which made
> no
> > > > > difference, I had to write explicitly
> > > > > -Wno-error=implicit-function-declaration , but then it seems that
> this
> > is
> > > > > not just a header problem after all, because then I got this :
> > > > > 
> > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > ERROR: modpost: "rcu_swap_protected" [/home/matju/src/mt76/mt76.ko]
> > > > > undefined!
> > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > make[1]: *** Suppression du fichier «
> > /home/matju/src/mt76/Module.symvers
> > > »
> > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > make : on quitte le répertoire «
> > /usr/src/linux-headers-5.8.0-41-generic
> > > »
> > > > 
> > > > I updated the branch to compile against 5.8. Anyway
> rcu_swap_protected()
> > > > should be defined in mt76.h
> > > 
> > > Hello Lorenzo, 
> > 
> > Hi Luca,
> > 
> > > 
> > > is your patch already released in the kernel 5.12.1?
> > 
> > nope since I have not received any feedback. Are you able to test it? (I do
> > not have the mt7630e adapter) 
> > 
> > > 
> > > I have also another problem with the MT7630e (besides the one with the
> > sleep
> > > command): sometimes on my laptop the wifi disappears and only the wire
> > > connectivity is present. In order to make it working again I need to
> > > hibernate my laptop and power-on it again so that it loads again the
> > driver.
> > > Do you know what can be the issue and eventually the solution?
> > 
> > can you please describe when the issue occurs? do you have any info in the
> > syslog?
> > 
> > Regards,
> > Lorenzo
> > 
> > > 
> > > Thanks in advance,
> > > 
> > > Luca T.
> 
> Hi Lorenzo,
> 
> yes, I have the hardware to test this patch.
> 
> I just installed the vanilla version of kernel 5.12.1, can you please
> provide me the link to the patch?

it is linked in the bz (it has the wrong mt76x0u name)

> 
> For the other issue I'll check the journal and provide you additional
> details soon (unfornately it happens once a day :) so I'll come back
> quickly).
> 
> Thanks in advance,
> 
> Luca

(In reply to Lorenzo Bianconi from comment #19)
> (In reply to Luca T. from comment #18)
> > (In reply to Lorenzo Bianconi from comment #17)
> > > (In reply to Luca T. from comment #16)
> > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where uname
> > -r
> > > > > > currently gives 5.8.0-41-generic ; I get this error message :
> > > > > > 
> > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > /home/matju/src/mt76/agg-rx.c: In function `mt76_rx_aggr_stop':
> > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit declaration of
> > > > > function
> > > > > > `rcu_swap_protected' [-Werror=implicit-function-declaration]
> > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > cc1: all warnings being treated as errors
> > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > /home/matju/src/mt76/agg-rx.o]
> > > > > > Erreur 1
> > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > > > make : on quitte le répertoire «
> > > /usr/src/linux-headers-5.8.0-41-generic
> > > > »
> > > > > > 
> > > > > > I tried removing -Werror from your Makefile, but the default still
> > > treats
> > > > > > this warning as an error, so I added -Wno-error instead, which made
> > no
> > > > > > difference, I had to write explicitly
> > > > > > -Wno-error=implicit-function-declaration , but then it seems that
> > this
> > > is
> > > > > > not just a header problem after all, because then I got this :
> > > > > > 
> > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > ERROR: modpost: "rcu_swap_protected" [/home/matju/src/mt76/mt76.ko]
> > > > > > undefined!
> > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > make[1]: *** Suppression du fichier «
> > > /home/matju/src/mt76/Module.symvers
> > > > »
> > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > make : on quitte le répertoire «
> > > /usr/src/linux-headers-5.8.0-41-generic
> > > > »
> > > > > 
> > > > > I updated the branch to compile against 5.8. Anyway
> > rcu_swap_protected()
> > > > > should be defined in mt76.h
> > > > 
> > > > Hello Lorenzo, 
> > > 
> > > Hi Luca,
> > > 
> > > > 
> > > > is your patch already released in the kernel 5.12.1?
> > > 
> > > nope since I have not received any feedback. Are you able to test it? (I
> do
> > > not have the mt7630e adapter) 
> > > 
> > > > 
> > > > I have also another problem with the MT7630e (besides the one with the
> > > sleep
> > > > command): sometimes on my laptop the wifi disappears and only the wire
> > > > connectivity is present. In order to make it working again I need to
> > > > hibernate my laptop and power-on it again so that it loads again the
> > > driver.
> > > > Do you know what can be the issue and eventually the solution?
> > > 
> > > can you please describe when the issue occurs? do you have any info in
> the
> > > syslog?
> > > 
> > > Regards,
> > > Lorenzo
> > > 
> > > > 
> > > > Thanks in advance,
> > > > 
> > > > Luca T.
> > 
> > Hi Lorenzo,
> > 
> > yes, I have the hardware to test this patch.
> > 
> > I just installed the vanilla version of kernel 5.12.1, can you please
> > provide me the link to the patch?
> 
> it is linked in the bz (it has the wrong mt76x0u name)
> 
> > 
> > For the other issue I'll check the journal and provide you additional
> > details soon (unfornately it happens once a day :) so I'll come back
> > quickly).
> > 
> > Thanks in advance,
> > 
> > Luca

Hi Lorenzo,

it's quite a bit of time I'm recompiling kernel (~15 years :) ) so I have some difficulties...
Since I have a working kernel from the Linux Mint distributions, I copied the configuration file in the new kernel directory and I recompiled it.
The problem is that when I'm restarting the kernel does not load some drivers, hence linux can't find the hard disk and it goes in kernel panic.

Did I miss anything in the following compiling steps:
1) Extract kernel in /usr/src
2) Patch kernel (patch -p1 < <patch file>)
3) Copy config file: cp /boot/config-$(uname -r) .config
4) make menuconfig in case of changes (here I didn't change anything for now)
5) make -j12
6) make bzImage (it seems required by Linux Mint)
7) make modules_install
8) Copy the configuration file back: cp .config /boot/config-5.12.1
9) make install
10) update-grub2

Did I miss anything?

Thanks,

Luca

(In reply to Luca T. from comment #20)
> (In reply to Lorenzo Bianconi from comment #19)
> > (In reply to Luca T. from comment #18)
> > > (In reply to Lorenzo Bianconi from comment #17)
> > > > (In reply to Luca T. from comment #16)
> > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where
> uname
> > > -r
> > > > > > > currently gives 5.8.0-41-generic ; I get this error message :
> > > > > > > 
> > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > /home/matju/src/mt76/agg-rx.c: In function `mt76_rx_aggr_stop':
> > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit declaration
> of
> > > > > > function
> > > > > > > `rcu_swap_protected' [-Werror=implicit-function-declaration]
> > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > cc1: all warnings being treated as errors
> > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > Erreur 1
> > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > > > > make : on quitte le répertoire «
> > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > »
> > > > > > > 
> > > > > > > I tried removing -Werror from your Makefile, but the default
> still
> > > > treats
> > > > > > > this warning as an error, so I added -Wno-error instead, which
> made
> > > no
> > > > > > > difference, I had to write explicitly
> > > > > > > -Wno-error=implicit-function-declaration , but then it seems that
> > > this
> > > > is
> > > > > > > not just a header problem after all, because then I got this :
> > > > > > > 
> > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > ERROR: modpost: "rcu_swap_protected"
> [/home/matju/src/mt76/mt76.ko]
> > > > > > > undefined!
> > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > make[1]: *** Suppression du fichier «
> > > > /home/matju/src/mt76/Module.symvers
> > > > > »
> > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > make : on quitte le répertoire «
> > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > »
> > > > > > 
> > > > > > I updated the branch to compile against 5.8. Anyway
> > > rcu_swap_protected()
> > > > > > should be defined in mt76.h
> > > > > 
> > > > > Hello Lorenzo, 
> > > > 
> > > > Hi Luca,
> > > > 
> > > > > 
> > > > > is your patch already released in the kernel 5.12.1?
> > > > 
> > > > nope since I have not received any feedback. Are you able to test it?
> (I
> > do
> > > > not have the mt7630e adapter) 
> > > > 
> > > > > 
> > > > > I have also another problem with the MT7630e (besides the one with
> the
> > > > sleep
> > > > > command): sometimes on my laptop the wifi disappears and only the
> wire
> > > > > connectivity is present. In order to make it working again I need to
> > > > > hibernate my laptop and power-on it again so that it loads again the
> > > > driver.
> > > > > Do you know what can be the issue and eventually the solution?
> > > > 
> > > > can you please describe when the issue occurs? do you have any info in
> > the
> > > > syslog?
> > > > 
> > > > Regards,
> > > > Lorenzo
> > > > 
> > > > > 
> > > > > Thanks in advance,
> > > > > 
> > > > > Luca T.
> > > 
> > > Hi Lorenzo,
> > > 
> > > yes, I have the hardware to test this patch.
> > > 
> > > I just installed the vanilla version of kernel 5.12.1, can you please
> > > provide me the link to the patch?
> > 
> > it is linked in the bz (it has the wrong mt76x0u name)
> > 
> > > 
> > > For the other issue I'll check the journal and provide you additional
> > > details soon (unfornately it happens once a day :) so I'll come back
> > > quickly).
> > > 
> > > Thanks in advance,
> > > 
> > > Luca
> 
> Hi Lorenzo,
> 
> it's quite a bit of time I'm recompiling kernel (~15 years :) ) so I have
> some difficulties...
> Since I have a working kernel from the Linux Mint distributions, I copied
> the configuration file in the new kernel directory and I recompiled it.
> The problem is that when I'm restarting the kernel does not load some
> drivers, hence linux can't find the hard disk and it goes in kernel panic.
> 
> Did I miss anything in the following compiling steps:
> 1) Extract kernel in /usr/src
> 2) Patch kernel (patch -p1 < <patch file>)
> 3) Copy config file: cp /boot/config-$(uname -r) .config
> 4) make menuconfig in case of changes (here I didn't change anything for now)
> 5) make -j12
> 6) make bzImage (it seems required by Linux Mint)
> 7) make modules_install
> 8) Copy the configuration file back: cp .config /boot/config-5.12.1
> 9) make install
> 10) update-grub2
> 
> Did I miss anything?
> 
> Thanks,
> 
> Luca

Hi Lorenzo,

I managed somehow to make the new kernel loading and your patch seems working fine since I'm able to suspend and resume my laptop and the driver reloads correctly and connectivity is re-established.

You can proceed to merge the patch to the kernel.

In order to make it working temporarily I had to:
1) append "nomodeset" parameter otherwise the screen is black
2) replace the UUID identifier of my partition with the partition number itself (like /dev/sda4)
3) remove "initrd" line since laptop freezes when loading the image

When I'm installing the kernel I see this issue:
---------------------------------------------------
root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
        System.map "/boot"
run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 5.12.1 /boot/vmlinuz-5.12.1
run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1 /boot/vmlinuz-5.12.1
 * dkms: running auto installation service for kernel 5.12.1                                                                                                                                                                                 Error!  The /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf for module ndiswrapper includes a BUILD_EXCLUSIVE directive which
does not match this kernel/arch.  This indicates that it should not be built.
                                                                                                                                                                                                                                      [ OK ]
run-parts: executing /etc/kernel/postinst.d/initramfs-tools 5.12.1 /boot/vmlinuz-5.12.1
update-initramfs: Generating /boot/initrd.img-5.12.1
W: Possible missing firmware /lib/firmware/i915/skl_guc_49.0.1.bin for module i915
...
-----------------------------------------------------

Could you please help me to resolve the issues I have in the kernel installation?

Thanks in advance,

Luca

(In reply to Luca T. from comment #21)
> (In reply to Luca T. from comment #20)
> > (In reply to Lorenzo Bianconi from comment #19)
> > > (In reply to Luca T. from comment #18)
> > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > (In reply to Luca T. from comment #16)
> > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where
> > uname
> > > > -r
> > > > > > > > currently gives 5.8.0-41-generic ; I get this error message :
> > > > > > > > 
> > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > /home/matju/src/mt76/agg-rx.c: In function `mt76_rx_aggr_stop':
> > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit
> declaration
> > of
> > > > > > > function
> > > > > > > > `rcu_swap_protected' [-Werror=implicit-function-declaration]
> > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > Erreur 1
> > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > > > > > make : on quitte le répertoire «
> > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > »
> > > > > > > > 
> > > > > > > > I tried removing -Werror from your Makefile, but the default
> > still
> > > > > treats
> > > > > > > > this warning as an error, so I added -Wno-error instead, which
> > made
> > > > no
> > > > > > > > difference, I had to write explicitly
> > > > > > > > -Wno-error=implicit-function-declaration , but then it seems
> that
> > > > this
> > > > > is
> > > > > > > > not just a header problem after all, because then I got this :
> > > > > > > > 
> > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > undefined!
> > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > make[1]: *** Suppression du fichier «
> > > > > /home/matju/src/mt76/Module.symvers
> > > > > > »
> > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > make : on quitte le répertoire «
> > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > »
> > > > > > > 
> > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > rcu_swap_protected()
> > > > > > > should be defined in mt76.h
> > > > > > 
> > > > > > Hello Lorenzo, 
> > > > > 
> > > > > Hi Luca,
> > > > > 
> > > > > > 
> > > > > > is your patch already released in the kernel 5.12.1?
> > > > > 
> > > > > nope since I have not received any feedback. Are you able to test it?
> > (I
> > > do
> > > > > not have the mt7630e adapter) 
> > > > > 
> > > > > > 
> > > > > > I have also another problem with the MT7630e (besides the one with
> > the
> > > > > sleep
> > > > > > command): sometimes on my laptop the wifi disappears and only the
> > wire
> > > > > > connectivity is present. In order to make it working again I need
> to
> > > > > > hibernate my laptop and power-on it again so that it loads again
> the
> > > > > driver.
> > > > > > Do you know what can be the issue and eventually the solution?
> > > > > 
> > > > > can you please describe when the issue occurs? do you have any info
> in
> > > the
> > > > > syslog?
> > > > > 
> > > > > Regards,
> > > > > Lorenzo
> > > > > 
> > > > > > 
> > > > > > Thanks in advance,
> > > > > > 
> > > > > > Luca T.
> > > > 
> > > > Hi Lorenzo,
> > > > 
> > > > yes, I have the hardware to test this patch.
> > > > 
> > > > I just installed the vanilla version of kernel 5.12.1, can you please
> > > > provide me the link to the patch?
> > > 
> > > it is linked in the bz (it has the wrong mt76x0u name)
> > > 
> > > > 
> > > > For the other issue I'll check the journal and provide you additional
> > > > details soon (unfornately it happens once a day :) so I'll come back
> > > > quickly).
> > > > 
> > > > Thanks in advance,
> > > > 
> > > > Luca
> > 
> > Hi Lorenzo,
> > 
> > it's quite a bit of time I'm recompiling kernel (~15 years :) ) so I have
> > some difficulties...
> > Since I have a working kernel from the Linux Mint distributions, I copied
> > the configuration file in the new kernel directory and I recompiled it.
> > The problem is that when I'm restarting the kernel does not load some
> > drivers, hence linux can't find the hard disk and it goes in kernel panic.
> > 
> > Did I miss anything in the following compiling steps:
> > 1) Extract kernel in /usr/src
> > 2) Patch kernel (patch -p1 < <patch file>)
> > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > 4) make menuconfig in case of changes (here I didn't change anything for
> now)
> > 5) make -j12
> > 6) make bzImage (it seems required by Linux Mint)
> > 7) make modules_install
> > 8) Copy the configuration file back: cp .config /boot/config-5.12.1
> > 9) make install
> > 10) update-grub2
> > 
> > Did I miss anything?
> > 
> > Thanks,
> > 
> > Luca
> 
> Hi Lorenzo,
> 
> I managed somehow to make the new kernel loading and your patch seems
> working fine since I'm able to suspend and resume my laptop and the driver
> reloads correctly and connectivity is re-established.
> 
> You can proceed to merge the patch to the kernel.

nice. So you confirm now suspend/resume is fine. Can you please keep testing it for a while?

> 
> In order to make it working temporarily I had to:
> 1) append "nomodeset" parameter otherwise the screen is black
> 2) replace the UUID identifier of my partition with the partition number
> itself (like /dev/sda4)
> 3) remove "initrd" line since laptop freezes when loading the image
> 
> When I'm installing the kernel I see this issue:
> ---------------------------------------------------
> root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
> sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
>         System.map "/boot"
> run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 5.12.1
> /boot/vmlinuz-5.12.1
> run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1 /boot/vmlinuz-5.12.1
>  * dkms: running auto installation service for kernel 5.12.1                
> Error!  The /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf for
> module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> does not match this kernel/arch.  This indicates that it should not be built.
>                                                                             
> [ OK ]
> run-parts: executing /etc/kernel/postinst.d/initramfs-tools 5.12.1
> /boot/vmlinuz-5.12.1
> update-initramfs: Generating /boot/initrd.img-5.12.1
> W: Possible missing firmware /lib/firmware/i915/skl_guc_49.0.1.bin for
> module i915
> ...
> -----------------------------------------------------
> 

I am not familiar with mint build system. Is it enough to run make, make modules_install; make install or do you need to create the .deb file?

> Could you please help me to resolve the issues I have in the kernel
> installation?
> 
> Thanks in advance,
> 
> Luca

(In reply to Lorenzo Bianconi from comment #22)
> (In reply to Luca T. from comment #21)
> > (In reply to Luca T. from comment #20)
> > > (In reply to Lorenzo Bianconi from comment #19)
> > > > (In reply to Luca T. from comment #18)
> > > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > > (In reply to Luca T. from comment #16)
> > > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where
> > > uname
> > > > > -r
> > > > > > > > > currently gives 5.8.0-41-generic ; I get this error message :
> > > > > > > > > 
> > > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > > /home/matju/src/mt76/agg-rx.c: In function
> `mt76_rx_aggr_stop':
> > > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit
> > declaration
> > > of
> > > > > > > > function
> > > > > > > > > `rcu_swap_protected' [-Werror=implicit-function-declaration]
> > > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > > Erreur 1
> > > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > > > > > > make : on quitte le répertoire «
> > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > »
> > > > > > > > > 
> > > > > > > > > I tried removing -Werror from your Makefile, but the default
> > > still
> > > > > > treats
> > > > > > > > > this warning as an error, so I added -Wno-error instead,
> which
> > > made
> > > > > no
> > > > > > > > > difference, I had to write explicitly
> > > > > > > > > -Wno-error=implicit-function-declaration , but then it seems
> > that
> > > > > this
> > > > > > is
> > > > > > > > > not just a header problem after all, because then I got this
> :
> > > > > > > > > 
> > > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > > undefined!
> > > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > > make[1]: *** Suppression du fichier «
> > > > > > /home/matju/src/mt76/Module.symvers
> > > > > > > »
> > > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > > make : on quitte le répertoire «
> > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > »
> > > > > > > > 
> > > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > > rcu_swap_protected()
> > > > > > > > should be defined in mt76.h
> > > > > > > 
> > > > > > > Hello Lorenzo, 
> > > > > > 
> > > > > > Hi Luca,
> > > > > > 
> > > > > > > 
> > > > > > > is your patch already released in the kernel 5.12.1?
> > > > > > 
> > > > > > nope since I have not received any feedback. Are you able to test
> it?
> > > (I
> > > > do
> > > > > > not have the mt7630e adapter) 
> > > > > > 
> > > > > > > 
> > > > > > > I have also another problem with the MT7630e (besides the one
> with
> > > the
> > > > > > sleep
> > > > > > > command): sometimes on my laptop the wifi disappears and only the
> > > wire
> > > > > > > connectivity is present. In order to make it working again I need
> > to
> > > > > > > hibernate my laptop and power-on it again so that it loads again
> > the
> > > > > > driver.
> > > > > > > Do you know what can be the issue and eventually the solution?
> > > > > > 
> > > > > > can you please describe when the issue occurs? do you have any info
> > in
> > > > the
> > > > > > syslog?
> > > > > > 
> > > > > > Regards,
> > > > > > Lorenzo
> > > > > > 
> > > > > > > 
> > > > > > > Thanks in advance,
> > > > > > > 
> > > > > > > Luca T.
> > > > > 
> > > > > Hi Lorenzo,
> > > > > 
> > > > > yes, I have the hardware to test this patch.
> > > > > 
> > > > > I just installed the vanilla version of kernel 5.12.1, can you please
> > > > > provide me the link to the patch?
> > > > 
> > > > it is linked in the bz (it has the wrong mt76x0u name)
> > > > 
> > > > > 
> > > > > For the other issue I'll check the journal and provide you additional
> > > > > details soon (unfornately it happens once a day :) so I'll come back
> > > > > quickly).
> > > > > 
> > > > > Thanks in advance,
> > > > > 
> > > > > Luca
> > > 
> > > Hi Lorenzo,
> > > 
> > > it's quite a bit of time I'm recompiling kernel (~15 years :) ) so I have
> > > some difficulties...
> > > Since I have a working kernel from the Linux Mint distributions, I copied
> > > the configuration file in the new kernel directory and I recompiled it.
> > > The problem is that when I'm restarting the kernel does not load some
> > > drivers, hence linux can't find the hard disk and it goes in kernel
> panic.
> > > 
> > > Did I miss anything in the following compiling steps:
> > > 1) Extract kernel in /usr/src
> > > 2) Patch kernel (patch -p1 < <patch file>)
> > > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > > 4) make menuconfig in case of changes (here I didn't change anything for
> > now)
> > > 5) make -j12
> > > 6) make bzImage (it seems required by Linux Mint)
> > > 7) make modules_install
> > > 8) Copy the configuration file back: cp .config /boot/config-5.12.1
> > > 9) make install
> > > 10) update-grub2
> > > 
> > > Did I miss anything?
> > > 
> > > Thanks,
> > > 
> > > Luca
> > 
> > Hi Lorenzo,
> > 
> > I managed somehow to make the new kernel loading and your patch seems
> > working fine since I'm able to suspend and resume my laptop and the driver
> > reloads correctly and connectivity is re-established.
> > 
> > You can proceed to merge the patch to the kernel.
> 
> nice. So you confirm now suspend/resume is fine. Can you please keep testing
> it for a while?
> 
> > 
> > In order to make it working temporarily I had to:
> > 1) append "nomodeset" parameter otherwise the screen is black
> > 2) replace the UUID identifier of my partition with the partition number
> > itself (like /dev/sda4)
> > 3) remove "initrd" line since laptop freezes when loading the image
> > 
> > When I'm installing the kernel I see this issue:
> > ---------------------------------------------------
> > root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
> > sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
> >         System.map "/boot"
> > run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 5.12.1
> > /boot/vmlinuz-5.12.1
> > run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1
> /boot/vmlinuz-5.12.1
> >  * dkms: running auto installation service for kernel 5.12.1                
> > Error!  The /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf for
> > module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> > does not match this kernel/arch.  This indicates that it should not be
> built.
> >                                                                             
> > [ OK ]
> > run-parts: executing /etc/kernel/postinst.d/initramfs-tools 5.12.1
> > /boot/vmlinuz-5.12.1
> > update-initramfs: Generating /boot/initrd.img-5.12.1
> > W: Possible missing firmware /lib/firmware/i915/skl_guc_49.0.1.bin for
> > module i915
> > ...
> > -----------------------------------------------------
> > 
> 
> I am not familiar with mint build system. Is it enough to run make, make
> modules_install; make install or do you need to create the .deb file?
> 
> > Could you please help me to resolve the issues I have in the kernel
> > installation?
> > 
> > Thanks in advance,
> > 
> > Luca

Hi Lorenzo,

I'll keep testing for some days also because I remember I created some scripts to resume from suspend when it was not supported and I need to remove.

Regarding the issue I have with kernel I'll figure out myself thx.

I'll keep you posted, 

thx in advance,

Luca

(In reply to Luca T. from comment #23)
> (In reply to Lorenzo Bianconi from comment #22)
> > (In reply to Luca T. from comment #21)
> > > (In reply to Luca T. from comment #20)
> > > > (In reply to Lorenzo Bianconi from comment #19)
> > > > > (In reply to Luca T. from comment #18)
> > > > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > > > (In reply to Luca T. from comment #16)
> > > > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` ,
> where
> > > > uname
> > > > > > -r
> > > > > > > > > > currently gives 5.8.0-41-generic ; I get this error message
> :
> > > > > > > > > > 
> > > > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > > > /home/matju/src/mt76/agg-rx.c: In function
> > `mt76_rx_aggr_stop':
> > > > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit
> > > declaration
> > > > of
> > > > > > > > > function
> > > > > > > > > > `rcu_swap_protected'
> [-Werror=implicit-function-declaration]
> > > > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > > > Erreur 1
> > > > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > > > > > > > make : on quitte le répertoire «
> > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > »
> > > > > > > > > > 
> > > > > > > > > > I tried removing -Werror from your Makefile, but the
> default
> > > > still
> > > > > > > treats
> > > > > > > > > > this warning as an error, so I added -Wno-error instead,
> > which
> > > > made
> > > > > > no
> > > > > > > > > > difference, I had to write explicitly
> > > > > > > > > > -Wno-error=implicit-function-declaration , but then it
> seems
> > > that
> > > > > > this
> > > > > > > is
> > > > > > > > > > not just a header problem after all, because then I got
> this
> > :
> > > > > > > > > > 
> > > > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > > > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > > > undefined!
> > > > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > > > make[1]: *** Suppression du fichier «
> > > > > > > /home/matju/src/mt76/Module.symvers
> > > > > > > > »
> > > > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > > > make : on quitte le répertoire «
> > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > »
> > > > > > > > > 
> > > > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > > > rcu_swap_protected()
> > > > > > > > > should be defined in mt76.h
> > > > > > > > 
> > > > > > > > Hello Lorenzo, 
> > > > > > > 
> > > > > > > Hi Luca,
> > > > > > > 
> > > > > > > > 
> > > > > > > > is your patch already released in the kernel 5.12.1?
> > > > > > > 
> > > > > > > nope since I have not received any feedback. Are you able to test
> > it?
> > > > (I
> > > > > do
> > > > > > > not have the mt7630e adapter) 
> > > > > > > 
> > > > > > > > 
> > > > > > > > I have also another problem with the MT7630e (besides the one
> > with
> > > > the
> > > > > > > sleep
> > > > > > > > command): sometimes on my laptop the wifi disappears and only
> the
> > > > wire
> > > > > > > > connectivity is present. In order to make it working again I
> need
> > > to
> > > > > > > > hibernate my laptop and power-on it again so that it loads
> again
> > > the
> > > > > > > driver.
> > > > > > > > Do you know what can be the issue and eventually the solution?
> > > > > > > 
> > > > > > > can you please describe when the issue occurs? do you have any
> info
> > > in
> > > > > the
> > > > > > > syslog?
> > > > > > > 
> > > > > > > Regards,
> > > > > > > Lorenzo
> > > > > > > 
> > > > > > > > 
> > > > > > > > Thanks in advance,
> > > > > > > > 
> > > > > > > > Luca T.
> > > > > > 
> > > > > > Hi Lorenzo,
> > > > > > 
> > > > > > yes, I have the hardware to test this patch.
> > > > > > 
> > > > > > I just installed the vanilla version of kernel 5.12.1, can you
> please
> > > > > > provide me the link to the patch?
> > > > > 
> > > > > it is linked in the bz (it has the wrong mt76x0u name)
> > > > > 
> > > > > > 
> > > > > > For the other issue I'll check the journal and provide you
> additional
> > > > > > details soon (unfornately it happens once a day :) so I'll come
> back
> > > > > > quickly).
> > > > > > 
> > > > > > Thanks in advance,
> > > > > > 
> > > > > > Luca
> > > > 
> > > > Hi Lorenzo,
> > > > 
> > > > it's quite a bit of time I'm recompiling kernel (~15 years :) ) so I
> have
> > > > some difficulties...
> > > > Since I have a working kernel from the Linux Mint distributions, I
> copied
> > > > the configuration file in the new kernel directory and I recompiled it.
> > > > The problem is that when I'm restarting the kernel does not load some
> > > > drivers, hence linux can't find the hard disk and it goes in kernel
> > panic.
> > > > 
> > > > Did I miss anything in the following compiling steps:
> > > > 1) Extract kernel in /usr/src
> > > > 2) Patch kernel (patch -p1 < <patch file>)
> > > > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > > > 4) make menuconfig in case of changes (here I didn't change anything
> for
> > > now)
> > > > 5) make -j12
> > > > 6) make bzImage (it seems required by Linux Mint)
> > > > 7) make modules_install
> > > > 8) Copy the configuration file back: cp .config /boot/config-5.12.1
> > > > 9) make install
> > > > 10) update-grub2
> > > > 
> > > > Did I miss anything?
> > > > 
> > > > Thanks,
> > > > 
> > > > Luca
> > > 
> > > Hi Lorenzo,
> > > 
> > > I managed somehow to make the new kernel loading and your patch seems
> > > working fine since I'm able to suspend and resume my laptop and the
> driver
> > > reloads correctly and connectivity is re-established.
> > > 
> > > You can proceed to merge the patch to the kernel.
> > 
> > nice. So you confirm now suspend/resume is fine. Can you please keep
> testing
> > it for a while?
> > 
> > > 
> > > In order to make it working temporarily I had to:
> > > 1) append "nomodeset" parameter otherwise the screen is black
> > > 2) replace the UUID identifier of my partition with the partition number
> > > itself (like /dev/sda4)
> > > 3) remove "initrd" line since laptop freezes when loading the image
> > > 
> > > When I'm installing the kernel I see this issue:
> > > ---------------------------------------------------
> > > root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
> > > sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
> > >         System.map "/boot"
> > > run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 5.12.1
> > > /boot/vmlinuz-5.12.1
> > > run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1
> > /boot/vmlinuz-5.12.1
> > >  * dkms: running auto installation service for kernel 5.12.1              
> > > Error!  The /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf for
> > > module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> > > does not match this kernel/arch.  This indicates that it should not be
> > built.
> > >                                                                           
> > > [ OK ]
> > > run-parts: executing /etc/kernel/postinst.d/initramfs-tools 5.12.1
> > > /boot/vmlinuz-5.12.1
> > > update-initramfs: Generating /boot/initrd.img-5.12.1
> > > W: Possible missing firmware /lib/firmware/i915/skl_guc_49.0.1.bin for
> > > module i915
> > > ...
> > > -----------------------------------------------------
> > > 
> > 
> > I am not familiar with mint build system. Is it enough to run make, make
> > modules_install; make install or do you need to create the .deb file?
> > 
> > > Could you please help me to resolve the issues I have in the kernel
> > > installation?
> > > 
> > > Thanks in advance,
> > > 
> > > Luca
> 
> Hi Lorenzo,
> 
> I'll keep testing for some days also because I remember I created some
> scripts to resume from suspend when it was not supported and I need to
> remove.
> 
> Regarding the issue I have with kernel I'll figure out myself thx.
> 
> I'll keep you posted, 
> 
> thx in advance,
> 
> Luca

Hi Lorenzo,

I removed my workaround for the missing suspend support and in this case your patch does NOT work. On resume the laptop is fully stuck and I need to force it to shutdown manually.

Unfortunately I have no data in syslog... any idea how to address this issue?

Regards,

Luca

(In reply to Lorenzo Bianconi from comment #22)
> (In reply to Luca T. from comment #21)
> > (In reply to Luca T. from comment #20)
> > > (In reply to Lorenzo Bianconi from comment #19)
> > > > (In reply to Luca T. from comment #18)
> > > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > > (In reply to Luca T. from comment #16)
> > > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` , where
> > > uname
> > > > > -r
> > > > > > > > > currently gives 5.8.0-41-generic ; I get this error message :
> > > > > > > > > 
> > > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > > /home/matju/src/mt76/agg-rx.c: In function
> `mt76_rx_aggr_stop':
> > > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit
> > declaration
> > > of
> > > > > > > > function
> > > > > > > > > `rcu_swap_protected' [-Werror=implicit-function-declaration]
> > > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > > Erreur 1
> > > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > > > > > > make : on quitte le répertoire «
> > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > »
> > > > > > > > > 
> > > > > > > > > I tried removing -Werror from your Makefile, but the default
> > > still
> > > > > > treats
> > > > > > > > > this warning as an error, so I added -Wno-error instead,
> which
> > > made
> > > > > no
> > > > > > > > > difference, I had to write explicitly
> > > > > > > > > -Wno-error=implicit-function-declaration , but then it seems
> > that
> > > > > this
> > > > > > is
> > > > > > > > > not just a header problem after all, because then I got this
> :
> > > > > > > > > 
> > > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > > undefined!
> > > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > > make[1]: *** Suppression du fichier «
> > > > > > /home/matju/src/mt76/Module.symvers
> > > > > > > »
> > > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > > make : on quitte le répertoire «
> > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > »
> > > > > > > > 
> > > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > > rcu_swap_protected()
> > > > > > > > should be defined in mt76.h
> > > > > > > 
> > > > > > > Hello Lorenzo, 
> > > > > > 
> > > > > > Hi Luca,
> > > > > > 
> > > > > > > 
> > > > > > > is your patch already released in the kernel 5.12.1?
> > > > > > 
> > > > > > nope since I have not received any feedback. Are you able to test
> it?
> > > (I
> > > > do
> > > > > > not have the mt7630e adapter) 
> > > > > > 
> > > > > > > 
> > > > > > > I have also another problem with the MT7630e (besides the one
> with
> > > the
> > > > > > sleep
> > > > > > > command): sometimes on my laptop the wifi disappears and only the
> > > wire
> > > > > > > connectivity is present. In order to make it working again I need
> > to
> > > > > > > hibernate my laptop and power-on it again so that it loads again
> > the
> > > > > > driver.
> > > > > > > Do you know what can be the issue and eventually the solution?
> > > > > > 
> > > > > > can you please describe when the issue occurs? do you have any info
> > in
> > > > the
> > > > > > syslog?
> > > > > > 
> > > > > > Regards,
> > > > > > Lorenzo
> > > > > > 
> > > > > > > 
> > > > > > > Thanks in advance,
> > > > > > > 
> > > > > > > Luca T.
> > > > > 
> > > > > Hi Lorenzo,
> > > > > 
> > > > > yes, I have the hardware to test this patch.
> > > > > 
> > > > > I just installed the vanilla version of kernel 5.12.1, can you please
> > > > > provide me the link to the patch?
> > > > 
> > > > it is linked in the bz (it has the wrong mt76x0u name)
> > > > 
> > > > > 
> > > > > For the other issue I'll check the journal and provide you additional
> > > > > details soon (unfornately it happens once a day :) so I'll come back
> > > > > quickly).
> > > > > 
> > > > > Thanks in advance,
> > > > > 
> > > > > Luca
> > > 
> > > Hi Lorenzo,
> > > 
> > > it's quite a bit of time I'm recompiling kernel (~15 years :) ) so I have
> > > some difficulties...
> > > Since I have a working kernel from the Linux Mint distributions, I copied
> > > the configuration file in the new kernel directory and I recompiled it.
> > > The problem is that when I'm restarting the kernel does not load some
> > > drivers, hence linux can't find the hard disk and it goes in kernel
> panic.
> > > 
> > > Did I miss anything in the following compiling steps:
> > > 1) Extract kernel in /usr/src
> > > 2) Patch kernel (patch -p1 < <patch file>)
> > > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > > 4) make menuconfig in case of changes (here I didn't change anything for
> > now)
> > > 5) make -j12
> > > 6) make bzImage (it seems required by Linux Mint)
> > > 7) make modules_install
> > > 8) Copy the configuration file back: cp .config /boot/config-5.12.1
> > > 9) make install
> > > 10) update-grub2
> > > 
> > > Did I miss anything?
> > > 
> > > Thanks,
> > > 
> > > Luca
> > 
> > Hi Lorenzo,
> > 
> > I managed somehow to make the new kernel loading and your patch seems
> > working fine since I'm able to suspend and resume my laptop and the driver
> > reloads correctly and connectivity is re-established.
> > 
> > You can proceed to merge the patch to the kernel.
> 
> nice. So you confirm now suspend/resume is fine. Can you please keep testing
> it for a while?
> 
> > 
> > In order to make it working temporarily I had to:
> > 1) append "nomodeset" parameter otherwise the screen is black
> > 2) replace the UUID identifier of my partition with the partition number
> > itself (like /dev/sda4)
> > 3) remove "initrd" line since laptop freezes when loading the image
> > 
> > When I'm installing the kernel I see this issue:
> > ---------------------------------------------------
> > root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
> > sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
> >         System.map "/boot"
> > run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 5.12.1
> > /boot/vmlinuz-5.12.1
> > run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1
> /boot/vmlinuz-5.12.1
> >  * dkms: running auto installation service for kernel 5.12.1                
> > Error!  The /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf for
> > module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> > does not match this kernel/arch.  This indicates that it should not be
> built.
> >                                                                             
> > [ OK ]
> > run-parts: executing /etc/kernel/postinst.d/initramfs-tools 5.12.1
> > /boot/vmlinuz-5.12.1
> > update-initramfs: Generating /boot/initrd.img-5.12.1
> > W: Possible missing firmware /lib/firmware/i915/skl_guc_49.0.1.bin for
> > module i915
> > ...
> > -----------------------------------------------------
> > 
> 
> I am not familiar with mint build system. Is it enough to run make, make
> modules_install; make install or do you need to create the .deb file?
> 
> > Could you please help me to resolve the issues I have in the kernel
> > installation?
> > 
> > Thanks in advance,
> > 
> > Luca

Hi Lorenzo,

sorry for bothering you, I continued today to make some tests.

I isolated the problem where the laptop got stuck after resume: I disabled the graphical UI since I discovered that the radeon card has a bug in the kernel :(

During my test I suspended linux in text mode and I successfully resumed the laptop, the wifi, and the connectivity: everything works correctly without any "magic script" from my side.

I just noticed that a message appeared after resuming wifi:

mt76x0e 0000:04:00.0: driver does not support HW RF ctrl

What do you think?

Thanks,

Luca

(In reply to Luca T. from comment #25)
> (In reply to Lorenzo Bianconi from comment #22)
> > (In reply to Luca T. from comment #21)
> > > (In reply to Luca T. from comment #20)
> > > > (In reply to Lorenzo Bianconi from comment #19)
> > > > > (In reply to Luca T. from comment #18)
> > > > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > > > (In reply to Luca T. from comment #16)
> > > > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` ,
> where
> > > > uname
> > > > > > -r
> > > > > > > > > > currently gives 5.8.0-41-generic ; I get this error message
> :
> > > > > > > > > > 
> > > > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > > > /home/matju/src/mt76/agg-rx.c: In function
> > `mt76_rx_aggr_stop':
> > > > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit
> > > declaration
> > > > of
> > > > > > > > > function
> > > > > > > > > > `rcu_swap_protected'
> [-Werror=implicit-function-declaration]
> > > > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > > > Erreur 1
> > > > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > > > > > > > make : on quitte le répertoire «
> > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > »
> > > > > > > > > > 
> > > > > > > > > > I tried removing -Werror from your Makefile, but the
> default
> > > > still
> > > > > > > treats
> > > > > > > > > > this warning as an error, so I added -Wno-error instead,
> > which
> > > > made
> > > > > > no
> > > > > > > > > > difference, I had to write explicitly
> > > > > > > > > > -Wno-error=implicit-function-declaration , but then it
> seems
> > > that
> > > > > > this
> > > > > > > is
> > > > > > > > > > not just a header problem after all, because then I got
> this
> > :
> > > > > > > > > > 
> > > > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > > > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > > > undefined!
> > > > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > > > make[1]: *** Suppression du fichier «
> > > > > > > /home/matju/src/mt76/Module.symvers
> > > > > > > > »
> > > > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > > > make : on quitte le répertoire «
> > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > »
> > > > > > > > > 
> > > > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > > > rcu_swap_protected()
> > > > > > > > > should be defined in mt76.h
> > > > > > > > 
> > > > > > > > Hello Lorenzo, 
> > > > > > > 
> > > > > > > Hi Luca,
> > > > > > > 
> > > > > > > > 
> > > > > > > > is your patch already released in the kernel 5.12.1?
> > > > > > > 
> > > > > > > nope since I have not received any feedback. Are you able to test
> > it?
> > > > (I
> > > > > do
> > > > > > > not have the mt7630e adapter) 
> > > > > > > 
> > > > > > > > 
> > > > > > > > I have also another problem with the MT7630e (besides the one
> > with
> > > > the
> > > > > > > sleep
> > > > > > > > command): sometimes on my laptop the wifi disappears and only
> the
> > > > wire
> > > > > > > > connectivity is present. In order to make it working again I
> need
> > > to
> > > > > > > > hibernate my laptop and power-on it again so that it loads
> again
> > > the
> > > > > > > driver.
> > > > > > > > Do you know what can be the issue and eventually the solution?
> > > > > > > 
> > > > > > > can you please describe when the issue occurs? do you have any
> info
> > > in
> > > > > the
> > > > > > > syslog?
> > > > > > > 
> > > > > > > Regards,
> > > > > > > Lorenzo
> > > > > > > 
> > > > > > > > 
> > > > > > > > Thanks in advance,
> > > > > > > > 
> > > > > > > > Luca T.
> > > > > > 
> > > > > > Hi Lorenzo,
> > > > > > 
> > > > > > yes, I have the hardware to test this patch.
> > > > > > 
> > > > > > I just installed the vanilla version of kernel 5.12.1, can you
> please
> > > > > > provide me the link to the patch?
> > > > > 
> > > > > it is linked in the bz (it has the wrong mt76x0u name)
> > > > > 
> > > > > > 
> > > > > > For the other issue I'll check the journal and provide you
> additional
> > > > > > details soon (unfornately it happens once a day :) so I'll come
> back
> > > > > > quickly).
> > > > > > 
> > > > > > Thanks in advance,
> > > > > > 
> > > > > > Luca
> > > > 
> > > > Hi Lorenzo,
> > > > 
> > > > it's quite a bit of time I'm recompiling kernel (~15 years :) ) so I
> have
> > > > some difficulties...
> > > > Since I have a working kernel from the Linux Mint distributions, I
> copied
> > > > the configuration file in the new kernel directory and I recompiled it.
> > > > The problem is that when I'm restarting the kernel does not load some
> > > > drivers, hence linux can't find the hard disk and it goes in kernel
> > panic.
> > > > 
> > > > Did I miss anything in the following compiling steps:
> > > > 1) Extract kernel in /usr/src
> > > > 2) Patch kernel (patch -p1 < <patch file>)
> > > > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > > > 4) make menuconfig in case of changes (here I didn't change anything
> for
> > > now)
> > > > 5) make -j12
> > > > 6) make bzImage (it seems required by Linux Mint)
> > > > 7) make modules_install
> > > > 8) Copy the configuration file back: cp .config /boot/config-5.12.1
> > > > 9) make install
> > > > 10) update-grub2
> > > > 
> > > > Did I miss anything?
> > > > 
> > > > Thanks,
> > > > 
> > > > Luca
> > > 
> > > Hi Lorenzo,
> > > 
> > > I managed somehow to make the new kernel loading and your patch seems
> > > working fine since I'm able to suspend and resume my laptop and the
> driver
> > > reloads correctly and connectivity is re-established.
> > > 
> > > You can proceed to merge the patch to the kernel.
> > 
> > nice. So you confirm now suspend/resume is fine. Can you please keep
> testing
> > it for a while?
> > 
> > > 
> > > In order to make it working temporarily I had to:
> > > 1) append "nomodeset" parameter otherwise the screen is black
> > > 2) replace the UUID identifier of my partition with the partition number
> > > itself (like /dev/sda4)
> > > 3) remove "initrd" line since laptop freezes when loading the image
> > > 
> > > When I'm installing the kernel I see this issue:
> > > ---------------------------------------------------
> > > root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
> > > sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
> > >         System.map "/boot"
> > > run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 5.12.1
> > > /boot/vmlinuz-5.12.1
> > > run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1
> > /boot/vmlinuz-5.12.1
> > >  * dkms: running auto installation service for kernel 5.12.1              
> > > Error!  The /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf for
> > > module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> > > does not match this kernel/arch.  This indicates that it should not be
> > built.
> > >                                                                           
> > > [ OK ]
> > > run-parts: executing /etc/kernel/postinst.d/initramfs-tools 5.12.1
> > > /boot/vmlinuz-5.12.1
> > > update-initramfs: Generating /boot/initrd.img-5.12.1
> > > W: Possible missing firmware /lib/firmware/i915/skl_guc_49.0.1.bin for
> > > module i915
> > > ...
> > > -----------------------------------------------------
> > > 
> > 
> > I am not familiar with mint build system. Is it enough to run make, make
> > modules_install; make install or do you need to create the .deb file?
> > 
> > > Could you please help me to resolve the issues I have in the kernel
> > > installation?
> > > 
> > > Thanks in advance,
> > > 
> > > Luca
> 
> Hi Lorenzo,
> 
> sorry for bothering you, I continued today to make some tests.
> 
> I isolated the problem where the laptop got stuck after resume: I disabled
> the graphical UI since I discovered that the radeon card has a bug in the
> kernel :(
> 
> During my test I suspended linux in text mode and I successfully resumed the
> laptop, the wifi, and the connectivity: everything works correctly without
> any "magic script" from my side.

ok, thx for sharing. Can you please confirm my patch is not necessary?

> 
> I just noticed that a message appeared after resuming wifi:
> 
> mt76x0e 0000:04:00.0: driver does not support HW RF ctrl
> 
> What do you think?

this means the radio is controlled in sw, this is info harmful (probably it is enough dev_info instead of dev_err)

Lorenzo

> 
> Thanks,
> 
> Luca

(In reply to Lorenzo Bianconi from comment #26)
> (In reply to Luca T. from comment #25)
> > (In reply to Lorenzo Bianconi from comment #22)
> > > (In reply to Luca T. from comment #21)
> > > > (In reply to Luca T. from comment #20)
> > > > > (In reply to Lorenzo Bianconi from comment #19)
> > > > > > (In reply to Luca T. from comment #18)
> > > > > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > > > > (In reply to Luca T. from comment #16)
> > > > > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` ,
> > where
> > > > > uname
> > > > > > > -r
> > > > > > > > > > > currently gives 5.8.0-41-generic ; I get this error
> message
> > :
> > > > > > > > > > > 
> > > > > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > > > > /home/matju/src/mt76/agg-rx.c: In function
> > > `mt76_rx_aggr_stop':
> > > > > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit
> > > > declaration
> > > > > of
> > > > > > > > > > function
> > > > > > > > > > > `rcu_swap_protected'
> > [-Werror=implicit-function-declaration]
> > > > > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > > > > Erreur 1
> > > > > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur 2
> > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > »
> > > > > > > > > > > 
> > > > > > > > > > > I tried removing -Werror from your Makefile, but the
> > default
> > > > > still
> > > > > > > > treats
> > > > > > > > > > > this warning as an error, so I added -Wno-error instead,
> > > which
> > > > > made
> > > > > > > no
> > > > > > > > > > > difference, I had to write explicitly
> > > > > > > > > > > -Wno-error=implicit-function-declaration , but then it
> > seems
> > > > that
> > > > > > > this
> > > > > > > > is
> > > > > > > > > > > not just a header problem after all, because then I got
> > this
> > > :
> > > > > > > > > > > 
> > > > > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > > > > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > > > > undefined!
> > > > > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > > > > make[1]: *** Suppression du fichier «
> > > > > > > > /home/matju/src/mt76/Module.symvers
> > > > > > > > > »
> > > > > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > »
> > > > > > > > > > 
> > > > > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > > > > rcu_swap_protected()
> > > > > > > > > > should be defined in mt76.h
> > > > > > > > > 
> > > > > > > > > Hello Lorenzo, 
> > > > > > > > 
> > > > > > > > Hi Luca,
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > is your patch already released in the kernel 5.12.1?
> > > > > > > > 
> > > > > > > > nope since I have not received any feedback. Are you able to
> test
> > > it?
> > > > > (I
> > > > > > do
> > > > > > > > not have the mt7630e adapter) 
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > I have also another problem with the MT7630e (besides the one
> > > with
> > > > > the
> > > > > > > > sleep
> > > > > > > > > command): sometimes on my laptop the wifi disappears and only
> > the
> > > > > wire
> > > > > > > > > connectivity is present. In order to make it working again I
> > need
> > > > to
> > > > > > > > > hibernate my laptop and power-on it again so that it loads
> > again
> > > > the
> > > > > > > > driver.
> > > > > > > > > Do you know what can be the issue and eventually the
> solution?
> > > > > > > > 
> > > > > > > > can you please describe when the issue occurs? do you have any
> > info
> > > > in
> > > > > > the
> > > > > > > > syslog?
> > > > > > > > 
> > > > > > > > Regards,
> > > > > > > > Lorenzo
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > Thanks in advance,
> > > > > > > > > 
> > > > > > > > > Luca T.
> > > > > > > 
> > > > > > > Hi Lorenzo,
> > > > > > > 
> > > > > > > yes, I have the hardware to test this patch.
> > > > > > > 
> > > > > > > I just installed the vanilla version of kernel 5.12.1, can you
> > please
> > > > > > > provide me the link to the patch?
> > > > > > 
> > > > > > it is linked in the bz (it has the wrong mt76x0u name)
> > > > > > 
> > > > > > > 
> > > > > > > For the other issue I'll check the journal and provide you
> > additional
> > > > > > > details soon (unfornately it happens once a day :) so I'll come
> > back
> > > > > > > quickly).
> > > > > > > 
> > > > > > > Thanks in advance,
> > > > > > > 
> > > > > > > Luca
> > > > > 
> > > > > Hi Lorenzo,
> > > > > 
> > > > > it's quite a bit of time I'm recompiling kernel (~15 years :) ) so I
> > have
> > > > > some difficulties...
> > > > > Since I have a working kernel from the Linux Mint distributions, I
> > copied
> > > > > the configuration file in the new kernel directory and I recompiled
> it.
> > > > > The problem is that when I'm restarting the kernel does not load some
> > > > > drivers, hence linux can't find the hard disk and it goes in kernel
> > > panic.
> > > > > 
> > > > > Did I miss anything in the following compiling steps:
> > > > > 1) Extract kernel in /usr/src
> > > > > 2) Patch kernel (patch -p1 < <patch file>)
> > > > > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > > > > 4) make menuconfig in case of changes (here I didn't change anything
> > for
> > > > now)
> > > > > 5) make -j12
> > > > > 6) make bzImage (it seems required by Linux Mint)
> > > > > 7) make modules_install
> > > > > 8) Copy the configuration file back: cp .config /boot/config-5.12.1
> > > > > 9) make install
> > > > > 10) update-grub2
> > > > > 
> > > > > Did I miss anything?
> > > > > 
> > > > > Thanks,
> > > > > 
> > > > > Luca
> > > > 
> > > > Hi Lorenzo,
> > > > 
> > > > I managed somehow to make the new kernel loading and your patch seems
> > > > working fine since I'm able to suspend and resume my laptop and the
> > driver
> > > > reloads correctly and connectivity is re-established.
> > > > 
> > > > You can proceed to merge the patch to the kernel.
> > > 
> > > nice. So you confirm now suspend/resume is fine. Can you please keep
> > testing
> > > it for a while?
> > > 
> > > > 
> > > > In order to make it working temporarily I had to:
> > > > 1) append "nomodeset" parameter otherwise the screen is black
> > > > 2) replace the UUID identifier of my partition with the partition
> number
> > > > itself (like /dev/sda4)
> > > > 3) remove "initrd" line since laptop freezes when loading the image
> > > > 
> > > > When I'm installing the kernel I see this issue:
> > > > ---------------------------------------------------
> > > > root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
> > > > sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
> > > >         System.map "/boot"
> > > > run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 5.12.1
> > > > /boot/vmlinuz-5.12.1
> > > > run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1
> > > /boot/vmlinuz-5.12.1
> > > >  * dkms: running auto installation service for kernel 5.12.1            
> > > > Error!  The /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf for
> > > > module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> > > > does not match this kernel/arch.  This indicates that it should not be
> > > built.
> > > >                                                                         
> > > > [ OK ]
> > > > run-parts: executing /etc/kernel/postinst.d/initramfs-tools 5.12.1
> > > > /boot/vmlinuz-5.12.1
> > > > update-initramfs: Generating /boot/initrd.img-5.12.1
> > > > W: Possible missing firmware /lib/firmware/i915/skl_guc_49.0.1.bin for
> > > > module i915
> > > > ...
> > > > -----------------------------------------------------
> > > > 
> > > 
> > > I am not familiar with mint build system. Is it enough to run make, make
> > > modules_install; make install or do you need to create the .deb file?
> > > 
> > > > Could you please help me to resolve the issues I have in the kernel
> > > > installation?
> > > > 
> > > > Thanks in advance,
> > > > 
> > > > Luca
> > 
> > Hi Lorenzo,
> > 
> > sorry for bothering you, I continued today to make some tests.
> > 
> > I isolated the problem where the laptop got stuck after resume: I disabled
> > the graphical UI since I discovered that the radeon card has a bug in the
> > kernel :(
> > 
> > During my test I suspended linux in text mode and I successfully resumed
> the
> > laptop, the wifi, and the connectivity: everything works correctly without
> > any "magic script" from my side.
> 
> ok, thx for sharing. Can you please confirm my patch is not necessary?
> 
> > 
> > I just noticed that a message appeared after resuming wifi:
> > 
> > mt76x0e 0000:04:00.0: driver does not support HW RF ctrl
> > 
> > What do you think?
> 
> this means the radio is controlled in sw, this is info harmful (probably it
> is enough dev_info instead of dev_err)
> 
> Lorenzo
> 
> > 
> > Thanks,
> > 
> > Luca

Hi Lorenzo,

your patch is definitely required.

Thanks,

Luca

(In reply to Luca T. from comment #27)
> (In reply to Lorenzo Bianconi from comment #26)
> > (In reply to Luca T. from comment #25)
> > > (In reply to Lorenzo Bianconi from comment #22)
> > > > (In reply to Luca T. from comment #21)
> > > > > (In reply to Luca T. from comment #20)
> > > > > > (In reply to Lorenzo Bianconi from comment #19)
> > > > > > > (In reply to Luca T. from comment #18)
> > > > > > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > > > > > (In reply to Luca T. from comment #16)
> > > > > > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD` ,
> > > where
> > > > > > uname
> > > > > > > > -r
> > > > > > > > > > > > currently gives 5.8.0-41-generic ; I get this error
> > message
> > > :
> > > > > > > > > > > > 
> > > > > > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > > > > > /home/matju/src/mt76/agg-rx.c: In function
> > > > `mt76_rx_aggr_stop':
> > > > > > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit
> > > > > declaration
> > > > > > of
> > > > > > > > > > > function
> > > > > > > > > > > > `rcu_swap_protected'
> > > [-Werror=implicit-function-declaration]
> > > > > > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > > > > > Erreur 1
> > > > > > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76] Erreur
> 2
> > > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > > »
> > > > > > > > > > > > 
> > > > > > > > > > > > I tried removing -Werror from your Makefile, but the
> > > default
> > > > > > still
> > > > > > > > > treats
> > > > > > > > > > > > this warning as an error, so I added -Wno-error
> instead,
> > > > which
> > > > > > made
> > > > > > > > no
> > > > > > > > > > > > difference, I had to write explicitly
> > > > > > > > > > > > -Wno-error=implicit-function-declaration , but then it
> > > seems
> > > > > that
> > > > > > > > this
> > > > > > > > > is
> > > > > > > > > > > > not just a header problem after all, because then I got
> > > this
> > > > :
> > > > > > > > > > > > 
> > > > > > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > > > > > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > > > > > undefined!
> > > > > > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > > > > > make[1]: *** Suppression du fichier «
> > > > > > > > > /home/matju/src/mt76/Module.symvers
> > > > > > > > > > »
> > > > > > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > > »
> > > > > > > > > > > 
> > > > > > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > > > > > rcu_swap_protected()
> > > > > > > > > > > should be defined in mt76.h
> > > > > > > > > > 
> > > > > > > > > > Hello Lorenzo, 
> > > > > > > > > 
> > > > > > > > > Hi Luca,
> > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > is your patch already released in the kernel 5.12.1?
> > > > > > > > > 
> > > > > > > > > nope since I have not received any feedback. Are you able to
> > test
> > > > it?
> > > > > > (I
> > > > > > > do
> > > > > > > > > not have the mt7630e adapter) 
> > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > I have also another problem with the MT7630e (besides the
> one
> > > > with
> > > > > > the
> > > > > > > > > sleep
> > > > > > > > > > command): sometimes on my laptop the wifi disappears and
> only
> > > the
> > > > > > wire
> > > > > > > > > > connectivity is present. In order to make it working again
> I
> > > need
> > > > > to
> > > > > > > > > > hibernate my laptop and power-on it again so that it loads
> > > again
> > > > > the
> > > > > > > > > driver.
> > > > > > > > > > Do you know what can be the issue and eventually the
> > solution?
> > > > > > > > > 
> > > > > > > > > can you please describe when the issue occurs? do you have
> any
> > > info
> > > > > in
> > > > > > > the
> > > > > > > > > syslog?
> > > > > > > > > 
> > > > > > > > > Regards,
> > > > > > > > > Lorenzo
> > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > Thanks in advance,
> > > > > > > > > > 
> > > > > > > > > > Luca T.
> > > > > > > > 
> > > > > > > > Hi Lorenzo,
> > > > > > > > 
> > > > > > > > yes, I have the hardware to test this patch.
> > > > > > > > 
> > > > > > > > I just installed the vanilla version of kernel 5.12.1, can you
> > > please
> > > > > > > > provide me the link to the patch?
> > > > > > > 
> > > > > > > it is linked in the bz (it has the wrong mt76x0u name)
> > > > > > > 
> > > > > > > > 
> > > > > > > > For the other issue I'll check the journal and provide you
> > > additional
> > > > > > > > details soon (unfornately it happens once a day :) so I'll come
> > > back
> > > > > > > > quickly).
> > > > > > > > 
> > > > > > > > Thanks in advance,
> > > > > > > > 
> > > > > > > > Luca
> > > > > > 
> > > > > > Hi Lorenzo,
> > > > > > 
> > > > > > it's quite a bit of time I'm recompiling kernel (~15 years :) ) so
> I
> > > have
> > > > > > some difficulties...
> > > > > > Since I have a working kernel from the Linux Mint distributions, I
> > > copied
> > > > > > the configuration file in the new kernel directory and I recompiled
> > it.
> > > > > > The problem is that when I'm restarting the kernel does not load
> some
> > > > > > drivers, hence linux can't find the hard disk and it goes in kernel
> > > > panic.
> > > > > > 
> > > > > > Did I miss anything in the following compiling steps:
> > > > > > 1) Extract kernel in /usr/src
> > > > > > 2) Patch kernel (patch -p1 < <patch file>)
> > > > > > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > > > > > 4) make menuconfig in case of changes (here I didn't change
> anything
> > > for
> > > > > now)
> > > > > > 5) make -j12
> > > > > > 6) make bzImage (it seems required by Linux Mint)
> > > > > > 7) make modules_install
> > > > > > 8) Copy the configuration file back: cp .config /boot/config-5.12.1
> > > > > > 9) make install
> > > > > > 10) update-grub2
> > > > > > 
> > > > > > Did I miss anything?
> > > > > > 
> > > > > > Thanks,
> > > > > > 
> > > > > > Luca
> > > > > 
> > > > > Hi Lorenzo,
> > > > > 
> > > > > I managed somehow to make the new kernel loading and your patch seems
> > > > > working fine since I'm able to suspend and resume my laptop and the
> > > driver
> > > > > reloads correctly and connectivity is re-established.
> > > > > 
> > > > > You can proceed to merge the patch to the kernel.
> > > > 
> > > > nice. So you confirm now suspend/resume is fine. Can you please keep
> > > testing
> > > > it for a while?
> > > > 
> > > > > 
> > > > > In order to make it working temporarily I had to:
> > > > > 1) append "nomodeset" parameter otherwise the screen is black
> > > > > 2) replace the UUID identifier of my partition with the partition
> > number
> > > > > itself (like /dev/sda4)
> > > > > 3) remove "initrd" line since laptop freezes when loading the image
> > > > > 
> > > > > When I'm installing the kernel I see this issue:
> > > > > ---------------------------------------------------
> > > > > root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
> > > > > sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
> > > > >         System.map "/boot"
> > > > > run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 5.12.1
> > > > > /boot/vmlinuz-5.12.1
> > > > > run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1
> > > > /boot/vmlinuz-5.12.1
> > > > >  * dkms: running auto installation service for kernel 5.12.1          
> > > > > Error!  The /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf
> for
> > > > > module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> > > > > does not match this kernel/arch.  This indicates that it should not
> be
> > > > built.
> > > > >                                                                       
> > > > > [ OK ]
> > > > > run-parts: executing /etc/kernel/postinst.d/initramfs-tools 5.12.1
> > > > > /boot/vmlinuz-5.12.1
> > > > > update-initramfs: Generating /boot/initrd.img-5.12.1
> > > > > W: Possible missing firmware /lib/firmware/i915/skl_guc_49.0.1.bin
> for
> > > > > module i915
> > > > > ...
> > > > > -----------------------------------------------------
> > > > > 
> > > > 
> > > > I am not familiar with mint build system. Is it enough to run make,
> make
> > > > modules_install; make install or do you need to create the .deb file?
> > > > 
> > > > > Could you please help me to resolve the issues I have in the kernel
> > > > > installation?
> > > > > 
> > > > > Thanks in advance,
> > > > > 
> > > > > Luca
> > > 
> > > Hi Lorenzo,
> > > 
> > > sorry for bothering you, I continued today to make some tests.
> > > 
> > > I isolated the problem where the laptop got stuck after resume: I
> disabled
> > > the graphical UI since I discovered that the radeon card has a bug in the
> > > kernel :(
> > > 
> > > During my test I suspended linux in text mode and I successfully resumed
> > the
> > > laptop, the wifi, and the connectivity: everything works correctly
> without
> > > any "magic script" from my side.
> > 
> > ok, thx for sharing. Can you please confirm my patch is not necessary?
> > 
> > > 
> > > I just noticed that a message appeared after resuming wifi:
> > > 
> > > mt76x0e 0000:04:00.0: driver does not support HW RF ctrl
> > > 
> > > What do you think?
> > 
> > this means the radio is controlled in sw, this is info harmful (probably it
> > is enough dev_info instead of dev_err)
> > 
> > Lorenzo
> > 
> > > 
> > > Thanks,
> > > 
> > > Luca
> 
> Hi Lorenzo,
> 
> your patch is definitely required.
> 
> Thanks,
> 
> Luca

ok, so you confirm without my patch the suspend/resume process fails on mt76x0e?
Can you please keep testing it?

(In reply to Lorenzo Bianconi from comment #28)
> (In reply to Luca T. from comment #27)
> > (In reply to Lorenzo Bianconi from comment #26)
> > > (In reply to Luca T. from comment #25)
> > > > (In reply to Lorenzo Bianconi from comment #22)
> > > > > (In reply to Luca T. from comment #21)
> > > > > > (In reply to Luca T. from comment #20)
> > > > > > > (In reply to Lorenzo Bianconi from comment #19)
> > > > > > > > (In reply to Luca T. from comment #18)
> > > > > > > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > > > > > > (In reply to Luca T. from comment #16)
> > > > > > > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build M=$PWD`
> ,
> > > > where
> > > > > > > uname
> > > > > > > > > -r
> > > > > > > > > > > > > currently gives 5.8.0-41-generic ; I get this error
> > > message
> > > > :
> > > > > > > > > > > > > 
> > > > > > > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > > > > > > /home/matju/src/mt76/agg-rx.c: In function
> > > > > `mt76_rx_aggr_stop':
> > > > > > > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error: implicit
> > > > > > declaration
> > > > > > > of
> > > > > > > > > > > > function
> > > > > > > > > > > > > `rcu_swap_protected'
> > > > [-Werror=implicit-function-declaration]
> > > > > > > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > > > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > > > > > > Erreur 1
> > > > > > > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76]
> Erreur
> > 2
> > > > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > > > »
> > > > > > > > > > > > > 
> > > > > > > > > > > > > I tried removing -Werror from your Makefile, but the
> > > > default
> > > > > > > still
> > > > > > > > > > treats
> > > > > > > > > > > > > this warning as an error, so I added -Wno-error
> > instead,
> > > > > which
> > > > > > > made
> > > > > > > > > no
> > > > > > > > > > > > > difference, I had to write explicitly
> > > > > > > > > > > > > -Wno-error=implicit-function-declaration , but then
> it
> > > > seems
> > > > > > that
> > > > > > > > > this
> > > > > > > > > > is
> > > > > > > > > > > > > not just a header problem after all, because then I
> got
> > > > this
> > > > > :
> > > > > > > > > > > > > 
> > > > > > > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > > > > > > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > > > > > > undefined!
> > > > > > > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > > > > > > make[1]: *** Suppression du fichier «
> > > > > > > > > > /home/matju/src/mt76/Module.symvers
> > > > > > > > > > > »
> > > > > > > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > > > »
> > > > > > > > > > > > 
> > > > > > > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > > > > > > rcu_swap_protected()
> > > > > > > > > > > > should be defined in mt76.h
> > > > > > > > > > > 
> > > > > > > > > > > Hello Lorenzo, 
> > > > > > > > > > 
> > > > > > > > > > Hi Luca,
> > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > is your patch already released in the kernel 5.12.1?
> > > > > > > > > > 
> > > > > > > > > > nope since I have not received any feedback. Are you able
> to
> > > test
> > > > > it?
> > > > > > > (I
> > > > > > > > do
> > > > > > > > > > not have the mt7630e adapter) 
> > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > I have also another problem with the MT7630e (besides the
> > one
> > > > > with
> > > > > > > the
> > > > > > > > > > sleep
> > > > > > > > > > > command): sometimes on my laptop the wifi disappears and
> > only
> > > > the
> > > > > > > wire
> > > > > > > > > > > connectivity is present. In order to make it working
> again
> > I
> > > > need
> > > > > > to
> > > > > > > > > > > hibernate my laptop and power-on it again so that it
> loads
> > > > again
> > > > > > the
> > > > > > > > > > driver.
> > > > > > > > > > > Do you know what can be the issue and eventually the
> > > solution?
> > > > > > > > > > 
> > > > > > > > > > can you please describe when the issue occurs? do you have
> > any
> > > > info
> > > > > > in
> > > > > > > > the
> > > > > > > > > > syslog?
> > > > > > > > > > 
> > > > > > > > > > Regards,
> > > > > > > > > > Lorenzo
> > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > Thanks in advance,
> > > > > > > > > > > 
> > > > > > > > > > > Luca T.
> > > > > > > > > 
> > > > > > > > > Hi Lorenzo,
> > > > > > > > > 
> > > > > > > > > yes, I have the hardware to test this patch.
> > > > > > > > > 
> > > > > > > > > I just installed the vanilla version of kernel 5.12.1, can
> you
> > > > please
> > > > > > > > > provide me the link to the patch?
> > > > > > > > 
> > > > > > > > it is linked in the bz (it has the wrong mt76x0u name)
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > For the other issue I'll check the journal and provide you
> > > > additional
> > > > > > > > > details soon (unfornately it happens once a day :) so I'll
> come
> > > > back
> > > > > > > > > quickly).
> > > > > > > > > 
> > > > > > > > > Thanks in advance,
> > > > > > > > > 
> > > > > > > > > Luca
> > > > > > > 
> > > > > > > Hi Lorenzo,
> > > > > > > 
> > > > > > > it's quite a bit of time I'm recompiling kernel (~15 years :) )
> so
> > I
> > > > have
> > > > > > > some difficulties...
> > > > > > > Since I have a working kernel from the Linux Mint distributions,
> I
> > > > copied
> > > > > > > the configuration file in the new kernel directory and I
> recompiled
> > > it.
> > > > > > > The problem is that when I'm restarting the kernel does not load
> > some
> > > > > > > drivers, hence linux can't find the hard disk and it goes in
> kernel
> > > > > panic.
> > > > > > > 
> > > > > > > Did I miss anything in the following compiling steps:
> > > > > > > 1) Extract kernel in /usr/src
> > > > > > > 2) Patch kernel (patch -p1 < <patch file>)
> > > > > > > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > > > > > > 4) make menuconfig in case of changes (here I didn't change
> > anything
> > > > for
> > > > > > now)
> > > > > > > 5) make -j12
> > > > > > > 6) make bzImage (it seems required by Linux Mint)
> > > > > > > 7) make modules_install
> > > > > > > 8) Copy the configuration file back: cp .config
> /boot/config-5.12.1
> > > > > > > 9) make install
> > > > > > > 10) update-grub2
> > > > > > > 
> > > > > > > Did I miss anything?
> > > > > > > 
> > > > > > > Thanks,
> > > > > > > 
> > > > > > > Luca
> > > > > > 
> > > > > > Hi Lorenzo,
> > > > > > 
> > > > > > I managed somehow to make the new kernel loading and your patch
> seems
> > > > > > working fine since I'm able to suspend and resume my laptop and the
> > > > driver
> > > > > > reloads correctly and connectivity is re-established.
> > > > > > 
> > > > > > You can proceed to merge the patch to the kernel.
> > > > > 
> > > > > nice. So you confirm now suspend/resume is fine. Can you please keep
> > > > testing
> > > > > it for a while?
> > > > > 
> > > > > > 
> > > > > > In order to make it working temporarily I had to:
> > > > > > 1) append "nomodeset" parameter otherwise the screen is black
> > > > > > 2) replace the UUID identifier of my partition with the partition
> > > number
> > > > > > itself (like /dev/sda4)
> > > > > > 3) remove "initrd" line since laptop freezes when loading the image
> > > > > > 
> > > > > > When I'm installing the kernel I see this issue:
> > > > > > ---------------------------------------------------
> > > > > > root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
> > > > > > sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
> > > > > >         System.map "/boot"
> > > > > > run-parts: executing /etc/kernel/postinst.d/apt-auto-removal 5.12.1
> > > > > > /boot/vmlinuz-5.12.1
> > > > > > run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1
> > > > > /boot/vmlinuz-5.12.1
> > > > > >  * dkms: running auto installation service for kernel 5.12.1        
> > > > > > Error!  The /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf
> > for
> > > > > > module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> > > > > > does not match this kernel/arch.  This indicates that it should not
> > be
> > > > > built.
> > > > > >                                                                     
> > > > > > [ OK ]
> > > > > > run-parts: executing /etc/kernel/postinst.d/initramfs-tools 5.12.1
> > > > > > /boot/vmlinuz-5.12.1
> > > > > > update-initramfs: Generating /boot/initrd.img-5.12.1
> > > > > > W: Possible missing firmware /lib/firmware/i915/skl_guc_49.0.1.bin
> > for
> > > > > > module i915
> > > > > > ...
> > > > > > -----------------------------------------------------
> > > > > > 
> > > > > 
> > > > > I am not familiar with mint build system. Is it enough to run make,
> > make
> > > > > modules_install; make install or do you need to create the .deb file?
> > > > > 
> > > > > > Could you please help me to resolve the issues I have in the kernel
> > > > > > installation?
> > > > > > 
> > > > > > Thanks in advance,
> > > > > > 
> > > > > > Luca
> > > > 
> > > > Hi Lorenzo,
> > > > 
> > > > sorry for bothering you, I continued today to make some tests.
> > > > 
> > > > I isolated the problem where the laptop got stuck after resume: I
> > disabled
> > > > the graphical UI since I discovered that the radeon card has a bug in
> the
> > > > kernel :(
> > > > 
> > > > During my test I suspended linux in text mode and I successfully
> resumed
> > > the
> > > > laptop, the wifi, and the connectivity: everything works correctly
> > without
> > > > any "magic script" from my side.
> > > 
> > > ok, thx for sharing. Can you please confirm my patch is not necessary?
> > > 
> > > > 
> > > > I just noticed that a message appeared after resuming wifi:
> > > > 
> > > > mt76x0e 0000:04:00.0: driver does not support HW RF ctrl
> > > > 
> > > > What do you think?
> > > 
> > > this means the radio is controlled in sw, this is info harmful (probably
> it
> > > is enough dev_info instead of dev_err)
> > > 
> > > Lorenzo
> > > 
> > > > 
> > > > Thanks,
> > > > 
> > > > Luca
> > 
> > Hi Lorenzo,
> > 
> > your patch is definitely required.
> > 
> > Thanks,
> > 
> > Luca
> 
> ok, so you confirm without my patch the suspend/resume process fails on
> mt76x0e?
> Can you please keep testing it?

yes, I confirm that without your patch the resume process fails to resume wifi.

I'll keep testing it.

(In reply to Luca T. from comment #29)
> (In reply to Lorenzo Bianconi from comment #28)
> > (In reply to Luca T. from comment #27)
> > > (In reply to Lorenzo Bianconi from comment #26)
> > > > (In reply to Luca T. from comment #25)
> > > > > (In reply to Lorenzo Bianconi from comment #22)
> > > > > > (In reply to Luca T. from comment #21)
> > > > > > > (In reply to Luca T. from comment #20)
> > > > > > > > (In reply to Lorenzo Bianconi from comment #19)
> > > > > > > > > (In reply to Luca T. from comment #18)
> > > > > > > > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > > > > > > > (In reply to Luca T. from comment #16)
> > > > > > > > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build
> M=$PWD`
> > ,
> > > > > where
> > > > > > > > uname
> > > > > > > > > > -r
> > > > > > > > > > > > > > currently gives 5.8.0-41-generic ; I get this error
> > > > message
> > > > > :
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > > > > > > > /home/matju/src/mt76/agg-rx.c: In function
> > > > > > `mt76_rx_aggr_stop':
> > > > > > > > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error:
> implicit
> > > > > > > declaration
> > > > > > > > of
> > > > > > > > > > > > > function
> > > > > > > > > > > > > > `rcu_swap_protected'
> > > > > [-Werror=implicit-function-declaration]
> > > > > > > > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno], tid,
> > > > > > > > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > > > > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > > > > > > > Erreur 1
> > > > > > > > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76]
> > Erreur
> > > 2
> > > > > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > > > > »
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > > I tried removing -Werror from your Makefile, but
> the
> > > > > default
> > > > > > > > still
> > > > > > > > > > > treats
> > > > > > > > > > > > > > this warning as an error, so I added -Wno-error
> > > instead,
> > > > > > which
> > > > > > > > made
> > > > > > > > > > no
> > > > > > > > > > > > > > difference, I had to write explicitly
> > > > > > > > > > > > > > -Wno-error=implicit-function-declaration , but then
> > it
> > > > > seems
> > > > > > > that
> > > > > > > > > > this
> > > > > > > > > > > is
> > > > > > > > > > > > > > not just a header problem after all, because then I
> > got
> > > > > this
> > > > > > :
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > > > > > > > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > > > > > > > undefined!
> > > > > > > > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > > > > > > > make[1]: *** Suppression du fichier «
> > > > > > > > > > > /home/matju/src/mt76/Module.symvers
> > > > > > > > > > > > »
> > > > > > > > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > > > > »
> > > > > > > > > > > > > 
> > > > > > > > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > > > > > > > rcu_swap_protected()
> > > > > > > > > > > > > should be defined in mt76.h
> > > > > > > > > > > > 
> > > > > > > > > > > > Hello Lorenzo, 
> > > > > > > > > > > 
> > > > > > > > > > > Hi Luca,
> > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > is your patch already released in the kernel 5.12.1?
> > > > > > > > > > > 
> > > > > > > > > > > nope since I have not received any feedback. Are you able
> > to
> > > > test
> > > > > > it?
> > > > > > > > (I
> > > > > > > > > do
> > > > > > > > > > > not have the mt7630e adapter) 
> > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > I have also another problem with the MT7630e (besides
> the
> > > one
> > > > > > with
> > > > > > > > the
> > > > > > > > > > > sleep
> > > > > > > > > > > > command): sometimes on my laptop the wifi disappears
> and
> > > only
> > > > > the
> > > > > > > > wire
> > > > > > > > > > > > connectivity is present. In order to make it working
> > again
> > > I
> > > > > need
> > > > > > > to
> > > > > > > > > > > > hibernate my laptop and power-on it again so that it
> > loads
> > > > > again
> > > > > > > the
> > > > > > > > > > > driver.
> > > > > > > > > > > > Do you know what can be the issue and eventually the
> > > > solution?
> > > > > > > > > > > 
> > > > > > > > > > > can you please describe when the issue occurs? do you
> have
> > > any
> > > > > info
> > > > > > > in
> > > > > > > > > the
> > > > > > > > > > > syslog?
> > > > > > > > > > > 
> > > > > > > > > > > Regards,
> > > > > > > > > > > Lorenzo
> > > > > > > > > > > 
> > > > > > > > > > > > 
> > > > > > > > > > > > Thanks in advance,
> > > > > > > > > > > > 
> > > > > > > > > > > > Luca T.
> > > > > > > > > > 
> > > > > > > > > > Hi Lorenzo,
> > > > > > > > > > 
> > > > > > > > > > yes, I have the hardware to test this patch.
> > > > > > > > > > 
> > > > > > > > > > I just installed the vanilla version of kernel 5.12.1, can
> > you
> > > > > please
> > > > > > > > > > provide me the link to the patch?
> > > > > > > > > 
> > > > > > > > > it is linked in the bz (it has the wrong mt76x0u name)
> > > > > > > > > 
> > > > > > > > > > 
> > > > > > > > > > For the other issue I'll check the journal and provide you
> > > > > additional
> > > > > > > > > > details soon (unfornately it happens once a day :) so I'll
> > come
> > > > > back
> > > > > > > > > > quickly).
> > > > > > > > > > 
> > > > > > > > > > Thanks in advance,
> > > > > > > > > > 
> > > > > > > > > > Luca
> > > > > > > > 
> > > > > > > > Hi Lorenzo,
> > > > > > > > 
> > > > > > > > it's quite a bit of time I'm recompiling kernel (~15 years :) )
> > so
> > > I
> > > > > have
> > > > > > > > some difficulties...
> > > > > > > > Since I have a working kernel from the Linux Mint
> distributions,
> > I
> > > > > copied
> > > > > > > > the configuration file in the new kernel directory and I
> > recompiled
> > > > it.
> > > > > > > > The problem is that when I'm restarting the kernel does not
> load
> > > some
> > > > > > > > drivers, hence linux can't find the hard disk and it goes in
> > kernel
> > > > > > panic.
> > > > > > > > 
> > > > > > > > Did I miss anything in the following compiling steps:
> > > > > > > > 1) Extract kernel in /usr/src
> > > > > > > > 2) Patch kernel (patch -p1 < <patch file>)
> > > > > > > > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > > > > > > > 4) make menuconfig in case of changes (here I didn't change
> > > anything
> > > > > for
> > > > > > > now)
> > > > > > > > 5) make -j12
> > > > > > > > 6) make bzImage (it seems required by Linux Mint)
> > > > > > > > 7) make modules_install
> > > > > > > > 8) Copy the configuration file back: cp .config
> > /boot/config-5.12.1
> > > > > > > > 9) make install
> > > > > > > > 10) update-grub2
> > > > > > > > 
> > > > > > > > Did I miss anything?
> > > > > > > > 
> > > > > > > > Thanks,
> > > > > > > > 
> > > > > > > > Luca
> > > > > > > 
> > > > > > > Hi Lorenzo,
> > > > > > > 
> > > > > > > I managed somehow to make the new kernel loading and your patch
> > seems
> > > > > > > working fine since I'm able to suspend and resume my laptop and
> the
> > > > > driver
> > > > > > > reloads correctly and connectivity is re-established.
> > > > > > > 
> > > > > > > You can proceed to merge the patch to the kernel.
> > > > > > 
> > > > > > nice. So you confirm now suspend/resume is fine. Can you please
> keep
> > > > > testing
> > > > > > it for a while?
> > > > > > 
> > > > > > > 
> > > > > > > In order to make it working temporarily I had to:
> > > > > > > 1) append "nomodeset" parameter otherwise the screen is black
> > > > > > > 2) replace the UUID identifier of my partition with the partition
> > > > number
> > > > > > > itself (like /dev/sda4)
> > > > > > > 3) remove "initrd" line since laptop freezes when loading the
> image
> > > > > > > 
> > > > > > > When I'm installing the kernel I see this issue:
> > > > > > > ---------------------------------------------------
> > > > > > > root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make install
> > > > > > > sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
> > > > > > >         System.map "/boot"
> > > > > > > run-parts: executing /etc/kernel/postinst.d/apt-auto-removal
> 5.12.1
> > > > > > > /boot/vmlinuz-5.12.1
> > > > > > > run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1
> > > > > > /boot/vmlinuz-5.12.1
> > > > > > >  * dkms: running auto installation service for kernel 5.12.1      
> > > > > > > Error!  The
> /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf
> > > for
> > > > > > > module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> > > > > > > does not match this kernel/arch.  This indicates that it should
> not
> > > be
> > > > > > built.
> > > > > > >                                                                   
> > > > > > > [ OK ]
> > > > > > > run-parts: executing /etc/kernel/postinst.d/initramfs-tools
> 5.12.1
> > > > > > > /boot/vmlinuz-5.12.1
> > > > > > > update-initramfs: Generating /boot/initrd.img-5.12.1
> > > > > > > W: Possible missing firmware
> /lib/firmware/i915/skl_guc_49.0.1.bin
> > > for
> > > > > > > module i915
> > > > > > > ...
> > > > > > > -----------------------------------------------------
> > > > > > > 
> > > > > > 
> > > > > > I am not familiar with mint build system. Is it enough to run make,
> > > make
> > > > > > modules_install; make install or do you need to create the .deb
> file?
> > > > > > 
> > > > > > > Could you please help me to resolve the issues I have in the
> kernel
> > > > > > > installation?
> > > > > > > 
> > > > > > > Thanks in advance,
> > > > > > > 
> > > > > > > Luca
> > > > > 
> > > > > Hi Lorenzo,
> > > > > 
> > > > > sorry for bothering you, I continued today to make some tests.
> > > > > 
> > > > > I isolated the problem where the laptop got stuck after resume: I
> > > disabled
> > > > > the graphical UI since I discovered that the radeon card has a bug in
> > the
> > > > > kernel :(
> > > > > 
> > > > > During my test I suspended linux in text mode and I successfully
> > resumed
> > > > the
> > > > > laptop, the wifi, and the connectivity: everything works correctly
> > > without
> > > > > any "magic script" from my side.
> > > > 
> > > > ok, thx for sharing. Can you please confirm my patch is not necessary?
> > > > 
> > > > > 
> > > > > I just noticed that a message appeared after resuming wifi:
> > > > > 
> > > > > mt76x0e 0000:04:00.0: driver does not support HW RF ctrl
> > > > > 
> > > > > What do you think?
> > > > 
> > > > this means the radio is controlled in sw, this is info harmful
> (probably
> > it
> > > > is enough dev_info instead of dev_err)
> > > > 
> > > > Lorenzo
> > > > 
> > > > > 
> > > > > Thanks,
> > > > > 
> > > > > Luca
> > > 
> > > Hi Lorenzo,
> > > 
> > > your patch is definitely required.
> > > 
> > > Thanks,
> > > 
> > > Luca
> > 
> > ok, so you confirm without my patch the suspend/resume process fails on
> > mt76x0e?
> > Can you please keep testing it?
> 
> yes, I confirm that without your patch the resume process fails to resume
> wifi.
> 
> I'll keep testing it.

ok, thx for sharing. If you confirm there are no other issue, I will post the patch

Regards,
Lorenzo

(In reply to Lorenzo Bianconi from comment #30)
> (In reply to Luca T. from comment #29)
> > (In reply to Lorenzo Bianconi from comment #28)
> > > (In reply to Luca T. from comment #27)
> > > > (In reply to Lorenzo Bianconi from comment #26)
> > > > > (In reply to Luca T. from comment #25)
> > > > > > (In reply to Lorenzo Bianconi from comment #22)
> > > > > > > (In reply to Luca T. from comment #21)
> > > > > > > > (In reply to Luca T. from comment #20)
> > > > > > > > > (In reply to Lorenzo Bianconi from comment #19)
> > > > > > > > > > (In reply to Luca T. from comment #18)
> > > > > > > > > > > (In reply to Lorenzo Bianconi from comment #17)
> > > > > > > > > > > > (In reply to Luca T. from comment #16)
> > > > > > > > > > > > > (In reply to Lorenzo Bianconi from comment #15)
> > > > > > > > > > > > > > (In reply to Mathieu Bouchard from comment #14)
> > > > > > > > > > > > > > > Doing `make -C /lib/modules/$(uname -r)/build
> > M=$PWD`
> > > ,
> > > > > > where
> > > > > > > > > uname
> > > > > > > > > > > -r
> > > > > > > > > > > > > > > currently gives 5.8.0-41-generic ; I get this
> error
> > > > > message
> > > > > > :
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > >   CC [M]  /home/matju/src/mt76/agg-rx.o
> > > > > > > > > > > > > > > /home/matju/src/mt76/agg-rx.c: In function
> > > > > > > `mt76_rx_aggr_stop':
> > > > > > > > > > > > > > > /home/matju/src/mt76/agg-rx.c:293:2: error:
> > implicit
> > > > > > > > declaration
> > > > > > > > > of
> > > > > > > > > > > > > > function
> > > > > > > > > > > > > > > `rcu_swap_protected'
> > > > > > [-Werror=implicit-function-declaration]
> > > > > > > > > > > > > > >   293 |  rcu_swap_protected(wcid->aggr[tidno],
> tid,
> > > > > > > > > > > > > > >       |  ^~~~~~~~~~~~~~~~~~
> > > > > > > > > > > > > > > cc1: all warnings being treated as errors
> > > > > > > > > > > > > > > make[1]: *** [scripts/Makefile.build:290 :
> > > > > > > > > > > > /home/matju/src/mt76/agg-rx.o]
> > > > > > > > > > > > > > > Erreur 1
> > > > > > > > > > > > > > > make: *** [Makefile:1780 : /home/matju/src/mt76]
> > > Erreur
> > > > 2
> > > > > > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > > > > > »
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > > I tried removing -Werror from your Makefile, but
> > the
> > > > > > default
> > > > > > > > > still
> > > > > > > > > > > > treats
> > > > > > > > > > > > > > > this warning as an error, so I added -Wno-error
> > > > instead,
> > > > > > > which
> > > > > > > > > made
> > > > > > > > > > > no
> > > > > > > > > > > > > > > difference, I had to write explicitly
> > > > > > > > > > > > > > > -Wno-error=implicit-function-declaration , but
> then
> > > it
> > > > > > seems
> > > > > > > > that
> > > > > > > > > > > this
> > > > > > > > > > > > is
> > > > > > > > > > > > > > > not just a header problem after all, because then
> I
> > > got
> > > > > > this
> > > > > > > :
> > > > > > > > > > > > > > > 
> > > > > > > > > > > > > > >   MODPOST /home/matju/src/mt76/Module.symvers
> > > > > > > > > > > > > > > ERROR: modpost: "rcu_swap_protected"
> > > > > > > > > [/home/matju/src/mt76/mt76.ko]
> > > > > > > > > > > > > > > undefined!
> > > > > > > > > > > > > > > make[1]: *** [scripts/Makefile.modpost:111 :
> > > > > > > > > > > > > > > /home/matju/src/mt76/Module.symvers] Erreur 1
> > > > > > > > > > > > > > > make[1]: *** Suppression du fichier «
> > > > > > > > > > > > /home/matju/src/mt76/Module.symvers
> > > > > > > > > > > > > »
> > > > > > > > > > > > > > > make: *** [Makefile:1693 : modules] Erreur 2
> > > > > > > > > > > > > > > make : on quitte le répertoire «
> > > > > > > > > > > > /usr/src/linux-headers-5.8.0-41-generic
> > > > > > > > > > > > > »
> > > > > > > > > > > > > > 
> > > > > > > > > > > > > > I updated the branch to compile against 5.8. Anyway
> > > > > > > > > > > rcu_swap_protected()
> > > > > > > > > > > > > > should be defined in mt76.h
> > > > > > > > > > > > > 
> > > > > > > > > > > > > Hello Lorenzo, 
> > > > > > > > > > > > 
> > > > > > > > > > > > Hi Luca,
> > > > > > > > > > > > 
> > > > > > > > > > > > > 
> > > > > > > > > > > > > is your patch already released in the kernel 5.12.1?
> > > > > > > > > > > > 
> > > > > > > > > > > > nope since I have not received any feedback. Are you
> able
> > > to
> > > > > test
> > > > > > > it?
> > > > > > > > > (I
> > > > > > > > > > do
> > > > > > > > > > > > not have the mt7630e adapter) 
> > > > > > > > > > > > 
> > > > > > > > > > > > > 
> > > > > > > > > > > > > I have also another problem with the MT7630e (besides
> > the
> > > > one
> > > > > > > with
> > > > > > > > > the
> > > > > > > > > > > > sleep
> > > > > > > > > > > > > command): sometimes on my laptop the wifi disappears
> > and
> > > > only
> > > > > > the
> > > > > > > > > wire
> > > > > > > > > > > > > connectivity is present. In order to make it working
> > > again
> > > > I
> > > > > > need
> > > > > > > > to
> > > > > > > > > > > > > hibernate my laptop and power-on it again so that it
> > > loads
> > > > > > again
> > > > > > > > the
> > > > > > > > > > > > driver.
> > > > > > > > > > > > > Do you know what can be the issue and eventually the
> > > > > solution?
> > > > > > > > > > > > 
> > > > > > > > > > > > can you please describe when the issue occurs? do you
> > have
> > > > any
> > > > > > info
> > > > > > > > in
> > > > > > > > > > the
> > > > > > > > > > > > syslog?
> > > > > > > > > > > > 
> > > > > > > > > > > > Regards,
> > > > > > > > > > > > Lorenzo
> > > > > > > > > > > > 
> > > > > > > > > > > > > 
> > > > > > > > > > > > > Thanks in advance,
> > > > > > > > > > > > > 
> > > > > > > > > > > > > Luca T.
> > > > > > > > > > > 
> > > > > > > > > > > Hi Lorenzo,
> > > > > > > > > > > 
> > > > > > > > > > > yes, I have the hardware to test this patch.
> > > > > > > > > > > 
> > > > > > > > > > > I just installed the vanilla version of kernel 5.12.1,
> can
> > > you
> > > > > > please
> > > > > > > > > > > provide me the link to the patch?
> > > > > > > > > > 
> > > > > > > > > > it is linked in the bz (it has the wrong mt76x0u name)
> > > > > > > > > > 
> > > > > > > > > > > 
> > > > > > > > > > > For the other issue I'll check the journal and provide
> you
> > > > > > additional
> > > > > > > > > > > details soon (unfornately it happens once a day :) so
> I'll
> > > come
> > > > > > back
> > > > > > > > > > > quickly).
> > > > > > > > > > > 
> > > > > > > > > > > Thanks in advance,
> > > > > > > > > > > 
> > > > > > > > > > > Luca
> > > > > > > > > 
> > > > > > > > > Hi Lorenzo,
> > > > > > > > > 
> > > > > > > > > it's quite a bit of time I'm recompiling kernel (~15 years :)
> )
> > > so
> > > > I
> > > > > > have
> > > > > > > > > some difficulties...
> > > > > > > > > Since I have a working kernel from the Linux Mint
> > distributions,
> > > I
> > > > > > copied
> > > > > > > > > the configuration file in the new kernel directory and I
> > > recompiled
> > > > > it.
> > > > > > > > > The problem is that when I'm restarting the kernel does not
> > load
> > > > some
> > > > > > > > > drivers, hence linux can't find the hard disk and it goes in
> > > kernel
> > > > > > > panic.
> > > > > > > > > 
> > > > > > > > > Did I miss anything in the following compiling steps:
> > > > > > > > > 1) Extract kernel in /usr/src
> > > > > > > > > 2) Patch kernel (patch -p1 < <patch file>)
> > > > > > > > > 3) Copy config file: cp /boot/config-$(uname -r) .config
> > > > > > > > > 4) make menuconfig in case of changes (here I didn't change
> > > > anything
> > > > > > for
> > > > > > > > now)
> > > > > > > > > 5) make -j12
> > > > > > > > > 6) make bzImage (it seems required by Linux Mint)
> > > > > > > > > 7) make modules_install
> > > > > > > > > 8) Copy the configuration file back: cp .config
> > > /boot/config-5.12.1
> > > > > > > > > 9) make install
> > > > > > > > > 10) update-grub2
> > > > > > > > > 
> > > > > > > > > Did I miss anything?
> > > > > > > > > 
> > > > > > > > > Thanks,
> > > > > > > > > 
> > > > > > > > > Luca
> > > > > > > > 
> > > > > > > > Hi Lorenzo,
> > > > > > > > 
> > > > > > > > I managed somehow to make the new kernel loading and your patch
> > > seems
> > > > > > > > working fine since I'm able to suspend and resume my laptop and
> > the
> > > > > > driver
> > > > > > > > reloads correctly and connectivity is re-established.
> > > > > > > > 
> > > > > > > > You can proceed to merge the patch to the kernel.
> > > > > > > 
> > > > > > > nice. So you confirm now suspend/resume is fine. Can you please
> > keep
> > > > > > testing
> > > > > > > it for a while?
> > > > > > > 
> > > > > > > > 
> > > > > > > > In order to make it working temporarily I had to:
> > > > > > > > 1) append "nomodeset" parameter otherwise the screen is black
> > > > > > > > 2) replace the UUID identifier of my partition with the
> partition
> > > > > number
> > > > > > > > itself (like /dev/sda4)
> > > > > > > > 3) remove "initrd" line since laptop freezes when loading the
> > image
> > > > > > > > 
> > > > > > > > When I'm installing the kernel I see this issue:
> > > > > > > > ---------------------------------------------------
> > > > > > > > root@oldlaptop:/usr/src/linux-5.12.1-MT7630e-patch# make
> install
> > > > > > > > sh ./arch/x86/boot/install.sh 5.12.1 arch/x86/boot/bzImage \
> > > > > > > >         System.map "/boot"
> > > > > > > > run-parts: executing /etc/kernel/postinst.d/apt-auto-removal
> > 5.12.1
> > > > > > > > /boot/vmlinuz-5.12.1
> > > > > > > > run-parts: executing /etc/kernel/postinst.d/dkms 5.12.1
> > > > > > > /boot/vmlinuz-5.12.1
> > > > > > > >  * dkms: running auto installation service for kernel 5.12.1    
> > > > > > > > Error!  The
> > /var/lib/dkms/ndiswrapper/1.60/5.12.1/x86_64/dkms.conf
> > > > for
> > > > > > > > module ndiswrapper includes a BUILD_EXCLUSIVE directive which
> > > > > > > > does not match this kernel/arch.  This indicates that it should
> > not
> > > > be
> > > > > > > built.
> > > > > > > >                                                                 
> > > > > > > > [ OK ]
> > > > > > > > run-parts: executing /etc/kernel/postinst.d/initramfs-tools
> > 5.12.1
> > > > > > > > /boot/vmlinuz-5.12.1
> > > > > > > > update-initramfs: Generating /boot/initrd.img-5.12.1
> > > > > > > > W: Possible missing firmware
> > /lib/firmware/i915/skl_guc_49.0.1.bin
> > > > for
> > > > > > > > module i915
> > > > > > > > ...
> > > > > > > > -----------------------------------------------------
> > > > > > > > 
> > > > > > > 
> > > > > > > I am not familiar with mint build system. Is it enough to run
> make,
> > > > make
> > > > > > > modules_install; make install or do you need to create the .deb
> > file?
> > > > > > > 
> > > > > > > > Could you please help me to resolve the issues I have in the
> > kernel
> > > > > > > > installation?
> > > > > > > > 
> > > > > > > > Thanks in advance,
> > > > > > > > 
> > > > > > > > Luca
> > > > > > 
> > > > > > Hi Lorenzo,
> > > > > > 
> > > > > > sorry for bothering you, I continued today to make some tests.
> > > > > > 
> > > > > > I isolated the problem where the laptop got stuck after resume: I
> > > > disabled
> > > > > > the graphical UI since I discovered that the radeon card has a bug
> in
> > > the
> > > > > > kernel :(
> > > > > > 
> > > > > > During my test I suspended linux in text mode and I successfully
> > > resumed
> > > > > the
> > > > > > laptop, the wifi, and the connectivity: everything works correctly
> > > > without
> > > > > > any "magic script" from my side.
> > > > > 
> > > > > ok, thx for sharing. Can you please confirm my patch is not
> necessary?
> > > > > 
> > > > > > 
> > > > > > I just noticed that a message appeared after resuming wifi:
> > > > > > 
> > > > > > mt76x0e 0000:04:00.0: driver does not support HW RF ctrl
> > > > > > 
> > > > > > What do you think?
> > > > > 
> > > > > this means the radio is controlled in sw, this is info harmful
> > (probably
> > > it
> > > > > is enough dev_info instead of dev_err)
> > > > > 
> > > > > Lorenzo
> > > > > 
> > > > > > 
> > > > > > Thanks,
> > > > > > 
> > > > > > Luca
> > > > 
> > > > Hi Lorenzo,
> > > > 
> > > > your patch is definitely required.
> > > > 
> > > > Thanks,
> > > > 
> > > > Luca
> > > 
> > > ok, so you confirm without my patch the suspend/resume process fails on
> > > mt76x0e?
> > > Can you please keep testing it?
> > 
> > yes, I confirm that without your patch the resume process fails to resume
> > wifi.
> > 
> > I'll keep testing it.
> 
> ok, thx for sharing. If you confirm there are no other issue, I will post
> the patch
> 
> Regards,
> Lorenzo

Hi Lorenzo,

I'm using now your patch by 1 week and wifi resumes correctly, so I believe there are no more issues, you can post the patch.

Thanks,

Luca

Hi Lorenzo,

I tested your fix for long time and I found now that when the laptop starts everything works smoothly and there are no issues with the WiFi driver, but in case I'm putting the laptop on sleep and waking it up again, the laptop stops to respond and I need to perform an hard reset.

This was not detected before since I forgot that I had also added a workaround script which perform the following actions:

/lib/systemd/system-sleep/wifi-wakeup:
case $1/$2 in
    pre/*)
        modprobe -r mt76x0e mt76xx
        sleep 1
        ;;
    post/*)
        modprobe mt76x0e mt76xx
        ;;
esac

Please let me know whether you want to investigate further.

Thanks,

Luca

I have same issue with WiFi driver and suspend mode. System goes to suspend but never wakes up. 

ThinkPad E14 Gen 3 with AMD Ryzen 3 5300U.
Device-2: MEDIATEK MT7921 802.11ax PCI Express Wireless Network Adapter driver: mt7921e

Altlinux p10. 
Kernel: 5.15.25-un-def-alt1

I checked Bug 215787 but:

$echo 'dev_addr' > /sys/bus/pci/drivers/mt7921e/unbind
$echo 'dev_addr' > /sys/bus/pci/drivers/mt7921e/bind

goes without showing any troubles.

Edition: 
$echo 'dev_addr' > /sys/bus/pci/drivers/mt7921e/unbind
$echo 'dev_addr' > /sys/bus/pci/drivers/mt7921e/bind

makes system reboot about half of an hour later right after using network.

(In reply to Luca T. from comment #32)
> Hi Lorenzo,
> 
> I tested your fix for long time and I found now that when the laptop starts
> everything works smoothly and there are no issues with the WiFi driver, but
> in case I'm putting the laptop on sleep and waking it up again, the laptop
> stops to respond and I need to perform an hard reset.
> 
> This was not detected before since I forgot that I had also added a
> workaround script which perform the following actions:
> 
> /lib/systemd/system-sleep/wifi-wakeup:
> case $1/$2 in
>     pre/*)
>         modprobe -r mt76x0e mt76xx
>         sleep 1
>         ;;
>     post/*)
>         modprobe mt76x0e mt76xx
>         ;;
> esac
> 
> Please let me know whether you want to investigate further.
> 
> Thanks,
> 
> Luca

Hello, Luca!
I used patch proposed in Bug 215787 discussion and it fix suspend/resume problem for me.

That linked bug has a solution in the mainline kernel 5.19 or later.
ad483ed9dd51 ("mt76: mt7921: fix kernel crash at mt7921_pci_remove")

Does this issue still happen in a current 6.1.y or 6.2.y kernel version?

No response from the OP for two weeks, closing.

I suppose I'm just a little late, but was testing the patch and newer kernels. It seems as though most, if not all, of the code in the patch is already implemented in newer kernels. Unfortunately it doesn't fix this issue.

Once the laptop has been suspended, the wifi stops working. Weirdly, even a reboot doesn't resolve this, as the wifi chip seems to be disabled entirely after a reboot. Only a power off and power on will restore wifi functionality.

While being fairly new to linux in general, I believe I could help with testing and hunting for a solution. I'm open to installing and running any kernel, patch and distro in assisting to resolving this. Please let me know what I can do, and what information you'd like me to provide you with in order to fully resolve this issue.


$ inxi -Fx
System:
  Host: laptop Kernel: 6.2.8 x86_64 bits: 64 compiler: gcc v: 11.3.0
    Desktop: Cinnamon 5.6.8 Distro: Linux Mint 21.1 Vera
    base: Ubuntu 22.04 jammy
Machine:
  Type: Laptop System: Hewlett-Packard product: HP ProBook 450 G1
    v: A3009DD10303 serial: <superuser required>
  Mobo: Hewlett-Packard model: 1942 v: KBC Version 89.10
    serial: <superuser required> UEFI: Hewlett-Packard v: L74 Ver. 01.05
    date: 11/04/2013
Battery:
  ID-1: BAT0 charge: 41.6 Wh (98.6%) condition: 42.2/42.2 Wh (100.0%)
    volts: 12.5 min: 10.8 model: Hewlett-Packard Primary status: Not charging
CPU:
  Info: dual core model: Intel Core i5-4200M bits: 64 type: MT MCP
    arch: Haswell rev: 3 cache: L1: 128 KiB L2: 512 KiB L3: 3 MiB
  Speed (MHz): avg: 2744 high: 2774 min/max: 800/3100 cores: 1: 2774
    2: 2697 3: 2752 4: 2753 bogomips: 19954
  Flags: avx avx2 ht lm nx pae sse sse2 sse3 sse4_1 sse4_2 ssse3 vmx
Graphics:
  Device-1: Intel 4th Gen Core Processor Integrated Graphics
    vendor: Hewlett-Packard driver: i915 v: kernel bus-ID: 00:02.0
  Device-2: Cheng Uei Precision Industry (Foxlink) HP HD Webcam type: USB
    driver: uvcvideo bus-ID: 3-7:3
  Display: x11 server: X.Org v: 1.21.1.3 driver: X: loaded: modesetting
    unloaded: fbdev,vesa gpu: i915 resolution: 1366x768~60Hz
  OpenGL: renderer: Mesa Intel HD Graphics 4600 (HSW GT2)
    v: 4.6 Mesa 22.2.5 direct render: Yes
Audio:
  Device-1: Intel Xeon E3-1200 v3/4th Gen Core Processor HD Audio
    vendor: Hewlett-Packard driver: snd_hda_intel v: kernel bus-ID: 00:03.0
  Device-2: Intel 8 Series/C220 Series High Definition Audio
    vendor: Hewlett-Packard driver: snd_hda_intel v: kernel bus-ID: 00:1b.0
  Sound Server-1: ALSA v: k6.2.8 running: yes
  Sound Server-2: PulseAudio v: 15.99.1 running: yes
  Sound Server-3: PipeWire v: 0.3.48 running: yes
Network:
  Device-1: Realtek RTL8111/8168/8411 PCI Express Gigabit Ethernet
    vendor: Hewlett-Packard driver: r8169 v: kernel port: 3000 bus-ID: 02:00.0
  IF: enp2s0 state: down mac: a0:1d:48:a8:5e:ac
  Device-2: MEDIATEK MT7630e 802.11bgn Wireless Network Adapter
    vendor: Hewlett-Packard driver: mt76x0e v: kernel bus-ID: 03:00.0
  IF: wlo1 state: up mac: fc:4d:d4:54:c3:a4
Bluetooth:
  Device-1: MediaTek MT7630e Bluetooth Adapter type: USB driver: N/A
    bus-ID: 3-12:4
Drives:
  Local Storage: total: 238.47 GiB used: 136.21 GiB (57.1%)
  ID-1: /dev/sda vendor: Samsung model: SSD 840 PRO Series size: 238.47 GiB
Partition:
  ID-1: / size: 233.18 GiB used: 68.1 GiB (29.2%) fs: ext4 dev: /dev/sda2
  ID-2: /boot/efi size: 511 MiB used: 6.1 MiB (1.2%) fs: vfat
    dev: /dev/sda1
Swap:
  ID-1: swap-1 type: file size: 2 GiB used: 512 KiB (0.0%) file: /swapfile
Sensors:
  System Temperatures: cpu: 49.0 C mobo: 0.0 C
  Fan Speeds (RPM): N/A
Info:
  Processes: 219 Uptime: 26m Memory: 15.5 GiB used: 2.67 GiB (17.2%)
  Init: systemd runlevel: 5 Compilers: gcc: 11.3.0 Packages: 2180 Shell: Bash
  v: 5.1.16 inxi: 3.3.13

Sorry for not having replied after Feb 2021. This issue was never resolved for me. What has changed are the workarounds. Back then I was still able to use a 3rd party driver (mt7630e), and then after a certain upgrade it stopped working, so I switched to this driver but used some kind of command like sudo bash -c 'rmmod mt76x0e && modprobe mt76x0e' each time the laptop left sleep mode. I think that the actual sequence changed from time to time: I may have had to run this command twice, or add more steps. But then came a time when no workaround seemed to work, so I just stopped using sleep mode at all on this computer.

I just tried again today and the problem with sleep mode is not recovered by a reboot, it requires shutting down the computer, but not unplugging it nor unplugging the battery (I mention the battery because I once had to do that to reset a crashed DVD drive...). I tried rmmodding those and modprobing again :

mt76x0e                20480  0
mt76x0_common          53248  1 mt76x0e
mt76x02_lib            94208  2 mt76x0e,mt76x0_common
mt76                  102400  3 mt76x0e,mt76x02_lib,mt76x0_common

But obviously, a reboot is already a quite complete way to rmmod everything and modprobe everything back...

I confirm the same behaviour with current arch distro... 
It is fine on boot, but after one suspend/resume, it prints the same
"TX DMA did not stop" message in the logs. and never succeeds 
in connecting:

uname -a
Linux blacklab 6.12.6-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 19 Dec 2024 21:29:01 +0000 x86_64 GNU/Linux

also... no bluetooth for this device... even though it is supposed to be combined wlan and bt.