Created attachment 276337 [details] lspci Since upgrading to the kernel version 4.16.13 in fedora 28 the laptop (samsung 305V4A) hangs on the third time when I try suspend (the system doesn't enter suspend and some leds are on), previous kernel 4.16.12 works ok the custom udev rule is this ACTION=="add", SUBSYSTEM=="pci", ATTR{power/control}="auto" As a work around i can enter this command to make the laptop capable of suspend multiple times in 4.16.13 echo on > sys/bus/pci/devices/0000\:00\:14.4/power/control I haven't had the time to bisect the commits, but in a hunch i reverted this commit and the system can suspend multiple times: commit 9fa10e44b722f6773841e18912edefda735e71d8 PM / core: Fix direct_complete handling for devices with no callbacks commit c62ec4610c40bcc44f2d3d5ed1c312737279e2f3 upstream. attached is the output of lspci Some previous similar bug I had with the same laptop: https://bugzilla.kernel.org/show_bug.cgi?id=156441 Thanks!
Please attach the output of lspci from this machine.
Created attachment 276351 [details] lspci here is lspci again
0000:00:14.4 is a bridge, so the commit you have reverted effectively enables the direct_complete optimization for it and that leads to problems. It looks like disabling direct_complete for it explicitly should help, but please attach the output of "lspci -vvv" so we can see more details.
Created attachment 276361 [details] lspci -vvv here it is
But can you call it as root, please?
Created attachment 276367 [details] sudo lspci -vvv ok
do you need any other info?
Created attachment 276701 [details] PCI / PM: Resume parallel bridges on system suspend Does this patch help?
Created attachment 276703 [details] PCI / ACPI / PM: Resume bridges on system suspend Please test this patch too
with the patch of comment 8 i can suspend and resume multiple times with kernel 4.17.2. I couldn't apply the patch on comment 9, on top of what kernel version should it be applied?
The patch from comment #9 applies on top of the mainline 4.18-rc2 without any modifications (for me at least). Please test it on top of that kernel.
patches applied on top of 4.18-rc1, can suspend more than 3 times now, haven't seen any negative effects. Will continue testing. Thanks!
OK, thanks for testing! I'll submit the patch from comment #9 for inclusion.
Patch submitted: https://patchwork.kernel.org/patch/10488563/
BTW, please test the patch from comment #9 without the patch from comment #8 too (that might have been unclear).
ok will test the patch from #9 alone and will report back
With only the patch of comment 9 in top of 4.18-rc1 the system CAN'T suspend multiple times. In resume: patch from comment 8 alone WORKS patch from comment 9 alone DOESN'T WORKS both patches applied WORKS
OK, thanks! I'll send more patches to test in the next few days.
Created attachment 276907 [details] PCI / ACPI / PM: Resume bridges w/o drivers on suspend-to-RAM This is a replacement for both the patches from comment #9 and from comment #9. Please test this one.
I mean the patches from comment #8 and from comment #9, of course. That is, please test the patch from comment #19 alone.
The patch in comment 19 WORKS, I can now suspend multiple times. Thanks a lot
Cool, thanks for the confirmation!