Bug 198425 - KASAN: don't print free stack when object is not free
Summary: KASAN: don't print free stack when object is not free
Status: RESOLVED CODE_FIX
Alias: None
Product: Memory Management
Classification: Unclassified
Component: Sanitizers (show other bugs)
Hardware: All Linux
: P2 enhancement
Assignee: Dmitry Vyukov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-10 09:11 UTC by Dmitry Vyukov
Modified: 2021-02-03 11:07 UTC (History)
2 users (show)

See Also:
Kernel Version: ALL
Tree: Mainline
Regression: No


Attachments

Description Dmitry Vyukov 2018-01-10 09:11:19 UTC
KASAN currently prints free stack always, even if the object is not free. E.g. for OOB report we print free stack, which usually points to the previous allocation of the object. This takes space and is confusing. We should not print free stack in such cases.
Comment 1 Dmitry Vyukov 2019-12-04 06:35:40 UTC
See this:
https://groups.google.com/g/syzkaller-bugs/c/TVGAFDeUKJo/m/-3-Be05sAQAJ
how the irrelevant free stack confused Daniel, and he wanted to write off report as bogus and corrupted.
Comment 2 Dmitry Vyukov 2020-03-20 06:47:49 UTC
Keeping information in one place:
Andrey Ryabinin replied:

> Because we have that information (free stack) and it usually better to
> provide
> all the information we have rather than hide it. You never known what
> information
> might be needed to fix the bug.
> Free memory might be reused and what we report as OOB might be an UAF and
> free stack
> could be useful in such case.
Comment 3 Dmitry Vyukov 2020-03-20 06:52:26 UTC
Willem just stared debugging an OOB as UAF being confused by the Free stack. Willem, is my interpretation correct? Or you think that OOB is really an UAF? Note: the heap block (identified by the Allocated stack) is not freed at all at the time of the report.
Comment 4 Dmitry Vyukov 2020-03-20 06:55:54 UTC
I think at least we need to replace "Freed" with some meaningful explanation of what really this stack represents and the state of the object.
Suggestions for a concise one-line wording are welcome.
Comment 5 Willem de Bruijn 2020-03-20 12:45:49 UTC
Indeed, I also mistook the output of "Allocated by" and "Freed by" as implying that I was looking at a use-after-free. Maybe "Last Freed by", or an explicit note that the free event may have preceded the allocate event?
Comment 6 Dmitry Vyukov 2020-05-06 09:16:41 UTC
Another user confused by this "free stack for a not freed object":
https://groups.google.com/d/msg/syzkaller-bugs/hCj_dXTfd94/gFpw8mLFAwAJ
Comment 7 Dmitry Vyukov 2021-02-03 11:07:50 UTC
This was resolved as part of changes for Bug 198437. We now store free meta in the object so we don't have/can't print free stack for active objects.

Note You need to log in before you can comment on or make changes to this bug.