Bug 198081 - scsi sg
Summary: scsi sg
Status: RESOLVED PATCH_ALREADY_AVAILABLE
Alias: None
Product: IO/Storage
Classification: Unclassified
Component: SCSI (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: linux-scsi@vger.kernel.org
URL:
Keywords:
: 198079 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-12-04 10:05 UTC by Cristian Crinteanu
Modified: 2018-04-01 07:41 UTC (History)
3 users (show)

See Also:
Kernel Version: 4.4.89 and higher
Subsystem:
Regression: No
Bisected commit-id:


Attachments
scsi sg problems (8.81 KB, patch)
2017-12-04 10:05 UTC, Cristian Crinteanu
Details | Diff
rediff for => 4.4.123 (13.19 KB, patch)
2018-03-25 13:46 UTC, Cristian Crinteanu
Details | Diff

Description Cristian Crinteanu 2017-12-04 10:05:21 UTC
Created attachment 261015 [details]
scsi sg problems

hi, just noticed that one of the following commits introduced in 4.4.89 borks some apps (like nerolinux and norton ghost 12.
 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3e0097499839e0fe3af380410eababe5a47c4cf9

https://lkml.org/lkml/2017/9/24/457

https://patchwork.kernel.org/patch/9968779/

https://lkml.org/lkml/2017/9/24/356

nerolinux fail to detect any drives on my pc with
 
 Call Trace:
  [<c02de73f>] ? dump_stack+0x44/0x57
  [<c013b639>] ? warn_slowpath_common+0x85/0x9a
  [<c03e1116>] ? sg_rq_end_io+0x42/0x277
  [<c013b6f1>] ? warn_slowpath_null+0xd/0x10
  [<c03e1116>] ? sg_rq_end_io+0x42/0x277
  [<c02bd08c>] ? blk_account_io_done+0xc/0xea
  [<c02bd1cd>] ? blk_finish_request+0x63/0x84
  [<c03c9f87>] ? scsi_end_request+0x11a/0x155
  [<c03cae32>] ? scsi_io_completion+0x1c7/0x4aa
  [<c02c1c2c>] ? blk_done_softirq+0x56/0x70
  [<c013df28>] ? __do_softirq+0xa6/0x18b
  [<c013de82>] ? tasklet_action+0x90/0x90
  [<c0103980>] ? do_softirq_own_stack+0x1a/0x1f
  <IRQ>  [<c013e144>] ? irq_exit+0x3c/0x7b
  [<c0103463>] ? do_IRQ+0x7a/0x8b
  [<c05343b3>] ? common_interrupt+0x33/0x38
  [<c016007b>] ? unregister_console+0x87/0xad
  [<c0476295>] ? cpuidle_enter_state+0xdb/0x17d
  [<c0155e6b>] ? cpu_startup_entry+0x17f/0x1e2
  [<c0129344>] ? start_secondary+0x13b/0x153
 ---[ end trace 36fc4958c27e64df ]---

and norton ghost 12

*********************************
Date   : Wed Nov 29 22:34:34 2017
Error Number: 36000
Message: A signal or windows exception occurred
Version: 12.0.0.10561(Nov  2 2017, Build=10561
OS Version: Linux 4.4.100-pclos1.pae #1 SMP Tue Nov 21 16:10:25 EET 2017 i686
Command line arguments:
Active Switches :
       AutoName
PathName            :
FlagImplode         : 0
FlagExplode         : 0

Operation Details :
  Total size.........0
  MB copied..........0
  MB remaining.......0
  Percent complete...0%
  Speed..............0 MB/min
  Time elapsed.......0:00  
  Time remaining.....0:00  

Processor exception
Generated at HardExceptionHandlerLinux.cpp:230

Program Call Stack
VolumeContainerManagerLvm::addIfPv
VolumeContainerManagerLvm::loadPvs
VolumeContainerManagerLvm::loadVolumeGroups
VolumeContainerManagerLvm::loadVolumeGroups
VolumeContainerManagerLvm::constructor
VolumeContainerManager::loadVolumeManagers
VolumeContainerManager::constructor
sub_main
main

Call Stack
  0xeba0f62a
  0xb77e8a0c
  0x084644f6
  0x084645ce
  0x086ad8e0
  0x086b3aac
  0x0870f00e
  0x0870f3a3
  0x0870f51b
  0x0870f7ab
  0x0870f8de
  0x086ff373
  0x086ffdab
  0x08700039
  0x08284c59
  0x08286679
  0x082893df
  0x08052d25
  0x080541b4
End Call Stack

Anyway i reversed the scsi: sg: changes introduced in 4.4.89 and everything works fine (see the attach) - now i'm running 4.4.100 with the patch attached
thx!
Comment 1 Cristian Crinteanu 2017-12-04 10:07:23 UTC
*** Bug 198079 has been marked as a duplicate of this bug. ***
Comment 2 Cristian Crinteanu 2018-03-25 13:46:08 UTC
Created attachment 274927 [details]
rediff for => 4.4.123

unfortunately sg.c changes introduced in 4.4.123 does not fix the problem for nero
- same problem as above
so, attached a rediff that force the actual kernel to use sg.c provided in 4.4.88
Comment 3 Bart Van Assche 2018-03-26 15:36:04 UTC
The process in the Linux kernel is such that patches get applied on Linus' tree and from there are backported to stable kernels. Can you provide a diff against Linus' v4.16-rc7 kernel that only restores compatibility with Nero and that does not undo any other recent changes?
Comment 4 Cristian Crinteanu 2018-03-26 16:37:12 UTC
will try that - to see what patch(es) introduced in 4.4.89 (see above) cause that fault.
wil be back..
Comment 5 Anthony J. Battersby 2018-03-28 21:51:08 UTC
I ran into a similar problem.  Applying this fixed it for me:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=48ae8484e9fc324b4968d33c585e54bc98e44d61

See my message to the -stable kernel maintainers for more info:

https://marc.info/?l=linux-scsi&m=152227354106242
Comment 6 Cristian Crinteanu 2018-03-30 09:59:40 UTC
thx Anthony - the patch provied fixes nero

Note You need to log in before you can comment on or make changes to this bug.