Bug 198077 - Use dev_info instead of dev_err
Summary: Use dev_info instead of dev_err
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: PCI (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_pci@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-04 00:26 UTC by fin4478
Modified: 2018-02-27 08:36 UTC (History)
1 user (show)

See Also:
Kernel Version: 4.10.0 - 4.15.0-rc2
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description fin4478 2017-12-04 00:26:59 UTC
All messages that use the dev_err function slows down booting and make it look ugly. 
Change Invalid PCI ROM header signature message to use the dev_info function in ./drivers/pci/rom.c

All computers with a Amd gpu do have this message and works fine, so there is no errors.
size_t pci_get_rom_size(struct pci_dev *pdev, void __iomem *rom, size_t size)
{
	void __iomem *image;
	int last_image;
	unsigned length;

	image = rom;
	do {
		void __iomem *pds;
		/* Standard PCI ROMs start out with these bytes 55 AA */
		if (readw(image) != 0xAA55) {
			dev_info(&pdev->dev, "Invalid PCI ROM header signature: expecting 0xaa55, got %#06x\n",
				readw(image));
			break;
		}
Comment 1 fin4478 2018-02-27 08:36:47 UTC
This is fixed in recent mainline kernels.

Note You need to log in before you can comment on or make changes to this bug.