Bug 195727 - fcntl F_SETLKW recheck time too long for host/guest communication
Summary: fcntl F_SETLKW recheck time too long for host/guest communication
Alias: None
Product: File System
Classification: Unclassified
Component: v9fs (show other bugs)
Hardware: All Linux
: P1 enhancement
Assignee: Eric Van Hensbergen
Depends on:
Reported: 2017-05-12 09:37 UTC by Dinu-Razvan Chis-Serban
Modified: 2018-09-07 06:26 UTC (History)
2 users (show)

See Also:
Kernel Version: 4
Regression: No
Bisected commit-id:

customizable lock timeout (2.54 KB, patch)
2017-05-12 09:37 UTC, Dinu-Razvan Chis-Serban
Details | Diff
same diff formatted as a patch (3.36 KB, application/mbox)
2018-09-05 07:54 UTC, Dominique Martinet
patch with Signed-off-by: (3.42 KB, patch)
2018-09-07 04:38 UTC, Dinu-Razvan Chis-Serban
Details | Diff

Description Dinu-Razvan Chis-Serban 2017-05-12 09:37:01 UTC
Created attachment 256483 [details]
customizable lock timeout

The 30 seconds sleep time between two lock release recheck in case of F_SETLKW it might be OK for real network shares, but if it used to export directory from host to guest, it is too big. So, the attached patch adds an option that can be specified at mount time so the wait time sent to schedule_timeout_interruptible can be customized. It defaults to the value of P9_LOCK_TIMEOUT.
Comment 1 Dominique Martinet 2018-09-05 07:54:28 UTC
Created attachment 278313 [details]
same diff formatted as a patch

I have no problem with that one, I'd like to post it almost as is under your name but I don't think I can do that because you just posted a diff and not a patch with a Signed-off-by tag.

I've attached the same diff as a patch with the following changes:
 - cast option * HZ to long to avoid int truncation (thanks C)
 - adjusted the wording of the new v9ses field comment
 - a commit message

could you please reupload the same patch with an extra ligne "Signed-off-by: your name <your mail>", or send it to the following after adding the line (output of get_maintainers.pl) via git send-email? (If you reattach it, I will just send the mail for you)

Feel free to adjust wording/whatever at the same time.

$ ./scripts/get_maintainer.pl < 0001-9p-locks-add-mount-option-for-lock-retry-interval.patch
Eric Van Hensbergen <ericvh@gmail.com> (maintainer:9P FILE SYSTEM)
Latchesar Ionkov <lucho@ionkov.net> (maintainer:9P FILE SYSTEM)
Dominique Martinet <asmadeus@codewreck.org> (maintainer:9P FILE SYSTEM)
v9fs-developer@lists.sourceforge.net (open list:9P FILE SYSTEM)
linux-kernel@vger.kernel.org (open list)

Dominique Martinet
Comment 2 Dinu-Razvan Chis-Serban 2018-09-07 04:38:26 UTC
Created attachment 278361 [details]
patch with Signed-off-by:
Comment 3 Dominique Martinet 2018-09-07 04:56:51 UTC
Thanks, I've just sent the patch to the kernel lists.

As said there, I'll queue it up to linux-next around next week, and should get that merged for 2.20 (so in linus' master branch early November at the start of next cycle)

Comment 4 Dinu-Razvan Chis-Serban 2018-09-07 06:26:38 UTC
Thank you for the support.

Note You need to log in before you can comment on or make changes to this bug.