Bug 194969 - [BISECTED] i2c designware regression
Summary: [BISECTED] i2c designware regression
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: I2C (show other bugs)
Hardware: Intel Linux
: P1 normal
Assignee: Drivers/I2C virtual user
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-23 16:56 UTC by paul
Modified: 2018-08-20 15:08 UTC (History)
3 users (show)

See Also:
Kernel Version: 4.9
Subsystem:
Regression: Yes
Bisected commit-id:


Attachments

Description paul 2017-03-23 16:56:26 UTC
Commit 2702ea7dbec5 ("i2c: designware: wait for disable/enable only if necessary") seems to break things on my (Bay Trail) Teclast x89 HD tablet.

Since kernel 4.9, and still in 4.11-rc3, my (goodix) touchscreen connected over i2c misses presses and/or release events which makes it basically unusable.

Reverting commit 2702ea7dbec5 in the 4.9 kernel does fix the issue.

However, reverting this commit in the 4.10 kernel does *not* fix the issue... so either this is a heisenbug, or there are two different bugs instead of one.

I'm trying to bisect the issue, between 4.9 (with 2702ea7dbec5 reverted) and 4.10, but most of the kernels I build between these two versions fail to boot, which makes things very difficult...
Comment 1 Jarkko Nikula 2017-03-27 08:24:44 UTC
Could you try how does v4.9.17 work with the revert? One difference between v4.9 and v4.9.17 is that commit 12688dc21f71 ("Revert "i2c: designware: detect when dynamic tar update is possible"") got reverted during v4.10 and was sent back to v4.9 stable kernels too.
Comment 2 paul 2017-03-28 10:28:20 UTC
Kernel v4.9.17 works fine with the revert, just like 4.9.0, so the commit you mention doesn't seem to be involved.
Comment 3 José Roberto de Souza 2017-03-29 21:46:55 UTC
Both patches were tested in a Bay Trail platform(Minnowboard Max) and Cherry Trail(Intel Aero) and worked with great performance improvements, did you have debug what is failing? There is any error returned after a I2C transaction?
Comment 4 paul 2017-03-30 13:38:26 UTC
Bug found and fix sent upstream: https://patchwork.kernel.org/patch/9654233/
Comment 5 José Roberto de Souza 2017-03-30 16:56:46 UTC
Nice :D
Comment 6 mirh 2018-08-20 15:08:32 UTC
Should have landed by v4.14-rc6. 
Can be closed then?

Note You need to log in before you can comment on or make changes to this bug.