Bug 194801 - e1000e: __pci_enable_msi_range fails before/after resume
Summary: e1000e: __pci_enable_msi_range fails before/after resume
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Network (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: drivers_network@kernel-bugs.osdl.org
URL:
Keywords:
: 194807 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-03-06 15:18 UTC by Rouven Czerwinski
Modified: 2017-04-07 07:58 UTC (History)
3 users (show)

See Also:
Kernel Version: 4.11-rc1
Subsystem:
Regression: No
Bisected commit-id:


Attachments
dmesg 4.11-rc1 (10.64 KB, text/plain)
2017-03-06 15:18 UTC, Rouven Czerwinski
Details

Description Rouven Czerwinski 2017-03-06 15:18:33 UTC
Created attachment 255101 [details]
dmesg 4.11-rc1

On 4.11-rc1 the whole ethernet subsystem seems to hang after a suspend/resume cycle, see attached dmesg.
Comment 1 Rouven Czerwinski 2017-03-06 21:07:00 UTC
Commit 7e54d9d063fa239c95c21548c5267f0ef419ff56 moved the e1000e_reset_interrupt_capability(adapter) call into the netif_running conditional, meaning the interrupts will only be reset if the network interface is up, which is not necessarily the case on my Laptop and pm_freeze is called to suspend it. Reverting the commit fixes my issue.
Comment 2 Chen Yu 2017-03-13 02:18:34 UTC
*** Bug 194807 has been marked as a duplicate of this bug. ***
Comment 3 The Linux kernel's regression tracker (Thorsten Leemhuis) 2017-03-14 09:28:43 UTC
@Chen Yu, others: What's the status of this? are the e1000e developers aware of this? Did anyone brought it forward on their list and/or the network developers?

JFYI: I added this report to the list of regressions for Linux 4.11.
I'll watch this place for further updates on this issue to document
progress in my weekly reports, hence to allow me to keep track please send a quick note here in case this issue gets discussed somewhere else.
Comment 4 Rouven Czerwinski 2017-03-14 10:41:49 UTC
There is an ongoing discussion on LKML starting with this message:
https://lkml.org/lkml/2017/3/12/6
The tester of the above mentioned commit posted to this thread as well.
Comment 5 Shawn Starr 2017-04-03 02:22:06 UTC
This is still not fixed in -rc5, any chance this will be reverted before 4.11 is released?
Comment 6 Rouven Czerwinski 2017-04-03 05:10:15 UTC
The revert is already sitting in davems tree, see https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/drivers/net/ethernet/intel/e1000e/netdev.c?id=9f47a48e6eb97d793db85373e3ef4c55d876d334, we'll just have to wait for the next net pull, which will surely happen before the 4.11 release.
Comment 7 Rouven Czerwinski 2017-04-07 07:58:20 UTC
The revert hit Linus tree with the pull from daves net tree, closing this issue.

Note You need to log in before you can comment on or make changes to this bug.