Bug 194341 - drivers/scsi/mpt3sas/mpt3sas_scsih.c _scsih_ir_fastpath ambiguous path structures
Summary: drivers/scsi/mpt3sas/mpt3sas_scsih.c _scsih_ir_fastpath ambiguous path struct...
Status: NEW
Alias: None
Product: SCSI Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 enhancement
Assignee: scsi_drivers-other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-07 06:04 UTC by Michael
Modified: 2017-02-07 06:04 UTC (History)
0 users

See Also:
Kernel Version: 4.10
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Michael 2017-02-07 06:04:35 UTC
Given the number of error checks and intermittent conditional branches all ending with the same error code, it may be worth restructuring this path to optimistically execute the fast path and then have a single set of error checks at the end, since all of the errors immediately exit the function with a error code anyways.

Note You need to log in before you can comment on or make changes to this bug.