Bug 194281 - net/unix/af_unix.c unix_stream_sendpage condition should check fast path first
Summary: net/unix/af_unix.c unix_stream_sendpage condition should check fast path first
Status: RESOLVED INVALID
Alias: None
Product: Networking
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 enhancement
Assignee: Stephen Hemminger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-07 05:55 UTC by Michael
Modified: 2017-02-07 16:37 UTC (History)
0 users

See Also:
Kernel Version: 4.10
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael 2017-02-07 05:55:17 UTC 
The fast path (L2007) of this function should be called as early as possible.  I don't fully understand the semantics of the function, but is this fast path condition dependent on all the conditional branches before it?  The branches seem poorly structured regardless (lots of redundant conditions).
Comment 1 Stephen Hemminger 2017-02-07 16:37:10 UTC 
Please post design questions to mailing list netdev@vger.kernel.org not bugzilla
Note You need to log in before you can comment on or make changes to this bug.