Bug 193341 - AMDGPU: kernel NULL pointer dereferenced with hybrid graphics
Summary: AMDGPU: kernel NULL pointer dereferenced with hybrid graphics
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Video(DRI - non Intel) (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: drivers_video-dri
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-27 07:38 UTC by stefan.kohek
Modified: 2017-03-01 09:56 UTC (History)
3 users (show)

See Also:
Kernel Version: 4.9.6
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Kernel config, output of dmesh (with stack trace), output of lspci (64.93 KB, application/binary)
2017-01-27 07:38 UTC, stefan.kohek 		Details
possible fix (1.32 KB, patch)
2017-01-27 15:34 UTC, Alex Deucher 		Details | Diff
possible fix (1.06 KB, patch)
2017-02-10 23:14 UTC, Alex Deucher 		Details | Diff
Dmesg of 4.10.1-1-ARCH #1 SMP PREEMPT Sun Feb 26 21:08:53 UTC 2017 x86_64 GNU/Linux (63.93 KB, text/plain)
2017-02-28 16:47 UTC, stefan.kohek 		Details
Add an attachment (proposed patch, testcase, etc.)

Description stefan.kohek 2017-01-27 07:38:16 UTC 
Created attachment 253261 [details]
Kernel config, output of dmesh (with stack trace), output of lspci

The driver crashes when AMDGPU is used with a combination of R5 M230 and MULLINS.

The driver work with MULLINS OK, when discrete GPU (01:00.0  R5 M230) is disabled (in bios).

Kernel: Linux LenovoPC 4.9.6-1-ARCH #1 SMP PREEMPT Thu Jan 26 09:22:26 CET 2017 x86_64 GNU/Linux

Relevant config:
CONFIG_DRM_AMDGPU=m
CONFIG_DRM_AMDGPU_SI=y
CONFIG_DRM_AMDGPU_CIK=y
CONFIG_DRM_AMDGPU_USERPTR=y

I understand this is experimental case. Anyway, maybe somebody will fix it.  

This case work OK with RADEON driver (even offloading).
Comment 1 Michel Dänzer 2017-01-27 08:55:49 UTC 
Same as https://bugzilla.kernel.org/show_bug.cgi?id=193341 .
Comment 2 Michel Dänzer 2017-01-27 08:56:16 UTC 
Sorry, I mean https://bugs.freedesktop.org/show_bug.cgi?id=99387 .
Comment 3 Alex Deucher 2017-01-27 15:34:40 UTC 
Created attachment 253281 [details]
possible fix

This patch should fix the crash.
Comment 4 Marco Piazza 2017-02-10 22:34:10 UTC 
Attached logs about amdgpu kernel oops on hybrid gpu (KABINI+HAINAN)
                                                            
4.9.9: https://bugs.freedesktop.org/show_bug.cgi?id=99387#c13
                                                               
4.9.2: https://bugs.freedesktop.org/show_bug.cgi?id=99387#c14
Comment 5 Alex Deucher 2017-02-10 23:14:24 UTC 
Created attachment 254699 [details]
possible fix

This should fix it (along with the previous patch).
Comment 6 Luya Tshimbalanga 2017-02-16 06:43:34 UTC 
Greetings,
I am the original reported on Freedesktop bug report. I have a similar hardware in this case Kaveri and R5 M230 (Hainan or Jet Pro). 
The fix as mentioned on comment #5 is working fine.
Comment 7 stefan.kohek 2017-02-28 16:47:44 UTC 
Created attachment 254989 [details]
Dmesg of  4.10.1-1-ARCH #1 SMP PREEMPT Sun Feb 26 21:08:53 UTC 2017 x86_64 GNU/Linux

I'm not sure if all attached fixes were merged to kernel 4.10.1, but now I get different error (when trying to use the discrete GPU).
Comment 9 stefan.kohek 2017-03-01 09:56:13 UTC 
With this path is working fine. Thank you. 

Shader heavy games are now rendering twice as fast.
Note You need to log in before you can comment on or make changes to this bug.