Bug 189891 - Regression: acpi_get_table_with_size() triggers NFIT regressions
Summary: Regression: acpi_get_table_with_size() triggers NFIT regressions
Status: CLOSED CODE_FIX
Alias: None
Product: ACPI
Classification: Unclassified
Component: Config-Tables (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Lv Zheng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-09 01:48 UTC by Lv Zheng
Modified: 2016-12-12 07:38 UTC (History)
0 users

See Also:
Kernel Version: 4.9-rc8
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Lv Zheng 2016-12-09 01:48:14 UTC
From Dan Williams

This commit in -next (071b39575679 ACPICA: Tables: Back port
acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux
kernel) causes a regression in my nfit/nvdimm test environment. The
nfit produced by QEMU no longer results in a nvdimm bus being created.

I have not root caused it, but I'm using the following command line
options to create an nfit in qemu-2.6.  Reverting the commit leads
compile failures.

qemu=$HOME/git/qemu/build/x86_64-softmmu/qemu-system-x86_64
mem=$HOME/mem
label_size=$((128*1024))
mem_size=$(((3*1024*1024*1024) + (64 * 1024 *1024)))
IMAGE=$HOME/ahci.img

kvm=(
        $qemu
        -enable-kvm
        -cpu kvm64
        -kernel $kernel
        -initrd $initrd
        -m 12G,slots=3,maxmem=40G

        -machine pc-i440fx-2.4,accel=kvm,usb=off,vmport=off,nvdimm
        -cpu SandyBridge
        -smp 2
        -netdev tap,id=hostnet0,ifname=tap0,script=no,downscript=no
        -device
virtio-net-pci,netdev=hostnet0,id=net0,mac=52:54:00:b7:a1:ad,bus=pci.0,addr=0x7
        -object
memory-backend-file,id=mem1,share,mem-path=${mem},size=$((label_size +
mem_size))
        -device nvdimm,memdev=mem1,id=nv1,label-size=${label_size}
        -device ahci,id=sata0,bus=pci.0,addr=0x8
        -drive file=$IMAGE,if=none,id=drive-sata0-0-0,format=raw
        -device ide-hd,bus=sata0.0,drive=drive-sata0-0-0,id=sata0-0-0
        -boot order=nc
        -no-reboot
        -watchdog i6300esb
        -rtc base=localtime
        -serial stdio
        -display none
        -monitor null
)
Comment 1 Lv Zheng 2016-12-09 02:31:09 UTC
Fix is posted here:

https://patchwork.kernel.org/patch/9467407/
Comment 2 Lv Zheng 2016-12-12 07:38:37 UTC
The wrong commits are reverted from linux-next branch.
So this is not a regression for upstream.
I'll close this bug.

Note You need to log in before you can comment on or make changes to this bug.