Bug 187471 - f2fs as rootfs does not boot since 4.6 without explicit module inclusion in initramfs
Summary: f2fs as rootfs does not boot since 4.6 without explicit module inclusion in i...
Status: NEW
Alias: None
Product: File System
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: fs_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-12 00:39 UTC by Zachary Cook
Modified: 2020-06-16 19:28 UTC (History)
1 user (show)

See Also:
Kernel Version: 4.8.7
Tree: Mainline
Regression: No


Attachments
fixes bug by adding softdep on crypto-crc32 to f2fs (693 bytes, patch)
2016-11-28 00:10 UTC, Zachary Cook
Details | Diff

Description Zachary Cook 2016-11-12 00:39:41 UTC
Cannot boot without explicitly adding crc32 drivers to an initramfs since 4.6

F2FS fs: cannot load 'crc32' drivers

I tested a fix using softdeps, just adding 

MODULE_SOFTDEP("pre: crypto-crc32"); 

to the end of fs/f2fs/super.c and recompiling the module will allow initramfs tools supporting softdeps to autodetect needed modules without adding quirks to each tool, which has lead to errors, see: https://github.com/dracutdevs/dracut/commit/34a42f9f49d4ad8897c4890af5b9a455e1335c66 and https://bugs.archlinux.org/task/49380 for examples of this being worked around and both times the actual needed dependency was missed in the first attempt at fixing. It would be much better if the kernel module can list what it requires instead of other tools needing to guess.

Also see this related patch which has similar reasoning: http://www.spinics.net/lists/linux-fsdevel/msg98073.html
Comment 1 Zachary Cook 2016-11-28 00:10:34 UTC
Created attachment 246001 [details]
fixes bug by adding softdep on crypto-crc32 to f2fs

Note You need to log in before you can comment on or make changes to this bug.