Hi, I have a Thinkpad X240, which suspends (to RAM) and resumes just fine with 4.7.4. However, in 4.9.0-rc1, it completely refuses to resume; when I try to press the power button to resume it from sleep, it just ignores the request completely and keeps pulsing the light. bisect gives the following culprit: commit 0c541332231e7957f23013e37f3720db33e7804c Author: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Date: Fri Jun 17 13:12:20 2016 +0200 tpm: use tpm_pcr_read_dev() in tpm_do_selftest() Instead of a ad-hoc protocol message construction it is better to call tpm_pcr_read_dev(). Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> I haven't tried 4.9.0-rc2, because that just hangs directly off of GRUB from me.
On Monday, October 24, 2016 08:28:18 PM bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=181381 > > Bug ID: 181381 > Summary: Resume from suspend no longer works on Thinkpad X240 > Product: Power Management > Version: 2.5 > Kernel Version: 4.9.0-rc1 > Hardware: All > OS: Linux > Tree: Mainline > Status: NEW > Severity: normal > Priority: P1 > Component: Hibernation/Suspend > Assignee: rjw@rjwysocki.net > Reporter: steinar+kernel@gunderson.no > CC: jarkko.sakkinen@linux.intel.com > Regression: No > > Hi, > > I have a Thinkpad X240, which suspends (to RAM) and resumes just fine with > 4.7.4. However, in 4.9.0-rc1, it completely refuses to resume; when I try to > press the power button to resume it from sleep, it just ignores the request > completely and keeps pulsing the light. > > bisect gives the following culprit: > > commit 0c541332231e7957f23013e37f3720db33e7804c > Author: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Date: Fri Jun 17 13:12:20 2016 +0200 > > tpm: use tpm_pcr_read_dev() in tpm_do_selftest() > > Instead of a ad-hoc protocol message construction it is better to > call tpm_pcr_read_dev(). > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > I haven't tried 4.9.0-rc2, because that just hangs directly off of GRUB from > me. Jarkko, Jason, any chance to have a look at this? Thanks, Rafael
May be this (It has Fixes: 0c541332231e ("tpm: use tpm_pcr_read_dev() in tpm_do_selftest()"): http://git.infradead.org/users/jjs/linux-tpmdd.git/commitdiff/65da72b7ddcdd8990e4783d09c7e86d90ccb4121?hp=1306d8e1c09fdc8ecb9ef235e2116352f810f9c5 There was some discussion here: http://www.gossamer-threads.com/lists/linux/kernel/2541771
On Mon, Oct 24, 2016 at 10:42:23PM +0200, Rafael J. Wysocki wrote: > On Monday, October 24, 2016 08:28:18 PM bugzilla-daemon@bugzilla.kernel.org > wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=181381 > > > > Bug ID: 181381 > > Summary: Resume from suspend no longer works on Thinkpad X240 > > Product: Power Management > > Version: 2.5 > > Kernel Version: 4.9.0-rc1 > > Hardware: All > > OS: Linux > > Tree: Mainline > > Status: NEW > > Severity: normal > > Priority: P1 > > Component: Hibernation/Suspend > > Assignee: rjw@rjwysocki.net > > Reporter: steinar+kernel@gunderson.no > > CC: jarkko.sakkinen@linux.intel.com > > Regression: No > > > > Hi, > > > > I have a Thinkpad X240, which suspends (to RAM) and resumes just fine with > > 4.7.4. However, in 4.9.0-rc1, it completely refuses to resume; when I try > to > > press the power button to resume it from sleep, it just ignores the request > > completely and keeps pulsing the light. > > > > bisect gives the following culprit: > > > > commit 0c541332231e7957f23013e37f3720db33e7804c > > Author: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > Date: Fri Jun 17 13:12:20 2016 +0200 > > > > tpm: use tpm_pcr_read_dev() in tpm_do_selftest() > > > > Instead of a ad-hoc protocol message construction it is better to > > call tpm_pcr_read_dev(). > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > > > I haven't tried 4.9.0-rc2, because that just hangs directly off of GRUB > from > > me. > > Jarkko, Jason, any chance to have a look at this? I've fixed this a while ago but the pull request is still on hold: http://www.spinics.net/lists/kernel/msg2356176.html > Thanks, > Rafael /Jarkko
Still present in Debian's 4.9rc3, observed on a ThinkPad X250.
(In reply to Steinar H. Gunderson from comment #0) > Hi, > > I have a Thinkpad X240, which suspends (to RAM) and resumes just fine with > 4.7.4. However, in 4.9.0-rc1, it completely refuses to resume; when I try to > press the power button to resume it from sleep, it just ignores the request > completely and keeps pulsing the light. > > bisect gives the following culprit: > > commit 0c541332231e7957f23013e37f3720db33e7804c > Author: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Date: Fri Jun 17 13:12:20 2016 +0200 > > tpm: use tpm_pcr_read_dev() in tpm_do_selftest() > > Instead of a ad-hoc protocol message construction it is better to > call tpm_pcr_read_dev(). > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > I haven't tried 4.9.0-rc2, because that just hangs directly off of GRUB from > me. does the problem still exist in the latest upstream kernel?
(In reply to Andreas Kloeckner from comment #4) > Still present in Debian's 4.9rc3, observed on a ThinkPad X250. hmmm, Andreas, this may or may not be the same problem. does the problem still exist with this kernel #git checkout 0c541332231e7957f23013e37f3720db33e7804c~ does the problem still exist with this kernel #git checkout 0c541332231e7957f23013e37f3720db33e7804c
$ git describe --contains befd99656c5eb765fe9d96045c4cba099fd938db v4.9-rc4~25^2
No longer present in Debian's 4.9rc5. Thanks for the help!
good to hear! thanks for reporting this.