Bug 16076 - p54spi modalias mismatch with board_n800
Summary: p54spi modalias mismatch with board_n800
Status: RESOLVED CODE_FIX
Alias: None
Product: Networking
Classification: Unclassified
Component: Wireless (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: networking_wireless@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-30 02:49 UTC by Luke-Jr
Modified: 2010-06-22 18:42 UTC (History)
2 users (show)

See Also:
Kernel Version: 2.6.34-rc7
Subsystem:
Regression: No
Bisected commit-id:


Attachments
add cx3110x modalias (377 bytes, patch)
2010-06-01 18:28 UTC, Christian Lamparter
Details | Diff
replace internal cx3110x name with p54spi (1.00 KB, patch)
2010-06-01 20:41 UTC, Luke-Jr
Details | Diff

Description Luke-Jr 2010-05-30 02:49:56 UTC
p54spi thinks it is "cx3110x" while board_n800 is looking for "p54spi"
Comment 1 Christian Lamparter 2010-06-01 18:28:10 UTC
Created attachment 26597 [details]
add cx3110x modalias

No idea if that works or not. I don't have a N8x0.
If it doesn't, then this topic should probably go to:
linux-wireless@vger.kernel.org
Comment 2 Luke-Jr 2010-06-01 20:41:41 UTC
Created attachment 26603 [details]
replace internal cx3110x name with p54spi

No, that wouldn't work at all. I'm attaching the actual changes I made to fix it for me. I don't know if both parts are actually necessary, but it does work (and make sense). For reference, the comment removed in the patch is wrong (maybe it was true for some board-n800 that never got merged, but was never correct for mainline).
Comment 3 Christian Lamparter 2010-06-01 20:54:07 UTC
If you had a patch, why did you fill out a bug-report?
Anyway, please send your patch to linux-wireless@vger.kernel.org .

Regards,
   Chr
Comment 4 John W. Linville 2010-06-22 18:42:35 UTC
Queued for 2.6.36...

commit 5f1e83dbc3bddd97ef4a431fdca10dbdf4809f69
Author: Luke-Jr <luke@dashjr.org>
Date:   Tue Jun 1 21:16:53 2010 -0500

    p54spi: replace internal "cx3110x" name with "p54spi"
    
    While the comment removed in this patch claims board_n800.c uses
    "cx3110x", it was never merged to mainline like this.  Mainlined board
    files for Nokia N8x0 devices are expected "p54spi", and thus don't
    work because the modalias is "cx3110x".  To my knowledge, these
    devices are the only real-world use of p54spi, and will not work
    without this change.  Tested against my Nokia N810.
    
    Signed-off-by: Luke Dashjr <luke-jr+git@utopios.org>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

Note You need to log in before you can comment on or make changes to this bug.