Bug 16075 - Dell Studio 1555 eject key does not work
Summary: Dell Studio 1555 eject key does not work
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Platform (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: acpi_platform-drivers@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-29 10:40 UTC by Islam Motab
Modified: 2012-07-20 12:42 UTC (History)
5 users (show)

See Also:
Kernel Version: 2.6.34
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Fallback to buffer_entry 2 in case 1 is 0x0 (401 bytes, patch)
2010-05-30 06:17 UTC, Islam Motab 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description Islam Motab 2010-05-29 10:40:08 UTC 
Pressing the eject key on my Dell Studio 1555 does not work and dmesg produces this message : dell-wmi: Unknown key 0 pressed
Comment 1 Islam Motab 2010-05-30 06:15:20 UTC 
I've added a debugging printk in dell-wmi after line 222 like this :

printk(KERN_INFO "dell:wmi 0x%x , 0x%x \n", buffer_entry[1], buffer_entry[2]);

Dmesg now shows :

dell:wmi 0x0 , 0xe009 
dell-wmi: Unknown key 0 pressed

So for some reason buffer_entry[1] is used although it is empty.
Comment 2 Islam Motab 2010-05-30 06:17:53 UTC 
Created attachment 26579 [details]
Fallback to buffer_entry 2 in case 1 is 0x0

The attached patch fixes the eject key for me falling back to buffer_entry[2] in case buffer_entry[1] is 0x0 . 

I suspect it might be better to fix the "dell_new_hk_type" logic though.
Comment 3 Islam Motab 2010-05-30 06:44:29 UTC 
I think this bug is better placed in ACPI - platform drivers but I don't have permission to do so. Can someone with the correct privileges do that please ? Thanks :)
Comment 4 Andrew Morton 2010-06-02 20:15:34 UTC 
Please don't send patches via bugzilla - it causes lots of problems with
our usual patch management and review processes.

Please send this patch via email as per Documentation/SubmittingPatches. 
Suitable recipients may be found via scripts/get_maintainer.pl.  Please
also cc myself on the email.

Thanks.
Note You need to log in before you can comment on or make changes to this bug.