Bug 15812 - utsname.domainname not set in x86_32 processes (causing "YPBINDPROC_DOMAIN: domain not bound" errors)
utsname.domainname not set in x86_32 processes (causing "YPBINDPROC_DOMAIN: d...
Status: CLOSED CODE_FIX
Product: Platform Specific/Hardware
Classification: Unclassified
Component: x86-64
All Linux
: P1 normal
Assigned To: platform_x86_64@kernel-bugs.osdl.org
:
Depends on:
Blocks: 15310
  Show dependency treegraph
 
Reported: 2010-04-19 21:28 UTC by adi
Modified: 2010-05-04 19:39 UTC (History)
4 users (show)

See Also:
Kernel Version: 2.6.34-rc4
Tree: Mainline
Regression: Yes


Attachments

Description adi 2010-04-19 21:28:40 UTC
2.6.34-rc4 uname(2) from a x86_32 process copies out 325 bytes rather than the 390 bytes that 2.6.31 copied out (and that userland expects):

2.6.31.12% cat foo.c
main()
{
        char buf[1000];
        memset(buf, 'x', sizeof(buf));
        uname(buf);
        write(1, buf, sizeof(buf));
        return 0;
}
2.6.31.12% i686-linux-gcc foo.c
2.6.31.12% ./a.out | hd
00000000  4c 69 6e 75 78 00 00 00  00 00 00 00 00 00 00 00  |Linux...........|
00000010  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
00000040  00 63 76 70 65 34 33 30  30 00 00 00 00 00 00 00  |.cvpe4300.......|
00000050  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
00000080  00 00 32 2e 36 2e 33 31  2e 31 32 2d 63 76 70 32  |..2.6.31.12-cvp2|
00000090  30 31 30 30 33 32 39 2d  30 30 31 34 38 2d 67 39  |0100329-00148-g9|
000000a0  61 38 62 36 36 61 00 00  00 00 00 00 00 00 00 00  |a8b66a..........|
000000b0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
000000c0  00 00 00 23 36 20 53 4d  50 20 54 75 65 20 41 70  |...#6 SMP Tue Ap|
000000d0  72 20 36 20 31 36 3a 30  33 3a 33 31 20 50 44 54  |r 6 16:03:31 PDT|
000000e0  20 32 30 31 30 00 00 00  00 00 00 00 00 00 00 00  | 2010...........|
000000f0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
00000100  00 00 00 00 78 38 36 5f  36 34 00 00 00 00 00 00  |....x86_64......|
00000110  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
00000140  00 00 00 00 00 28 6e 6f  6e 65 29 00 00 00 00 00  |.....(none).....|
00000150  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
00000180  00 00 00 00 00 00 78 78  78 78 78 78 78 78 78 78  |......xxxxxxxxxx|
00000190  78 78 78 78 78 78 78 78  78 78 78 78 78 78 78 78  |xxxxxxxxxxxxxxxx|
*
000003e0  78 78 78 78 78 78 78 78                           |xxxxxxxx|
000003e8

2.6.34-rc4% ./a.out | hd
00000000  4c 69 6e 75 78 00 00 00  00 00 00 00 00 00 00 00  |Linux...........|
00000010  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
00000040  00 63 76 70 2d 6c 6f 61  6e 65 72 2d 31 36 00 00  |.cvp-loaner-16..|
00000050  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
00000080  00 00 32 2e 36 2e 33 34  2d 72 63 34 2d 30 30 31  |..2.6.34-rc4-001|
00000090  31 35 2d 67 64 63 35 37  64 61 33 00 00 00 00 00  |15-gdc57da3.....|
000000a0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
000000c0  00 00 00 23 36 20 53 4d  50 20 46 72 69 20 41 70  |...#6 SMP Fri Ap|
000000d0  72 20 31 36 20 31 30 3a  34 31 3a 34 33 20 50 44  |r 16 10:41:43 PD|
000000e0  54 20 32 30 31 30 00 00  00 00 00 00 00 00 00 00  |T 2010..........|
000000f0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
00000100  00 00 00 00 78 38 36 5f  36 34 00 00 00 00 00 00  |....x86_64......|
00000110  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
00000140  00 00 00 00 00 78 78 78  78 78 78 78 78 78 78 78  |.....xxxxxxxxxxx|
00000150  78 78 78 78 78 78 78 78  78 78 78 78 78 78 78 78  |xxxxxxxxxxxxxxxx|
*
000003e0  78 78 78 78 78 78 78 78                           |xxxxxxxx|
000003e8

This results in 32-bit applications that attempt to use libnss_nis's getpwuid() to fail with "YPBINDPROC_DOMAIN: Domain not bound", because they use an uninitialized value for domainname.
Comment 1 Randy Dunlap 2010-04-19 21:46:52 UTC
On Mon, 19 Apr 2010 21:29:15 GMT bugzilla-daemon@bugzilla.kernel.org wrote:

> https://bugzilla.kernel.org/show_bug.cgi?id=15812
> 
>            Summary: utsname.domainname not set in x86_32 processes
>                     (causing "YPBINDPROC_DOMAIN: domain not bound" errors)
>            Product: Platform Specific/Hardware
>            Version: 2.5
>     Kernel Version: 2.6.34-rc4
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: x86-64
>         AssignedTo: platform_x86_64@kernel-bugs.osdl.org
>         ReportedBy: adi@hexapodia.org
>                 CC: hch@lst.de
>         Regression: Yes
> 
> 
> 2.6.34-rc4 uname(2) from a x86_32 process copies out 325 bytes rather than the
> 390 bytes that 2.6.31 copied out (and that userland expects):

Just to clarify (?), that's a 32-bit process on a 64-bit kernel, right?


> 2.6.31.12% cat foo.c
> main()
> {
>         char buf[1000];
>         memset(buf, 'x', sizeof(buf));
>         uname(buf);
>         write(1, buf, sizeof(buf));
>         return 0;
> }
> 2.6.31.12% i686-linux-gcc foo.c
> 2.6.31.12% ./a.out | hd
> 00000000  4c 69 6e 75 78 00 00 00  00 00 00 00 00 00 00 00  |Linux...........|
> 00000010  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> *
> 00000040  00 63 76 70 65 34 33 30  30 00 00 00 00 00 00 00  |.cvpe4300.......|
> 00000050  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> *
> 00000080  00 00 32 2e 36 2e 33 31  2e 31 32 2d 63 76 70 32  |..2.6.31.12-cvp2|
> 00000090  30 31 30 30 33 32 39 2d  30 30 31 34 38 2d 67 39  |0100329-00148-g9|
> 000000a0  61 38 62 36 36 61 00 00  00 00 00 00 00 00 00 00  |a8b66a..........|
> 000000b0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> 000000c0  00 00 00 23 36 20 53 4d  50 20 54 75 65 20 41 70  |...#6 SMP Tue Ap|
> 000000d0  72 20 36 20 31 36 3a 30  33 3a 33 31 20 50 44 54  |r 6 16:03:31 PDT|
> 000000e0  20 32 30 31 30 00 00 00  00 00 00 00 00 00 00 00  | 2010...........|
> 000000f0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> 00000100  00 00 00 00 78 38 36 5f  36 34 00 00 00 00 00 00  |....x86_64......|
> 00000110  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> *
> 00000140  00 00 00 00 00 28 6e 6f  6e 65 29 00 00 00 00 00  |.....(none).....|
> 00000150  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> *
> 00000180  00 00 00 00 00 00 78 78  78 78 78 78 78 78 78 78  |......xxxxxxxxxx|
> 00000190  78 78 78 78 78 78 78 78  78 78 78 78 78 78 78 78  |xxxxxxxxxxxxxxxx|
> *
> 000003e0  78 78 78 78 78 78 78 78                           |xxxxxxxx|
> 000003e8
> 
> 2.6.34-rc4% ./a.out | hd
> 00000000  4c 69 6e 75 78 00 00 00  00 00 00 00 00 00 00 00  |Linux...........|
> 00000010  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> *
> 00000040  00 63 76 70 2d 6c 6f 61  6e 65 72 2d 31 36 00 00  |.cvp-loaner-16..|
> 00000050  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> *
> 00000080  00 00 32 2e 36 2e 33 34  2d 72 63 34 2d 30 30 31  |..2.6.34-rc4-001|
> 00000090  31 35 2d 67 64 63 35 37  64 61 33 00 00 00 00 00  |15-gdc57da3.....|
> 000000a0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> *
> 000000c0  00 00 00 23 36 20 53 4d  50 20 46 72 69 20 41 70  |...#6 SMP Fri Ap|
> 000000d0  72 20 31 36 20 31 30 3a  34 31 3a 34 33 20 50 44  |r 16 10:41:43 PD|
> 000000e0  54 20 32 30 31 30 00 00  00 00 00 00 00 00 00 00  |T 2010..........|
> 000000f0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> 00000100  00 00 00 00 78 38 36 5f  36 34 00 00 00 00 00 00  |....x86_64......|
> 00000110  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
> *
> 00000140  00 00 00 00 00 78 78 78  78 78 78 78 78 78 78 78  |.....xxxxxxxxxxx|
> 00000150  78 78 78 78 78 78 78 78  78 78 78 78 78 78 78 78  |xxxxxxxxxxxxxxxx|
> *
> 000003e0  78 78 78 78 78 78 78 78                           |xxxxxxxx|
> 000003e8
> 
> This results in 32-bit applications that attempt to use libnss_nis's getpwuid()
> to fail with "YPBINDPROC_DOMAIN: Domain not bound", because they use an
> uninitialized value for domainname.
> 
> -- 
> Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.


---
~Randy
Comment 2 Andrew Morton 2010-04-19 21:55:34 UTC
erk.  Christoph, did "improve sys_newuname() for compat architectures" cause this?
Comment 3 adi 2010-04-19 21:57:13 UTC
(In reply to comment #1)
> > 2.6.34-rc4 uname(2) from a x86_32 process copies out 325 bytes rather than the
> > 390 bytes that 2.6.31 copied out (and that userland expects):
> 
> Just to clarify (?), that's a 32-bit process on a 64-bit kernel, right?

Yes, that's right, i686 process on amd64 kernel.

I'd prefer to keep the discussion in the lkml thread <20100419192147.GP11130@hexapodia.org> aka http://lkml.org/lkml/2010/4/19/272

Thanks,
-andy
Comment 4 Andrew Morton 2010-04-20 03:58:04 UTC
Merged x86-correctly-wire-up-the-newuname-system-call.patch into -mm.
Comment 5 Rafael J. Wysocki 2010-04-20 04:11:59 UTC
Handled-By : Christoph Hellwig <hch@lst.de>
Patch : https://patchwork.kernel.org/patch/93604/
Comment 6 Rafael J. Wysocki 2010-05-04 19:39:14 UTC
Fixed by commit 4cecd935f67bf46a9fe8037c710dd86651fcafe4 .

Note You need to log in before you can comment on or make changes to this bug.