Bug 15684 - Netlink is notifying RTNLGRP_IPV6_IFADDR instead of RTNLGRP_IPV6_IFINFO
Summary: Netlink is notifying RTNLGRP_IPV6_IFADDR instead of RTNLGRP_IPV6_IFINFO
Status: RESOLVED OBSOLETE
Alias: None
Product: Networking
Classification: Unclassified
Component: IPV6 (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Hideaki YOSHIFUJI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-02 18:34 UTC by Panisset
Modified: 2012-07-09 08:17 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.28-2
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Panisset 2010-04-02 18:34:59 UTC
It seems the inet6_ifinfo_notify function placed in "net/ipv6/addrconf.c" is notifying the wrong netlink group (RTNLGRP_IPV6_IFADDR) with ifinfo structure.

So I suggest the correction below (RTNLGRP_IPV6_IFINFO takes the place of RTNLGRP_IPV6_IFADDR):

void inet6_ifinfo_notify(int event, struct inet6_dev *idev)
{

...

   err = rtnl_notify(skb, net, 0, RTNLGRP_IPV6_IFINFO, NUL, GFP_ATOMIC);
...

errout:
   if (err < 0)
      rtnl_set_sk_err(net, RTNLGRP_IPV6_IFINFO, err);
}


Regards,
Eduardo Panisset.
Comment 1 Andrew Morton 2010-04-05 19:56:57 UTC
(switched to email.  Please respond via emailed reply-to-all, not via the
bugzilla web interface).

On Fri, 2 Apr 2010 18:35:14 GMT
bugzilla-daemon@bugzilla.kernel.org wrote:

> https://bugzilla.kernel.org/show_bug.cgi?id=15684
> 
>            Summary: Netlink is notifying RTNLGRP_IPV6_IFADDR instead of
>                     RTNLGRP_IPV6_IFINFO
>            Product: Networking
>            Version: 2.5
>     Kernel Version: 2.6.28-2
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: IPV6
>         AssignedTo: yoshfuji@linux-ipv6.org
>         ReportedBy: eduardo.panisset@gmail.com
>         Regression: No
> 
> 
> It seems the inet6_ifinfo_notify function placed in "net/ipv6/addrconf.c" is
> notifying the wrong netlink group (RTNLGRP_IPV6_IFADDR) with ifinfo
> structure.
> 
> So I suggest the correction below (RTNLGRP_IPV6_IFINFO takes the place of
> RTNLGRP_IPV6_IFADDR):
> 
> void inet6_ifinfo_notify(int event, struct inet6_dev *idev)
> {
> 
> ...
> 
>    err = rtnl_notify(skb, net, 0, RTNLGRP_IPV6_IFINFO, NUL, GFP_ATOMIC);
> ...
> 
> errout:
>    if (err < 0)
>       rtnl_set_sk_err(net, RTNLGRP_IPV6_IFINFO, err);
> }
>

Note You need to log in before you can comment on or make changes to this bug.