156561 – [oxygen] typo in ac97_fp_rec_volume_put

Bug 156561 - [oxygen] typo in ac97_fp_rec_volume_put

Summary: [oxygen] typo in ac97_fp_rec_volume_put

Status:	RESOLVED CODE_FIX

Alias:	None

Product:	Drivers
Classification:	Unclassified
Component:	Sound(ALSA) (show other bugs)
Hardware:	All Linux

Importance:	P1 normal
Assignee:	Jaroslav Kysela

URL:
Keywords:

Depends on:
Blocks:

Reported:	2016-09-12 11:24 UTC by Tom Yan
Modified:	2024-01-12 11:12 UTC (History)
CC List:	4 users (show)

See Also:
Kernel Version:	4.7
Subsystem:
Regression:	No
Bisected commit-id:

Attachments
[oxygen] Fix typo in ac97_fp_rec_volume_put (945 bytes, patch) 2017-01-01 19:52 UTC, Teodor Szente	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Description Tom Yan 2016-09-12 11:24:27 UTC

value[0] here should be value[1]:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/pci/oxygen/oxygen_mixer.c#n733

Compare ac97_fp_rec_volume_put with ac97_fp_rec_volume_get:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/pci/oxygen/oxygen_mixer.c?h=v4.7#n722

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/pci/oxygen/oxygen_mixer.c?h=v4.7#n708

Comment 1 Teodor Szente 2017-01-01 19:52:28 UTC

Created attachment 249541 [details]
[oxygen] Fix typo in ac97_fp_rec_volume_put

Comment 2 Thomas 2024-01-12 10:53:24 UTC

This patch fixes an audio distortion issue on modern (currently 6.6.8) kernels for me. Thanks a lot.

Comment 3 Takashi Iwai 2024-01-12 11:12:09 UTC

This one was completely overlooked.  Now I submitted and merged the trivial fix.

Note You need to log in before you can comment on or make changes to this bug.