Bug 15332 - Need printk's in drivers/usb/storage/usb.c
Need printk's in drivers/usb/storage/usb.c
Status: RESOLVED INVALID
Product: Drivers
Classification: Unclassified
Component: USB
All Linux
: P1 blocking
Assigned To: Greg Kroah-Hartman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-17 01:38 UTC by Barry Kauler
Modified: 2012-02-22 21:05 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.33-rc8
Tree: Mainline
Regression: No


Attachments

Description Barry Kauler 2010-02-17 01:38:23 UTC
The 'init' script in Puppy Linux needs the kernel log messages such as:

usb-storage: device found at 3
usb-storage: waiting for device to settle before scanning
usb-storage: device scan complete

I looked at the changes in drivers/usb/storage/usb.c and the printk functions that produce these messages were removed in 2.6.33-rc1.

Can we please have them back?
Comment 1 Greg Kroah-Hartman 2010-02-17 04:51:11 UTC
No, you should not be grepping kernel logs for init sequences, no other distro
needs this.  Please file a bug with your distro to fix their code.
Comment 2 Andrew Morton 2010-02-17 04:58:13 UTC
What are the effects of this change upon users of Puppy Linux?
Comment 3 Greg Kroah-Hartman 2010-02-17 05:09:16 UTC
Wait, those messages are still there, I see them.

I think you do not have this module built in your kernel properly, given your
other bug report.

Have you really loaded the module?
Comment 4 Barry Kauler 2010-02-17 08:05:28 UTC
Sorry about my other bug report (15333), it was invalid, I closed it.

Those messages are not there, they were removed in 2.6.33-rc1:

http://www.linuxhq.com/kernel/v2.6/33-rc1/drivers/usb/storage/usb.c

...hmmm, unless they have been put back after -rc8?

I'm one of the lead developers of Puppy Linux, and the founder.

Puppy has a unique 'init' script, and we have always relied on those messages. As they are not there, the init script times out waiting for them, and this results in a longer boot time.

The init script needs to know when the usb-storage module has found all devices and finished scanning. It has to know this at a certain point in the script before proceeding.

If you can tell us some other way to determine that usb_storage has finished scanning, then we will use it. Otherwise, if you won't put the printk's back, I will be forced to patch it myself and put them back.

Note, Puppy Linux does not use udevd in the initramfs.
Comment 5 Barry Kauler 2010-02-17 08:30:54 UTC
"No, you should not be grepping kernel logs for init sequences, no other distro
needs this."

...hmmm, how do you know this? Have you studied the init scripts of the hundreds of distros out there?

The thing is, those messages from usb-storage.ko have always been there. We have relied upon them for years.

Even if one kernel developer thinks that ideally they should not be there, they should not be removed just like that, at the whim of one kernel developer. Instead, it should be put out for wider discussion first.
Comment 6 Greg Kroah-Hartman 2012-02-22 21:05:55 UTC
All USB bugs should be sent to the linux-usb@vger.kernel.org mailing 
list, and not entered into bugzilla.  Please bring this issue up there,
if it is still a problem in the latest kernel release.

Note You need to log in before you can comment on or make changes to this bug.