Bug 15053 - No connectivity with tg3 since 87668d352aa8d135bd695a050f18bbfc7b50b506
No connectivity with tg3 since 87668d352aa8d135bd695a050f18bbfc7b50b506
Status: CLOSED CODE_FIX
Product: Drivers
Classification: Unclassified
Component: Network
All Linux
: P1 normal
Assigned To: drivers_network@kernel-bugs.osdl.org
:
Depends on:
Blocks: 14885
  Show dependency treegraph
 
Reported: 2010-01-13 08:22 UTC by Matthieu Verbert
Modified: 2010-01-15 21:53 UTC (History)
2 users (show)

See Also:
Kernel Version: 2.6.33-rcX
Tree: Mainline
Regression: Yes


Attachments

Description Matthieu Verbert 2010-01-13 08:22:02 UTC
The following commit broke (at least) DHCP on my Dell D830:

commit 87668d352aa8d135bd695a050f18bbfc7b50b506
Author: Matt Carlson <mcarlson@broadcom.com>
Date:   Fri Nov 13 13:03:34 2009 +0000

    tg3: Don't touch RCB nic addresses


Note that it may break all kinds of networking stuff with my hardware,
but I have no access to any LAN where I can use a fixed IP address...

I bisecting the issue and simply reverting this single commit (on top of
2.6.33-rc4 for instance) makes the adapter functional again.

lspci -vvv -nn -xxx returns:

09:00.0 Ethernet controller [0200]: Broadcom Corporation NetXtreme BCM5755M Gigabit Ethernet PCI Express [14e4:1673] (rev 02)
        Subsystem: Dell Device [1028:01fe]
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B- DisINTx+
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
        Latency: 0, Cache Line Size: 64 bytes
        Interrupt: pin A routed to IRQ 32
        Region 0: Memory at f9bf0000 (64-bit, non-prefetchable) [size=64K]
        Expansion ROM at <ignored> [disabled]
        Capabilities: [48] Power Management version 3
                Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot+,D3cold+)
                Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=1 PME-
        Capabilities: [50] Vital Product Data
                Product Name: Broadcom NetXtreme Gigabit Ethernet Controller
                Read-only fields:
                        [PN] Part number: BCM95755m
                        [EC] Engineering changes: 01FE.004
                        [SN] Serial number: 0123456789
                        [MN] Manufacture ID: 31 34 65 34
                        [RV] Reserved: checksum good, 28 byte(s) reserved
                Read/write fields:
                        [YA] Asset tag: XYZ01234567
                        [RW] Read-write area: 107 byte(s) free
                End
        Capabilities: [58] Vendor Specific Information <?>
        Capabilities: [e8] MSI: Enable+ Count=1/1 Maskable- 64bit+
                Address: 00000000fee0300c  Data: 41b9
        Capabilities: [d0] Express (v1) Endpoint, MSI 00
                DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s <4us, L1 unlimited
                        ExtTag+ AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
                DevCtl: Report errors: Correctable- Non-Fatal- Fatal- Unsupported-
                        RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
                        MaxPayload 128 bytes, MaxReadReq 4096 bytes
                DevSta: CorrErr- UncorrErr- FatalErr- UnsuppReq- AuxPwr+ TransPend-
                LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Latency L0 <4us, L1 <64us
                        ClockPM+ Surprise- LLActRep- BwNot-
                LnkCtl: ASPM L0s Enabled; RCB 64 bytes Disabled- Retrain- CommClk+
                        ExtSynch- ClockPM+ AutWidDis- BWInt- AutBWInt-
                LnkSta: Speed 2.5GT/s, Width x1, TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
        Capabilities: [100] Advanced Error Reporting
                UESta:  DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
                UEMsk:  DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
                UESvrt: DLP+ SDES- TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
                CESta:  RxErr+ BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr-
                CEMsk:  RxErr- BadTLP- BadDLLP- Rollover- Timeout- NonFatalErr+
                AERCap: First Error Pointer: 00, GenCap+ CGenEn- ChkCap+ ChkEn-
        Capabilities: [13c] Virtual Channel <?>
        Capabilities: [160] Device Serial Number 00-1d-09-ff-fe-d9-90-10
        Capabilities: [16c] Power Budgeting <?>
        Kernel driver in use: tg3
00: e4 14 73 16 06 05 10 00 02 00 00 02 10 00 00 00
10: 04 00 bf f9 00 00 00 00 00 00 00 00 00 00 00 00
20: 00 00 00 00 00 00 00 00 00 00 00 00 28 10 fe 01
30: 00 00 01 0c 48 00 00 00 00 00 00 00 0a 01 00 00
40: 00 00 00 00 00 00 00 00 01 50 03 c0 08 20 00 64
50: 03 58 fc 80 00 00 00 78 09 e8 78 00 11 0c 00 60
60: 00 00 00 00 00 00 00 00 98 02 02 a0 00 00 18 76
70: f2 10 00 00 a0 00 00 00 00 00 00 00 00 00 00 00
80: e4 14 73 16 00 00 00 00 34 00 13 04 82 f0 08 ec
90: 19 db 00 01 00 00 00 a2 00 00 00 00 2f 01 00 00
a0: 00 00 00 00 67 00 00 00 00 00 00 00 4a 01 00 00
b0: 00 00 00 00 00 00 00 dd 00 00 00 00 00 00 00 00
c0: 00 00 00 00 00 00 00 00 0e 00 00 00 00 00 00 00
d0: 10 00 01 00 a0 8f 04 05 00 50 10 00 11 6c 07 00
e0: 41 01 11 10 00 00 00 00 05 d0 81 00 0c 30 e0 fe
f0: 00 00 00 00 b9 41 00 00 00 00 00 00 00 00 00 00


Let me know if you want me to test any other patch...
Thanks,

Matthieu
Comment 1 Matt Carlson 2010-01-14 22:50:01 UTC
The fix for this bug spans two patches.   commit 13fa95b0398d65885a79c6e95a09976ee9f8c009 readjusts the changes imposed by the problematic patch.  commit 86cfe4ff02a51294cb2c974a8bedc7f648491df9 fixes problems introduced by a previous patch.  Together these patches solve the problem.
Comment 2 Matthieu Verbert 2010-01-15 07:40:40 UTC
I just recompiled 2.6.33-rc4-git2 (which contains the fix) and I can confirm that it indeed solves this issue.
Thanks a lot for your reactivity and your support !

Note You need to log in before you can comment on or make changes to this bug.