Bug 14920 - scripts/mkcompile_h should use absolute paths
Summary: scripts/mkcompile_h should use absolute paths
Status: CLOSED OBSOLETE
Alias: None
Product: Other
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 low
Assignee: other_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-28 22:18 UTC by Glenn Sommer
Modified: 2012-05-14 15:36 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.32.2
Tree: Mainline
Regression: No


Attachments
Use full path to dnsdomainname and domainname in mkcompile_h (649 bytes, patch)
2009-12-28 22:18 UTC, Glenn Sommer
Details | Diff

Description Glenn Sommer 2009-12-28 22:18:07 UTC
Created attachment 24333 [details]
Use full path to dnsdomainname and domainname in mkcompile_h

Currently scripts/mkcompile_h checks for /bin/dnsdomainname and /bin/domainname when trying to find the DNS name.
But when creating the file - the full absolute path to the executable isn't used.

IMO if we check for "/bin/dnsdomainname", we should also use "/bin/dnsdomainname" - and not blindly trust /bin is the first directory in $PATH.

I've attached a patch to use "/bin/dnsdomainname" instead of "dnsdomainname". And "/bin/domainname" instead of "domainname"
Comment 1 Alan 2010-01-19 16:04:43 UTC
Can you send the patch to linux-kernel@vger.kernel.org with a signed-off-by: line as per Documentation/SubmittingPatches

Thanks
Alan

Note You need to log in before you can comment on or make changes to this bug.