Bug 14607 - LED not working in ath5k AR242x subsystem 1a32:0112
Summary: LED not working in ath5k AR242x subsystem 1a32:0112
Status: CLOSED CODE_FIX
Alias: None
Product: Networking
Classification: Unclassified
Component: Wireless (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: networking_wireless@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-15 17:58 UTC by Shahar Or
Modified: 2009-12-08 13:50 UTC (History)
2 users (show)

See Also:
Kernel Version: 2.6.31
Subsystem:
Regression: No
Bisected commit-id:


Attachments
lspci -vnn (8.03 KB, text/plain)
2009-11-15 17:58 UTC, Shahar Or
Details

Description Shahar Or 2009-11-15 17:58:00 UTC
Created attachment 23789 [details]
lspci -vnn

I see three different reports saying the same thing, and I think they were solved in the same way, by adding a line with the subsystem id:

http://bugzilla.kernel.org/show_bug.cgi?id=12903
http://bugzilla.kernel.org/show_bug.cgi?id=13455
http://bugzilla.kernel.org/show_bug.cgi?id=12841

So here's a new one for my card:
0c:00.0 Network controller [0280]: Atheros Communications Inc. AR242x 802.11abg Wireless PCI Express Adapter [168c:001c] (rev 01)
        Subsystem: Device [1a32:0112]
        Flags: bus master, fast devsel, latency 0, IRQ 17
        Memory at f6cf0000 (64-bit, non-prefetchable) [size=64K]
        Capabilities: <access denied>
        Kernel driver in use: ath5k_pci
        Kernel modules: ath_pci, ath5k

Can't this be resolved in a way that the led will work for all subsystems?
Comment 1 John W. Linville 2009-11-16 13:53:16 UTC
I'm guessing we need some information on how the led is connected -- hopefully Bob can direct you on how to determine that?
Comment 2 Bob Copeland 2009-11-16 14:18:46 UTC
The values of led and polarity (usually 3,0) are needed.

It would be nice if this information was available in ACPI somewhere but I am unaware of where to look.  Atheros haven't told us how they determine the gpio programming for Windows.  We can add a modparam, I guess.
Comment 3 Shahar Or 2009-11-17 11:08:31 UTC
Since I'm not a developer I'm not familiar with all the terms you're using so if I can be of any assistance in debugging this please ask me directly and I will.
Comment 4 Shahar Or 2009-11-29 15:51:21 UTC
Does it make sense to just ask them? I'm willing to do that.
Comment 5 Shahar Or 2009-11-29 15:58:17 UTC
There's a bounty on this bug:
http://www.fossfactory.org/project/p187
Comment 6 Bob Copeland 2009-11-29 23:25:54 UTC
I have asked them before, without response.  You can be of assistance -- you need to try the led and polarity values for your hardware (since I can't test it myself).

So open up drivers/net/wireless/ath/ath5k/led.c, look for the part that says led_devices, then add something like:

/* name of laptop (your contact email) */
{ ATH_SDEVICE(PCI_VENDOR_ID_QMI, 0x0112), ATH_LED(3, 0) },


If that doesn't work, try ATH_LED(1, 0).  Let me know what works.  If you do get it working, do feel free to create a patch with your Signed-off-by and send it to John (see http://wireless.kernel.org/en/developers/Documentation/SubmittingPatches) -- then you can get credit for fixing it too :)
Comment 7 Shahar Or 2009-11-30 19:13:12 UTC
Dear Bob,

I did that using ATH_LED(3, 0) and now the WiFi LED seems to act as an activity indicator. Is that how it is supposed to act? I've only seen these LEDs work as on/off indicators.

Blessings.
Comment 8 Shahar Or 2009-12-08 10:36:35 UTC
The patch was committed. I don't know your bug tracking procedures so leaving it to you. Thank you, Bob.

http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=commit;h=6a213afd058436dbbd01098d7422c6a0073c39b5

And still, isn't there a way to get this working on all the devices? Information from Atheros, perhaps or something you said about ACPI? Can I help?

Note You need to log in before you can comment on or make changes to this bug.