Bug 14544 - Bit 6 swizzle detection is broken on older i965 laptops
Summary: Bit 6 swizzle detection is broken on older i965 laptops
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Video(DRI - Intel) (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Eric Anholt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-04 20:47 UTC by Alan Hourihane
Modified: 2012-04-18 21:29 UTC (History)
2 users (show)

See Also:
Kernel Version:
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Alan Hourihane 2009-11-04 20:47:13 UTC 
It seems that the kernel gets the bit 6 swizzling wrong for some older i965 laptops.

I've got a Dell Vostro 1700 and I've seen this also on a Dell D530 with the same behaviour and the code falls through to enabling...

   swizzle_x = I915_BIT_6_SWIZZLE_9_10;
   swizzle_y = I915_BIT_6_SWIZZLE_9;

whereas it really should be...

   swizzle_x = I915_BIT_6_SWIZZLE_NONE;
   swizzle_y = I915_BIT_6_SWIZZLE_NONE;

But I'm not sure given the current mechanism of detection what's the right way to fix it.
Comment 1 Jesse Barnes 2009-12-02 19:21:19 UTC 
Eric loves these swizzle bugs.
Comment 2 Jesse Barnes 2010-07-23 23:08:08 UTC 
Not sure this bug is still present or if it even matters anymore.  Eric or Alan?
Comment 3 Chris Wilson 2010-09-04 21:13:47 UTC 
Alan, can you attach the output from intel_reg_dumper?
Comment 4 Jesse Barnes 2012-04-18 21:29:47 UTC 
Marking as fixed.
Note You need to log in before you can comment on or make changes to this bug.