Bug 13587 - drivers/serial/bfin_sport_uart.c:235: bad call to memset
Summary: drivers/serial/bfin_sport_uart.c:235: bad call to memset
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Serial (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Russell King
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-20 13:27 UTC by David Binderman
Modified: 2009-07-08 14:36 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.30
Tree: Mainline
Regression: No


Attachments

Description David Binderman 2009-06-20 13:27:53 UTC
memset(buffer, 20, '\0');

Possible newbie coding error in that the 2nd & 3rd
parameter look the wrong way around to me.

Also, the coding police have noticed a lot
of mentions of the fixed constant "20" in the
same routine. Possible improve style by replacing
by a sizeof expression or other symbolic constant ?

Note You need to log in before you can comment on or make changes to this bug.