Bug 13440 - found overlapping data buffer
Summary: found overlapping data buffer
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-03 15:08 UTC by Martin Ettl
Modified: 2009-06-05 13:56 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.29.3
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Martin Ettl 2009-06-03 15:08:49 UTC 
Hello,

i detected an overlapping data buffer at file 
"linux-2.6.29.3/drivers/staging/rt2860/sta/assoc.c"
For detection, i used the static code analysis tool cppcheck. It prints the
following message:
[linux-2.6.29.3/drivers/staging/rt2860/sta/assoc.c:1815]: (error) Overlapping data buffer custom




Take a loop at file assoc.c at line 1815:

  sprintf(custom, "%s%02x", custom, pAd->StaCfg.ReqVarIEs[idx]);



Here, var "custom" is used by iteself, this is dangerous!!!!

Best regards

Ettl Martin
Note You need to log in before you can comment on or make changes to this bug.