Bug 13380 - Resume fauls on ASUS P5K
Summary: Resume fauls on ASUS P5K
Alias: None
Product: ACPI
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: acpi_other
Depends on:
Blocks: 7216 13070
  Show dependency tree
Reported: 2009-05-25 07:12 UTC by Christian Borntraeger
Modified: 2009-05-25 20:51 UTC (History)
2 users (show)

See Also:
Kernel Version: 2.6.30-rc6-git after 19bde778c1fd2574cc020a618d7d576f260271ca
Regression: Yes
Bisected commit-id:

lspci output (2.21 KB, text/plain)
2009-05-25 07:12 UTC, Christian Borntraeger
dmesg output (50.56 KB, text/plain)
2009-05-25 18:10 UTC, Christian Borntraeger

Description Christian Borntraeger 2009-05-25 07:12:47 UTC
Created attachment 21527 [details]
lspci output

this commit
commit 19bde778c1fd2574cc020a618d7d576f260271ca
Author: Len Brown <len.brown@intel.com>
Date:   Fri May 8 00:22:29 2009 -0400

    ACPI: suspend: don't let device _PS3 failure prevent suspend

causes resume to fail on my ASUS P5K.
Reverting this patch makes resume work again.
Comment 1 Christian Borntraeger 2009-05-25 18:10:12 UTC
Created attachment 21542 [details]
dmesg output

Got this dmesg output of a working kernel (2.6.30-rc6-git-00026-g0f6f49a + this hunk)
@@ -110,8 +110,13 @@ static int pnpacpi_disable_resources(struct pnp_dev *dev)
        /* acpi_unregister_gsi(pnp_irq(dev, 0)); */                           
        ret = 0;                                                              
-       if (acpi_bus_power_manageable(handle))
-               acpi_bus_set_power(handle, ACPI_STATE_D3);
+       if (acpi_bus_power_manageable(handle)) {
+               ret =acpi_bus_set_power(handle, ACPI_STATE_D3);
+               if (ret) {
+                       printk("--------acpi pnp returned %d\n", ret);
+                       return ret;
+               }
+       }
                /* continue even if acpi_bus_set_power() fails */
        if (ACPI_FAILURE(acpi_evaluate_object(handle, "_DIS", NULL, NULL)))
                ret = -ENODEV;

Please note that the printk does not trigger. Since dmesg contains 
"ACPI handle has no context!" the first if might be even false - will check.
In that case we have a change in behaviour:

in one case acpi_evaluate_object is called, in the other case it is not. Dont know if that matters.
Comment 2 Christian Borntraeger 2009-05-25 18:34:36 UTC
I did some more tests. Seems that the resume failure cannot be triggered reliably.  Sometimes it works with Lens patch. I have to consider that the bisect pinpointed the wrong patch. Lets close this problem until I have better evidence. :-(


Note You need to log in before you can comment on or make changes to this bug.